From: Krzysztof Kozlowski <krzk@kernel.org>
To: Lakshay Piplani <lakshay.piplani@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-i3c@lists.infradead.org" <linux-i3c@lists.infradead.org>,
"alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"robh@kernel.org" <robh@kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"broonie@kernel.org" <broonie@kernel.org>,
"lee@kernel.org" <lee@kernel.org>, Frank Li <frank.li@nxp.com>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>
Cc: Vikash Bansal <vikash.bansal@nxp.com>,
Priyanka Jain <priyanka.jain@nxp.com>,
Aman Kumar Pandey <aman.kumarpandey@nxp.com>
Subject: Re: [EXT] Re: [PATCH v16 4/8] mfd: p3h2x4x: Add driver for NXP P3H2x4x i3c hub and on-die regulator
Date: Wed, 9 Sep 2026 08:05:22 +0200 [thread overview]
Message-ID: <19a4c144-460b-4dcf-b173-23d14677e2d5@kernel.org> (raw)
In-Reply-To: <AS4PR04MB93626CB21700033FA2DD8AF8FBAC2@AS4PR04MB9362.eurprd04.prod.outlook.com>
On 28/08/2026 18:13, Lakshay Piplani wrote:
> Hi Krzysztof,
>
> Thanks for the review.
>
>>> +static const struct of_device_id p3h2x4x_i2c_of_match[] = {
>>> + { .compatible = "nxp,p3h2440", },
>>> + { .compatible = "nxp,p3h2441", },
>>> + { .compatible = "nxp,p3h2840", },
>>> + { .compatible = "nxp,p3h2841", },
>>
>> So devices are fully compatible? Why isn't this expressed in the binding? Or
>> explained in the commit msg?
>>
>
> Yes, from this driver's point of view. All four share the register
> interface used by the driver; the port count is read at runtime from
> DEV_CAPAB. The x0/x1 variants differ in their default/debug power-up
> configuration, and the driver applies the DT configuration during probe.
>
> I will explain this in the binding description and the commit message.
This is not what I asked. Why they are not made compatible?
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-09-09 6:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-26 10:38 [PATCH v16 0/8] Add support for NXP P3H2x4x I3C hub driver Lakshay Piplani
2026-08-26 10:38 ` [PATCH v16 1/8] i3c: master: Add APIs for I3C hub support Lakshay Piplani
2026-08-26 16:36 ` Frank Li
2026-08-26 10:38 ` [PATCH v16 2/8] i3c: master: Add controller-only device operation helpers Lakshay Piplani
2026-08-26 16:42 ` Frank Li
2026-08-27 7:02 ` Lakshay Piplani
2026-08-26 10:38 ` [PATCH v16 3/8] dt-bindings: i3c: Add NXP P3H2x4x i3c-hub support Lakshay Piplani
2026-08-26 10:38 ` [PATCH v16 4/8] mfd: p3h2x4x: Add driver for NXP P3H2x4x i3c hub and on-die regulator Lakshay Piplani
2026-08-27 10:03 ` Krzysztof Kozlowski
2026-08-28 16:13 ` [EXT] " Lakshay Piplani
2026-09-09 6:05 ` Krzysztof Kozlowski [this message]
2026-08-26 10:38 ` [PATCH v16 5/8] regulator: p3h2x4x: Add driver for on-die regulators in NXP P3H2x4x i3c hub Lakshay Piplani
2026-08-26 10:38 ` [PATCH v16 6/8] i3c: hub: Add support for the I3C interface in the I3C hub Lakshay Piplani
2026-08-27 10:09 ` Krzysztof Kozlowski
2026-08-28 20:16 ` [EXT] " Lakshay Piplani
2026-08-26 10:38 ` [PATCH v16 7/8] i3c: hub: p3h2x4x: Add support for NXP P3H2x4x I3C hub functionality Lakshay Piplani
2026-08-27 10:16 ` Krzysztof Kozlowski
2026-08-28 20:26 ` [EXT] " Lakshay Piplani
2026-08-26 10:38 ` [PATCH v16 8/8] i3c: hub: p3h2x4x: Add SMBus slave mode support Lakshay Piplani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19a4c144-460b-4dcf-b173-23d14677e2d5@kernel.org \
--to=krzk@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=aman.kumarpandey@nxp.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frank.li@nxp.com \
--cc=krzk+dt@kernel.org \
--cc=lakshay.piplani@nxp.com \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=priyanka.jain@nxp.com \
--cc=robh@kernel.org \
--cc=vikash.bansal@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®