mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michael Straube <straube.linux@gmail.com>
To: gregkh@linuxfoundation.org
Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: r8188eu: remove GET_CVID_ROM_VERSION
Date: Tue, 28 Dec 2021 09:54:22 +0100	[thread overview]
Message-ID: <19a72e84-4962-8c10-0608-4081887312c2@gmail.com> (raw)
In-Reply-To: <20211226184217.9726-1-straube.linux@gmail.com>

On 12/26/21 19:42, Michael Straube wrote:
> The macro GET_CVID_ROM_VERSION is not used. Remove it.
> 
> Signed-off-by: Michael Straube <straube.linux@gmail.com>
> ---
>   drivers/staging/r8188eu/include/HalVerDef.h | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/r8188eu/include/HalVerDef.h b/drivers/staging/r8188eu/include/HalVerDef.h
> index 1d96657e6a98..62b94c993f0d 100644
> --- a/drivers/staging/r8188eu/include/HalVerDef.h
> +++ b/drivers/staging/r8188eu/include/HalVerDef.h
> @@ -35,7 +35,6 @@ struct HAL_VERSION {
>   #define GET_CVID_CHIP_TYPE(version)	(((version).ChipType))
>   #define GET_CVID_MANUFACTUER(version)	(((version).VendorType))
>   #define GET_CVID_CUT_VERSION(version)	(((version).CUTVersion))
> -#define GET_CVID_ROM_VERSION(version)	(((version).ROMVer) & ROM_VERSION_MASK)
>   
>   /* Common Macro. -- */
>   /* HAL_VERSION VersionID */

This patch is outdated, please drop it.
I'll resend it as part of a series.

Thanks,
Michael

      reply	other threads:[~2021-12-28  8:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-26 18:42 Michael Straube
2021-12-28  8:54 ` Michael Straube [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19a72e84-4962-8c10-0608-4081887312c2@gmail.com \
    --to=straube.linux@gmail.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=phil@philpotter.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®