Re: [PATCH v2 4/9] arm64: dts: rockchip: Add power-domain to RK3368 DSI controller

[Quentin Schulz <quentin.schulz@cherry.de>]

Hi Heiko,

On 10/21/25 9:42 AM, Heiko Stuebner wrote:
> From: Heiko Stuebner <heiko.stuebner@cherry.de>
> 
> The DSI controller is also part of the VIO power-domain and it
> definitely needs to be on when accessing it to not cause SError
> faults, so add the power-domains property to it.
> 
> Fixes: 5023d0cd6183 ("arm64: dts: rockchip: Add DSI for RK3368")
> Signed-off-by: Heiko Stuebner <heiko.stuebner@cherry.de>
> ---
>   arch/arm64/boot/dts/rockchip/rk3368.dtsi | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3368.dtsi b/arch/arm64/boot/dts/rockchip/rk3368.dtsi
> index 8f0216203241..5b2cbb3003b6 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3368.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3368.dtsi
> @@ -896,6 +896,7 @@ mipi_dsi: dsi@ff960000 {
>   		clock-names = "pclk";
>   		phys = <&dphy>;
>   		phy-names = "dphy";
> +		power-domains = <&power RK3368_PD_VIO>;

Shouldn't we have the same for the PHY as well?

It's not entirely clear to me as pclk_dphytx0_phy seems to belong to 
PD_ALIVE according to page 62 of TRM v1.1, but Table 4-1 RK3368 Power 
Domain and Voltage Domain Summary doesn't seem to confirm that.

Cheers,
Quentin