From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 506DA388360 for ; Fri, 13 Mar 2026 10:20:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773397210; cv=none; b=m4lwQZ5Z7i9Bcm40FOmlt5nC1j3Xb6lu6C833sPgpUe8CSlL2dqjD79rL1+75/ID6Za5fzs6fyOqiVY6XzsOZGQq4Hdf9BaA+NwsUzGLSNrIoHdTojqaIc4yDwm7oK3xvkrEEMpxjchEsV/KfnZInhf7UZ9A17BSEhaDRdFcOhY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773397210; c=relaxed/simple; bh=QRHhS17FmInfjfzaTInaANXQhYqZtFtOsmaMJxe295s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=U+2cIXia4VVArdwHeZYUdVctD86jCl+JsWMYmO8i3LJMi+VF01Ad9Z3Xgb4e4B8xMqJ03XYMXqJMGrimrK5npRzXMDGEMrnf6rdm/IHXqaL50e2PxShkx6cFfdJr8WT7bVrQDsIKT20YR83X5vMuXyF9q6Y0x82z8PYsIQ2uL90= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=O9LMONvk; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=gFTAgee9; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="O9LMONvk"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="gFTAgee9" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62D5tmW23844431 for ; Fri, 13 Mar 2026 10:20:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= C5GWyweR8GJyu+q701PruVpq5YRzGNbSIhWI0RsI32o=; b=O9LMONvkz1MJwVu1 4mDumvWkef4mDErooZfYBSNruArlCTELUZkrsygODy4kd2n8IyqFk4hxKvzZ/2qj 13hl4795ZH1HafqOsaz+8L5e1B6gWVPDlv0qxwZ0yJkm5N5TmRX57I8Rj6GTisbV 8nMBpBi25GyRKuYPPjRCCykGTbNLd6bP4ZZlLu+zHHqX5TwRfUlqUDWFCMLIS+k8 qZUe599yXdwUwMz8w2VRYR3LaSCRnLp8Ka3h1k+Ut6xvlqnZQ3XpDH88xuzZaODU CEB4myj6fqmj2ulsCnx/voufWff88GW+ptRGQBdLCpUQOx41oAxWpWyUw1rf2auQ EPsWSQ== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cuh54wk35-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 13 Mar 2026 10:20:04 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-899ebdd0b08so11785176d6.3 for ; Fri, 13 Mar 2026 03:20:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773397204; x=1774002004; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=C5GWyweR8GJyu+q701PruVpq5YRzGNbSIhWI0RsI32o=; b=gFTAgee9pFHqOpm0ykfZdW2Z15AKFKe031i79WSBvQHrwAWgJdxPuj7V9A7gicFDck BXdxilVAHCacGTz9FLg7r7WMqpLUKaaYLweye+VtXyG1gRdgYSJa8PXRnrYe1klp9XLF oP9Aw1jeMVt7VdFnnJo6F9idlKQ8h5b6R0i84jfgPml05SkwWy5oOfga9uohr97kWoxV EdFIRmr3HsYRcJKh/qS7zs9Lcgxi9MBwvFOq2dII9kjyIR9BixZBCmSMa5W4z2xTHEjs 9sja8MpoP74E3XL0wrriRDTbwlgItFnnGJX0PGlL1+xQDxifkTp59UNUipdwth/VJBRJ /NGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773397204; x=1774002004; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=C5GWyweR8GJyu+q701PruVpq5YRzGNbSIhWI0RsI32o=; b=CT76C+NknRMu6kyfovIuZ1wdk+UcjmGUZUtSPQJmeGVpyE5XV+UVkhVJPdj8VDt8+v uJ6YAxxgHg2i9zHcQTcAdH16anHH+3+Iau8OvjncgwdYWptX4DlyewybMJ7fYz1PCKY5 3W3JLPTk46HmcZsD+0Mke24kr8AaV0T/06SWy2t51MWBe4L8uGsu00lZan2jFiYvhe2r lj1SWTBbPI+QzBWgTkugiZ2Ti8JeOT7aDe+lob9GYrGHl315PC18iuXcjX3ePpuyVeYq IO+Pa1ls+fK4yuyQrKcndUwOP893v8KMyb6hZ3dsZnHEUfKM6g+WLccBAYN1lNrW8Y/n LWZg== X-Forwarded-Encrypted: i=1; AJvYcCVn81BuRq/6xLTmzKCaJAKbmdhmu9yH6/JQNZckTfSYuAaw8N5rP+7ShJ575qszeQxAKRHvH5g6Q1PFNhQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2N3nGbjDpwC67a5to6Y0dKhrE4RdwDL7au7m1SYuLmH94uHvS 05jCe2GFJMQ6iU0mAI15oTJ95uTytx01Poy3iJAAsXDjcEkGGMhO2YSeTjnJxbja9wQGzAXu5tq Lebof3J//Lyrvqs2iWetYPCSdTzA5/+/MFxfkRlXjbMcXkHhdBQ8l8VecpRmlzyrKTP4= X-Gm-Gg: ATEYQzzlqAn6cmP8ZdJ4VRrQ/cd4Dtm2uHJfBXbG4s5lrrVaXbBtyfN3MW6EEOME0OD rO3XfoN6w0bDk48AlRrk27dt6jCp4ANGhzG6DFWUoyuEs2H/RzlGlTayVLKxgesYRGyssk0/0hV MAEq/h+iQnEmsARi6YLzUdMtwh5uSkqNlMuYt07rkmmc8UzcMfCDZ0wdDDF/4jUTOJ2bK1YLUns O/IOc6kTbBIrfxnLE5oGxh7OpG2so6uGxEYmDjryD06QuYEPRNsfQmTuoTjeof5OI6CLBEEvypM 7xvLD7CTXjDvEVydGn2m5T5K3ePzUq0kXbCRRxFws6zYdECogjNwPatbN6sDSL+j+OXJ20qOwle oJGJ5z5TAT7yDfGm7x7GvhcnQl+TAk+9/1KxIMjeZKvRuaR5EbIx1CzW8NwmFys1h+cYulJxGtV j1OA0= X-Received: by 2002:a05:6214:5c89:b0:89a:44d7:6589 with SMTP id 6a1803df08f44-89a82032dc5mr27235596d6.8.1773397204234; Fri, 13 Mar 2026 03:20:04 -0700 (PDT) X-Received: by 2002:a05:6214:5c89:b0:89a:44d7:6589 with SMTP id 6a1803df08f44-89a82032dc5mr27235426d6.8.1773397203880; Fri, 13 Mar 2026 03:20:03 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b976cdb1d20sm35152166b.41.2026.03.13.03.20.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Mar 2026 03:20:02 -0700 (PDT) Message-ID: <19b36a86-12c7-4710-8f80-5e27c9c00e3c@oss.qualcomm.com> Date: Fri, 13 Mar 2026 11:19:59 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 17/27] drm/msm/mdss: use new helper to set amsbc To: Dmitry Baryshkov , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260312-ubwc-rework-v3-0-b7e8f800176a@oss.qualcomm.com> <20260312-ubwc-rework-v3-17-b7e8f800176a@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260312-ubwc-rework-v3-17-b7e8f800176a@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: uhAENrcy0jfr-P9pcSu5aP_Yc3an1QYN X-Authority-Analysis: v=2.4 cv=BNG+bVQG c=1 sm=1 tr=0 ts=69b3e4d4 cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=e-ZaeZba6QCqovTgSgsA:9 a=QEXdDO2ut3YA:10 a=zgiPjhLxNE0A:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-ORIG-GUID: uhAENrcy0jfr-P9pcSu5aP_Yc3an1QYN X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEzMDA4MCBTYWx0ZWRfXy/C/sb/O9EkI +OrJsbCi8oBnzrDqRCEdH3K3L9A7DRMywYSQLo74L5MXz8A7Ud30Z8BmgnGz69hQoFXO+0rRk3D P1cp56NgXFmYRbYk95Dc0PDkpCeyhaXq/8iK55QEpFR5tJYr6ElspKQqZjU9hoiTil5mB0Vsn3t u8amwYkOl8ct91ePS0XRCk9aCDxJy8S74fiuSLvUXuYoUiBklPBYeoTF+A18MBSeX86zbBEjfaw /g0oH5ANStZMXYLhsmcIclaOtunL0xckoYwixk89dfyl54xOUXNQ3B4CYdn9UbWJXSMBhG3IQCi Af41m3pmAboTQH8TMFRvRfRNlfCLp/bO7b3eUvbA88ShPKkj6YUI3Xa7lDuFXN9L9L504meGMex RoGhRRR4pDpb9O9kn4uaJIL00eTkXR9WtMjR/beypbs3Gqx61b2Ma0wI0V1RvQpjOW5XHmt37ZK tHKhgceO14daAen4DUQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-13_02,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 bulkscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 adultscore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603130080 On 3/12/26 2:29 PM, Dmitry Baryshkov wrote: > Use freshly defined helper instead of checking the UBWC version > directly. > > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/msm_mdss.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c > index ca59bcdde7b2..04efc29f38cd 100644 > --- a/drivers/gpu/drm/msm/msm_mdss.c > +++ b/drivers/gpu/drm/msm/msm_mdss.c > @@ -188,7 +188,7 @@ static void msm_mdss_5x_setup_ubwc(struct msm_mdss *msm_mdss) > if (qcom_ubwc_macrotile_mode(data)) > value |= MDSS_UBWC_STATIC_MACROTILE_MODE; > > - if (data->ubwc_enc_version == UBWC_3_0) > + if (qcom_ubwc_enable_amsbc(data)) > value |= MDSS_UBWC_STATIC_UBWC_AMSBC; I know it's already there, but fwiw downstream doesn't seem to be concerned with toggling AMSBC in MDSS (perhaps incorrectly?) Konrad