From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA80DC6FD20 for ; Fri, 24 Mar 2023 10:11:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231614AbjCXKL5 (ORCPT ); Fri, 24 Mar 2023 06:11:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230259AbjCXKLu (ORCPT ); Fri, 24 Mar 2023 06:11:50 -0400 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A1876274BD for ; Fri, 24 Mar 2023 03:11:44 -0700 (PDT) Received: by mail-wm1-x336.google.com with SMTP id n10-20020a05600c4f8a00b003ee93d2c914so2480177wmq.2 for ; Fri, 24 Mar 2023 03:11:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679652703; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:reply-to:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=begInB01sukj5RGggFoHNUNKWw4p2fTlflH92RQjtys=; b=HhT1nB29ydzX5PF0bXW52RYVNTs9v6IuqXvD72m0nvfScE2FIMQR8UlgwgNOuDzXAE zIU4NptYFbipst4gm3n2Brq4NesPRdckCLpMQaJfm4bj6o8eNQf1ppjkudLpJhwYmVlI j1MZ5zHTg+uFaTEZJWq5F6UmQhxkQh0QCR4+Qei8X6V1ar0BRu3Y15FkHMM9UU6/BOGE t4WMQ0Dsz8Fj9E3T3gBMkTvzaJ7vV7UBqPtUzfck8lOpxzz9+dCSmeEUL78WkPTtIT47 mbsrSgnBRz1yADJw34LQtf4jTvZhwVHkwqoyQWz7YZmRQ0ySlDycLQbDU69s5BqB71W+ qMxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679652703; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:reply-to:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=begInB01sukj5RGggFoHNUNKWw4p2fTlflH92RQjtys=; b=RAjM3PPaluPenpDD6nJwZPxMR0NP6kOm5Pl/JX5PNSP5rO34ECb+2FzQtX9qHPAnMO 7GnkRJ6Tnfm7ocBuj0K2VdOCCYgGwOlIkwS9nomMiyK6b5NXGwlfowLXcPVXLfN4dvTr nYWo6IjzwePqE4yIIJuT0cM4T2ME8TX4fa+BmMVb1MOA7vgFj3gSQ+jBIE0zeO6C8HMb EqGGehFJE8vXMGqM2HGoDNmNZAtThlNC9HmyqBpWGGTuFeOojCkT+qfTBcSVqjY7m2Mx bnutE8EpgtJEOyqX7ZPdMnbT3gZ9FkiGBBULLxduoiTrFplne5ybNRCnrydhIqA28n5/ q6fA== X-Gm-Message-State: AO0yUKUy6Un/dfqdnp6UYZ2dIMS47jGOS9XCcO6qbONVcPU3RSA1MaH2 iA+h9/fhiOnVot2w4vtOkIgjaA== X-Google-Smtp-Source: AK7set/9fgXTuSp8Lq5Om/uWBWc1ygPFrBf1H4iOs0sxSyWuq5jLXqCdoTLtU1j867CZLG4lhpeziQ== X-Received: by 2002:a1c:ed14:0:b0:3e1:374:8b66 with SMTP id l20-20020a1ced14000000b003e103748b66mr1808811wmh.40.1679652703013; Fri, 24 Mar 2023 03:11:43 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:213f:a579:70af:e4a0? ([2a01:e0a:982:cbb0:213f:a579:70af:e4a0]) by smtp.gmail.com with ESMTPSA id fc13-20020a05600c524d00b003ee65e7acbcsm4700489wmb.20.2023.03.24.03.11.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Mar 2023 03:11:42 -0700 (PDT) Message-ID: <19b78f85-141e-eab7-2f4f-a30db3f8fb7e@linaro.org> Date: Fri, 24 Mar 2023 11:11:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH] thermal: amlogic: Use dev_err_probe() Content-Language: en-US To: ye.xingchen@zte.com.cn, glaroque@baylibre.com Cc: rafael@kernel.org, daniel.lezcano@linaro.org, amitk@kernel.org, rui.zhang@intel.com, linux-pm@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org References: <202303241020110014476@zte.com.cn> From: Neil Armstrong Organization: Linaro Developer Services In-Reply-To: <202303241020110014476@zte.com.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/03/2023 03:20, ye.xingchen@zte.com.cn wrote: > From: Ye Xingchen > > Replace the open-code with dev_err_probe() to simplify the code. > > Signed-off-by: Ye Xingchen > --- > drivers/thermal/amlogic_thermal.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/thermal/amlogic_thermal.c b/drivers/thermal/amlogic_thermal.c > index 4bf36386462f..3abc2dcef408 100644 > --- a/drivers/thermal/amlogic_thermal.c > +++ b/drivers/thermal/amlogic_thermal.c > @@ -262,11 +262,8 @@ static int amlogic_thermal_probe(struct platform_device *pdev) > return PTR_ERR(pdata->regmap); > > pdata->clk = devm_clk_get(dev, NULL); > - if (IS_ERR(pdata->clk)) { > - if (PTR_ERR(pdata->clk) != -EPROBE_DEFER) > - dev_err(dev, "failed to get clock\n"); > - return PTR_ERR(pdata->clk); > - } > + if (IS_ERR(pdata->clk)) > + return dev_err_probe(dev, PTR_ERR(pdata->clk), "failed to get clock\n"); > > pdata->sec_ao_map = syscon_regmap_lookup_by_phandle > (pdev->dev.of_node, "amlogic,ao-secure"); Reviewed-by: Neil Armstrong