From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C443C433EF for ; Mon, 20 Jun 2022 12:05:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242373AbiFTMFK (ORCPT ); Mon, 20 Jun 2022 08:05:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241165AbiFTME6 (ORCPT ); Mon, 20 Jun 2022 08:04:58 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 74B5919F93 for ; Mon, 20 Jun 2022 05:04:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655726647; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3fWG6f9+wPyZUdKpzq6SUM1FvIBmD72g2Gxfy7zPec8=; b=dRwY5VDDBDHsFGzABSg0ZHQJQf/0K6G89yufHd/cc6ecWuwrkSmKOtbQZtw2ooojbH8+Z6 Okriva/0xWYGqosNB4QvPhZQxGFPdSjqEqXhlynEwxxNh+hyLzyoN8XvmUuyQgeoJ3IVCW P0FOGIfyUBbwe8fJwonIyioPZDuPlWI= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-502-lfj4OG9EOiSSHml7vZxSLA-1; Mon, 20 Jun 2022 08:04:06 -0400 X-MC-Unique: lfj4OG9EOiSSHml7vZxSLA-1 Received: by mail-ed1-f71.google.com with SMTP id f9-20020a056402354900b0042ded146259so8575752edd.20 for ; Mon, 20 Jun 2022 05:04:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=3fWG6f9+wPyZUdKpzq6SUM1FvIBmD72g2Gxfy7zPec8=; b=5wmkilZdnbHeAjQVPUi7YeA3WBXMvDiKUZfilJMrKVQGN1NRZLlYe9cHHmoqG6XQRx EwWWssqUu9kMHQxigo6TMMve9CvieX2KhPCcAJQGcSUTJ+6y9SICnEFLthIekxbPJdcd PC7kIB/qwmyrCc5npwE1Ju9l54VD7BUAMK7t2h4yYYQ3avYzDeoCtS3OZWs/RI/RVnvv /3htXC/mrQ3MXPrWlPzuhy+HqYeq/G8T7LXeextUeRrjedZ/otK7PTDFxBKq8fpxw78a YBoZhGYuougcb5JTeq9l1BPNA22KPdLlppMOhFTYmOCE4WzgHOzKqECJH/FhYL8FPWaD I8wg== X-Gm-Message-State: AJIora/OaYPzqRsValH5t7cN0PIcUI6/kvjzZOhy8SvcPu93n26AVpGn rxj42VcqYiMIw8Bur1ske6dKJeSRxcp4cuacLMlp46xugidMGo4CO5OCkO8GBlOchx8jqpuiLkU 1og/d6xptFOofDlDH+7rBqJnI X-Received: by 2002:a05:6402:11:b0:431:680c:cca1 with SMTP id d17-20020a056402001100b00431680ccca1mr29443288edu.420.1655726645154; Mon, 20 Jun 2022 05:04:05 -0700 (PDT) X-Google-Smtp-Source: AGRyM1u9VhJ+ObuyZNUvGoEylbYK2DQSNd9ckf8bXsZN3l2pKVlgkfhq7FwfxpWwysL4rM30ugQ6lg== X-Received: by 2002:a05:6402:11:b0:431:680c:cca1 with SMTP id d17-20020a056402001100b00431680ccca1mr29443254edu.420.1655726644932; Mon, 20 Jun 2022 05:04:04 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:9af8:e5f5:7516:fa89? ([2001:b07:6468:f312:9af8:e5f5:7516:fa89]) by smtp.googlemail.com with ESMTPSA id u20-20020a17090657d400b00712134a676asm5894961ejr.93.2022.06.20.05.03.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jun 2022 05:04:01 -0700 (PDT) Message-ID: <19bba1a0-8fb7-2aae-a65a-1111e29b92d3@redhat.com> Date: Mon, 20 Jun 2022 14:03:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 0/3] KVM: selftests: Consolidate ucall code Content-Language: en-US To: Sean Christopherson , Marc Zyngier , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda Cc: James Morse , Alexandru Elisei , Suzuki K Poulose , Atish Patra , David Hildenbrand , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Colton Lewis , Andrew Jones References: <20220618001618.1840806-1-seanjc@google.com> From: Paolo Bonzini In-Reply-To: <20220618001618.1840806-1-seanjc@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/18/22 02:16, Sean Christopherson wrote: > Consolidate the code for making and getting ucalls. All architectures pass > the ucall struct via memory, so filling and copying the struct is 100% > generic. The only per-arch code is sending and receiving the address of > said struct. > > Tested on x86 and arm, compile tested on s390 and RISC-V. I'm not sure about doing this yet. The SEV tests added multiple implementations of the ucalls in one architecture. I have rebased those recently (not the SEV part) to get more familiar with the new kvm_vcpu API for selftests, and was going to look at your old review next... Paolo