From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 316B6EB64DD for ; Tue, 8 Aug 2023 03:17:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231127AbjHHDRl (ORCPT ); Mon, 7 Aug 2023 23:17:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229592AbjHHDRh (ORCPT ); Mon, 7 Aug 2023 23:17:37 -0400 Received: from out30-99.freemail.mail.aliyun.com (out30-99.freemail.mail.aliyun.com [115.124.30.99]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 574E6E7; Mon, 7 Aug 2023 20:17:36 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R371e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045192;MF=xueshuai@linux.alibaba.com;NM=1;PH=DS;RN=24;SR=0;TI=SMTPD_---0VpJIIhI_1691464649; Received: from 30.240.115.244(mailfrom:xueshuai@linux.alibaba.com fp:SMTPD_---0VpJIIhI_1691464649) by smtp.aliyun-inc.com; Tue, 08 Aug 2023 11:17:31 +0800 Message-ID: <19bc33e2-1f47-43d6-599c-3e48bb697f7c@linux.alibaba.com> Date: Tue, 8 Aug 2023 11:17:27 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [RESEND PATCH v7 0/2] ACPI: APEI: handle synchronous exceptions with proper si_code From: Shuai Xue To: rafael@kernel.org, wangkefeng.wang@huawei.com, tanxiaofei@huawei.com, mawupeng1@huawei.com, tony.luck@intel.com, naoya.horiguchi@nec.com, "james.morse@arm.com" Cc: linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, justin.he@arm.com, akpm@linux-foundation.org, ardb@kernel.org, ashish.kalra@amd.com, baolin.wang@linux.alibaba.com, bp@alien8.de, cuibixuan@linux.alibaba.com, dave.hansen@linux.intel.com, jarkko@kernel.org, lenb@kernel.org, linmiaohe@huawei.com, lvying6@huawei.com, xiexiuqi@huawei.com, zhuo.song@linux.alibaba.com References: <20230606074238.97166-1-xueshuai@linux.alibaba.com> <1fe4f86e-63ce-3702-4e08-4bc0e7bb391b@linux.alibaba.com> Content-Language: en-US In-Reply-To: <1fe4f86e-63ce-3702-4e08-4bc0e7bb391b@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/7/10 11:15, Shuai Xue wrote: > > > On 2023/6/16 15:15, Shuai Xue wrote: >> >> >> On 2023/6/6 15:42, Shuai Xue wrote: >>> changes since v6: >>> - add more explicty error message suggested by Xiaofei >>> - pick up reviewed-by tag from Xiaofei >>> - pick up internal reviewed-by tag from Baolin >>> >>> changes since v5 by addressing comments from Kefeng: >>> - document return value of memory_failure() >>> - drop redundant comments in call site of memory_failure() >>> - make ghes_do_proc void and handle abnormal case within it >>> - pick up reviewed-by tag from Kefeng Wang >>> >>> changes since v4 by addressing comments from Xiaofei: >>> - do a force kill only for abnormal sync errors >>> >>> changes since v3 by addressing comments from Xiaofei: >>> - do a force kill for abnormal memory failure error such as invalid PA, >>> unexpected severity, OOM, etc >>> - pcik up tested-by tag from Ma Wupeng >>> >>> changes since v2 by addressing comments from Naoya: >>> - rename mce_task_work to sync_task_work >>> - drop ACPI_HEST_NOTIFY_MCE case in is_hest_sync_notify() >>> - add steps to reproduce this problem in cover letter >>> >>> changes since v1: >>> - synchronous events by notify type >>> - Link: https://lore.kernel.org/lkml/20221206153354.92394-3-xueshuai@linux.alibaba.com/ >>> >>> >>> Shuai Xue (2): >>> ACPI: APEI: set memory failure flags as MF_ACTION_REQUIRED on >>> synchronous events >>> ACPI: APEI: handle synchronous exceptions in task work >>> >>> arch/x86/kernel/cpu/mce/core.c | 9 +-- >>> drivers/acpi/apei/ghes.c | 113 ++++++++++++++++++++++----------- >>> include/acpi/ghes.h | 3 - >>> mm/memory-failure.c | 17 +---- >>> 4 files changed, 79 insertions(+), 63 deletions(-) >>> >> >> >> Hi, Rafael, >> >> Gentle ping. >> >> Are you happy to queue this patch set or anything I can do to improve it? >> As @Kefeng said, this issue is met in Alibaba and Huawei products, we hope it >> could be fixed ASAP. > > Hi Rafael, Tony, and Naoya, > > Gentle ping. I am sorry to see that we have missed v6.3 and v6.4 merge window > since three Reviewed-by tags and one Tested-by tag. > > Do we still need any designated APEI reviewers Reviewed-by? Could you give me your > Reviewed-by @Tony, and @Naoya if you are happy with the change. > > Or Please could you Ack this change if you are happy with the proposal and the > change? @Rafael > Hi, ALL, Gentle ping. >> >> Thank you. >> >> Best Regards, >> Shuai