From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF3B1342CAE for ; Wed, 17 Dec 2025 11:14:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765970064; cv=none; b=iinhC8AoTYdtTJbeQYB9lYSCguS/VrF2uEHRFNt6VpTalGx7cqgDutxP8Eue5KN7nDnPeW4cuTqmrChTsIJZ15LyNDHNu2hpk3zvgR+MeiQawf8HmuT0thRVXoFqPwxCgADNf15lY38JuduYdYrB9Kge7JA6zGWbm0pW5Uqu/zA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765970064; c=relaxed/simple; bh=jJNrBqLbcXCuD9NuvkheDISIm9Smr08Oac6cB/MwqTk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EXmhE1IR0ibgpLyMnQP0lNgNuwwUEjNXLhlRI9XqigVKnq/R8qLWZES5UEWWl+iNq8Yu+Y6TIHwAxKOCgNc9PWYeZ0w0Aoq7nOE5uzQy3AjM/rrSXSymliSdM2J1LCJZRcTXR5L5+EuU1fYHRvTEyojOKOOaz7ve97Ww3ymQyLY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ffRi2XaI; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MlORJSy5; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ffRi2XaI"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MlORJSy5" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BH9pIh6008928 for ; Wed, 17 Dec 2025 11:14:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4e2ZqtFWUBOAn+zCPWxVaMcfcpDXuDusgMo4taKM2d0=; b=ffRi2XaIRw8BBlt4 kpTvKijZyFt/98jMhsetvourVTv3g1+TVe/QmJ6Ws1TN6rA5+ixb4vbDDmTRC7Bo 2XNogXULDSsI7ys0rGKhaOClD8Tt+W68rnd8aAKDQbodxDVBbB4Z7orI5zrX7hZ4 P/RgAoTfdE//tRoGA0qSVrgek+F/CiyrstYkcfWvZgsAYguDCI4AGul4I2UZocXe 3w6/MtStSHGBoZat/IlfamlAbJev1LrA2WD8BaJCIGKe5aZ9ymWQYK2atC+LuuMY EiANncygTC6m+nNwCX1lelQBsrTUO97wQUifNdM+T+YtUsB5HK3uZrGcvJnyILip cAqPUw== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b3t8e080c-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 17 Dec 2025 11:14:19 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4f1e17aa706so17431931cf.2 for ; Wed, 17 Dec 2025 03:14:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765970059; x=1766574859; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4e2ZqtFWUBOAn+zCPWxVaMcfcpDXuDusgMo4taKM2d0=; b=MlORJSy5cjdCUMA3Dwed21Ti2nSt8u/Tu2nvXjZ1eCycS1+A1QNbKBr4YSk9T9uxdA k8QL0Bl/1UIQ8rvOHYLwMsp9INaVYudJtbWJ8QHh3jaFxxtkxoldF5m/tit43pMCRM2D HurIxEBOROTt0B7FWt2OprauFFxuz/1DwLoqdbQ9k9j07HCNZk3bXdTDZFS1CgG/cRSk 6NmB2TAOfcf2nS8b6ucZ57vTdDMskUXC36NnWPwq8fpdiOLhmcDkiBLLBjrk6V9gbvC5 xW3ccz3aGAM2QxKBBcBLnP/gyqN0AXoDefeSjWDgJ3x48/gwfR+F5xju6vFKHcTvZ6Bv TeDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765970059; x=1766574859; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4e2ZqtFWUBOAn+zCPWxVaMcfcpDXuDusgMo4taKM2d0=; b=RM6zNgrrllFYhra4M2XuQggFrIsuuZhX+DSzgyVLquZVf/+5fOJmwAgV4oLnhAXbyK xrQwGghkMGwtaBiWlQJ9FQAms3wp3l6XICwv5LwVIMCsktbod8veINPF/qfMEMbJqbuI 7zn1PZvkxzJ1W9DDZdbtFBymelWdH1JYxxKQUgaoGR/SLm1omA1ozcx7qEaHHwJR5k6U v0ZzpBnpMLDmDPlfo8+zUQvWs/7knIH0L4X0V6W6rmq9iLIcO9VNhcMgu1luX5Fe/bRn 5H7RHdWvlgZVzkBNppXRYmT2ZH4gDPtv0X40MtNcC+cAd+VmbsT/Oi8x52+xMOPtY4CA oZkQ== X-Forwarded-Encrypted: i=1; AJvYcCWY9kvs/FsZ9W2cKXgIFSKiVnJa3h1xsfQBZ6ur/JKGFjOPVQawk3o4hzrUYs4J80MUiy9hVaSTNElDn0o=@vger.kernel.org X-Gm-Message-State: AOJu0YxOGTc0VNo1PtmS6qQ92nHFE+Yz865gU281A6PryLmrC03S8eTO f0nhUjEBPtfK8/ui3O6UxXyNNuNjckeYfBaqxQTOske4aJdHqDETDIPSt7XCVJF0EGJaTo848CB RI4Q35disVuQy/ld6bNvYvw1v1VpfeKqv5TLnCVrB47Cm81P2u3HJEMr8sYNDKg6bMS0= X-Gm-Gg: AY/fxX7z79s/YVmxEJD5uXmeS/UQd8F46aBTqB2JzgYFRb4UDw7in3/t4Somn2Xz46h Y4Uc4U6usHSUu5Xuy5MvbPEY/HvnVxZv02fuuvHBi7q22EkNS13pkJ4Gj4YCg1eCOeaXXLcMMsU VDR2qkd7egM2OQey1Nbpl3mfA0T8NF4kbwFZE9BYAjlsS4QtPFlIwoPqbJmyevY9sddDtn4eNOb 73ZY68IkHAObW+1uobsv4844S5JvaFko7zJGzsXRQwPzsUDjEUxKT8VeI82xbWUrg3dxZk/8Khf nEfjbVPxZN+ECz7szn9Gv/uaSkflSfFsOrBPp26SV0enaKo/Cmnoh1TT8PVINNu1v2E3IzTUgbb IQsnB7xK7blkarrI72XI3pZN9tAdJz4wW+TqASwpqojixxke0DH037FqQvz6nrCrbkA== X-Received: by 2002:a05:622a:86:b0:4e6:eaff:3a4b with SMTP id d75a77b69052e-4f1d0564b23mr187735221cf.4.1765970058708; Wed, 17 Dec 2025 03:14:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IHeeL3HZVOPvmf0IAL/4i2bYNx5YCSyo2xx9Dhjqf+zLDmXE2sc9O+agiSgDUlgq4sfjkUdtw== X-Received: by 2002:a05:622a:86:b0:4e6:eaff:3a4b with SMTP id d75a77b69052e-4f1d0564b23mr187735081cf.4.1765970058316; Wed, 17 Dec 2025 03:14:18 -0800 (PST) Received: from [192.168.119.72] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b7cfa29beb7sm1932015866b.11.2025.12.17.03.14.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Dec 2025 03:14:17 -0800 (PST) Message-ID: <19bf8b37-4b40-4825-a8be-a94139389c69@oss.qualcomm.com> Date: Wed, 17 Dec 2025 12:14:15 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 4/5] arm64: dts: qcom: monaco-evk: Add camera AVDD regulators To: Nihal Kumar Gupta , bryan.odonoghue@linaro.org, mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org, hverkuil-cisco@xs4all.nl, cros-qcom-dts-watchers@chromium.org, catalin.marinas@arm.com, will@kernel.org Cc: linux-arm-kernel@lists.infradead.org, quic_svankada@quicinc.com, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251216062223.2474216-1-quic_nihalkum@quicinc.com> <20251216062223.2474216-5-quic_nihalkum@quicinc.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20251216062223.2474216-5-quic_nihalkum@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE3MDA4OSBTYWx0ZWRfX9S6hJoSpk/Cn WbKhNwjziOaHfI5R4fjn+v+hxl/7zqjXXJCgymCo2pFUpwRtt7txE/SRelAJjdcRab6rlvAXAY3 VqVQS+iGnGp5DLDuDHxm4eS3DPn0Krp6OFGaSnSZjkYXdZ1CDFgMwfFnNlQGhB7B1C8Y4JU2Isb 8hjK8YptOlbZmrs+ssgNIqx9HaTm5J/BCjZLbx647x0R+qR6f496CxNQstDCWeJJJmojndmacNB c7IvectQ8ofQu06rV5UnxBQWON4waBqOWxv9ZJmetZJzR42omEpvDacYTPJYm+cLTJGXCNCWGI7 Kv4UOXCjFcFibSJ/phOxHtH61f1dmkA0uS8J0Buh/g67CGbVBw00B7xAvmdF9KoSgkt823LAEvS rez77l9qANr8TutJ8ZqkEJ5h+FFAjQ== X-Proofpoint-GUID: frmXWh4_6SW2Q2O5tLSenHKiPaLGtaMo X-Proofpoint-ORIG-GUID: frmXWh4_6SW2Q2O5tLSenHKiPaLGtaMo X-Authority-Analysis: v=2.4 cv=EsHfbCcA c=1 sm=1 tr=0 ts=6942908b cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=xHf7uapYn66AqgDo174A:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-17_01,2025-12-16_05,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 priorityscore=1501 suspectscore=0 impostorscore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 spamscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512170089 On 12/16/25 7:22 AM, Nihal Kumar Gupta wrote: > Define three fixed regulators for camera AVDD rails, each gpio-controlled > with corresponding pinctrl definitions. > > Signed-off-by: Nihal Kumar Gupta > Signed-off-by: Vikram Sharma > --- [...] > &tlmm { > + cam0_avdd_2v8_en_default: cam0-avdd-2v8-en-state { > + pins = "gpio73"; > + function = "gpio"; > + drive-strength = <2>; > + bias-disable; > + }; All other entries in this scope are sorted wrt the pin index.. Please take care of that and add my Reviewed-by: Konrad Dybcio Konrad > + > + cam1_avdd_2v8_en_default: cam1-avdd-2v8-en-state { > + pins = "gpio74"; > + function = "gpio"; > + drive-strength = <2>; > + bias-disable; > + }; > + > + cam2_avdd_2v8_en_default: cam2-avdd-2v8-en-state { > + pins = "gpio75"; > + function = "gpio"; > + drive-strength = <2>; > + bias-disable; > + }; > + > ethernet0_default: ethernet0-default-state { > ethernet0_mdc: ethernet0-mdc-pins { > pins = "gpio5";