From: Li Ming <ming.li@zohomail.com>
To: "danjwilliams" <dan.j.williams@intel.com>
Cc: "dave" <dave@stgolabs.net>,
"jonathan.cameron" <jonathan.cameron@huawei.com>,
"dave.jiang" <dave.jiang@intel.com>,
"alison.schofield" <alison.schofield@intel.com>,
"vishal.l.verma" <vishal.l.verma@intel.com>,
"ira.weiny" <ira.weiny@intel.com>,
"linux-cxl" <linux-cxl@vger.kernel.org>,
"linux-kernel" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] cxl/core: Hold grandparent port lock while dport adding
Date: Tue, 03 Feb 2026 23:21:09 +0800 [thread overview]
Message-ID: <19c2417ddbc.de6bcafb8090.2871009931423392945@zohomail.com> (raw)
In-Reply-To: <69813c31200a6_55fa1005a@dwillia2-mobl4.notmuch>
From: <dan.j.williams@intel.com>
To: "Li Ming"<ming.li@zohomail.com>, <dave@stgolabs.net>, <jonathan.cameron@huawei.com>, <dave.jiang@intel.com>, <alison.schofield@intel.com>, <vishal.l.verma@intel.com>, <ira.weiny@intel.com>, <dan.j.williams@intel.com>
Cc: <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>, "Li Ming"<ming.li@zohomail.com>
Date: Tue, 03 Feb 2026 08:07:13 +0800
Subject: Re: [PATCH 2/2] cxl/core: Hold grandparent port lock while dport adding
> Li Ming wrote:
> > When CXL subsystem adds a cxl port to a hierarchy, there is a small
> > window where the new port becomes visible before it is bound to a
> > driver. This happens because device_add() adds a device to bus device
> > list before bus_probe_device() binds it to a driver.
> > So if two cxl memdevs are trying to add a dport to a same port via
> > devm_cxl_enumerate_ports(), the second cxl memdev may observe the port
> > and attempt to add a dport, but fails because the port has not yet been
> > attached to cxl port driver.
> > the sequence is like:
> >
> > CPU 0 CPU 1
> > devm_cxl_enumerate_ports()
> > # port not found, add it
> > add_port_attach_ep()
> > # hold the parent port lock
> > # to add the new port
> > devm_cxl_create_port()
> > device_add()
> > # Add dev to bus devs list
> > bus_add_device()
> > devm_cxl_enumerate_ports()
> > # found the port
> > find_cxl_port_by_uport()
> > # hold port lock to add a dport
> > device_lock(the port)
> > find_or_add_dport()
> > cxl_port_add_dport()
> > return -ENXIO because port->dev.driver is NULL
> > device_unlock(the port)
> > bus_probe_device()
> > # hold the port lock
> > # for attaching
> > device_lock(the port)
> > attaching the new port
> > device_unlock(the port)
> >
> > To fix this race, require that dport addition holds the parent port lock
> > of the target port. The CXL subsystem already requires holding the
> > parent port lock while attaching a new port. Therefore, successfully
> > acquiring the parent port lock ganrantees that port attaching has
> > completed.
>
> Are you seeing this case fail permanently? The expectation is that the
> one that loses the race iterates up the topology and retries.
>
> So yes, you can lose this race once, but not twice is the expectation.
>
Hi Dan,
My understanding is that would not trigger enumeration retry, because enumerating ports flow retries the enumeration only when find_or_add_dport() returns a -EAGAIN. but the port's driver checking in cxl_port_add_dport() returns a -ENXIO, so it makes devm_cxl_enumerate_ports() failure directly.
Ming
next prev parent reply other threads:[~2026-02-03 15:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-01 9:30 [PATCH 0/2] Fix port enumeration failure and NULL endpoint issue Li Ming
2026-02-01 9:30 ` [PATCH 1/2] cxl/core: Set cxlmd->endpoint to NULL by default Li Ming
2026-02-02 14:41 ` Jonathan Cameron
2026-02-02 15:48 ` Gregory Price
2026-02-03 14:15 ` Li Ming
2026-02-02 21:04 ` Dave Jiang
2026-02-03 15:04 ` Li Ming
2026-02-03 0:01 ` dan.j.williams
2026-02-03 15:15 ` Li Ming
2026-02-03 22:37 ` dan.j.williams
2026-02-01 9:30 ` [PATCH 2/2] cxl/core: Hold grandparent port lock while dport adding Li Ming
2026-02-02 15:39 ` Jonathan Cameron
2026-02-03 14:23 ` Li Ming
2026-02-03 21:14 ` dan.j.williams
2026-02-02 16:31 ` Gregory Price
2026-02-03 14:33 ` Li Ming
2026-02-03 0:07 ` dan.j.williams
2026-02-03 15:21 ` Li Ming [this message]
2026-02-03 22:25 ` dan.j.williams
2026-02-04 13:51 ` Li Ming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19c2417ddbc.de6bcafb8090.2871009931423392945@zohomail.com \
--to=ming.li@zohomail.com \
--cc=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=ira.weiny@intel.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®