mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@xilinx.com>
To: Mark Brown <broonie@kernel.org>,
	Maruthi Srinivas Bayyavarapu 
	<maruthi.srinivas.bayyavarapu@xilinx.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Vishal Sagar <vsagar@xilinx.com>,
	Michal Simek <michal.simek@xilinx.com>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<alsa-devel@alsa-project.org>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/3] ASoC: xlnx: Add i2s driver
Date: Fri, 14 Dec 2018 07:50:43 +0100	[thread overview]
Message-ID: <19c273d9-c52d-48be-a1e1-88e2b1f14cce@xilinx.com> (raw)
In-Reply-To: <20181213153127.GN10669@sirena.org.uk>

Hi Mark,

On 13. 12. 18 16:31, Mark Brown wrote:
> On Sat, Dec 08, 2018 at 12:02:37AM +0530, Maruthi Srinivas Bayyavarapu wrote:
> 
>> @@ -0,0 +1,185 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> +/*
>> + * Xilinx ASoC I2S audio support
>> + *
> 
> This looks otherwise good so I've applied it but please send a followup
> patch converting the entire comment block to C++ style so this looks
> more consistent.

Is it the rule for your subsystems? Or did it come from any generic
agreement how this should be handled in .c files?

Thanks,
Michal



  reply	other threads:[~2018-12-14  6:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-07 18:32 [PATCH 0/3] Add Xilinx I2S driver Maruthi Srinivas Bayyavarapu
2018-12-07 18:32 ` [PATCH 1/3] dt-bindings: ASoC: xlnx,i2s: Document i2s bindings Maruthi Srinivas Bayyavarapu
2018-12-13 18:11   ` Applied "dt-bindings: ASoC: xlnx, i2s: Document i2s bindings" to the asoc tree Mark Brown
2018-12-07 18:32 ` [PATCH 2/3] ASoC: xlnx: Add i2s driver Maruthi Srinivas Bayyavarapu
2018-12-13 15:31   ` Mark Brown
2018-12-14  6:50     ` Michal Simek [this message]
2018-12-17 12:24       ` Mark Brown
2018-12-17 12:28         ` Michal Simek
2018-12-13 18:11   ` Applied "ASoC: xlnx: Add i2s driver" to the asoc tree Mark Brown
2018-12-07 18:32 ` [PATCH 3/3] ASoC: xlnx: enable i2s driver build Maruthi Srinivas Bayyavarapu
2018-12-13 18:11   ` Applied "ASoC: xlnx: enable i2s driver build" to the asoc tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19c273d9-c52d-48be-a1e1-88e2b1f14cce@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=maruthi.srinivas.bayyavarapu@xilinx.com \
    --cc=perex@perex.cz \
    --cc=robh+dt@kernel.org \
    --cc=tiwai@suse.com \
    --cc=vsagar@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®