From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF7C4C4332F for ; Mon, 7 Nov 2022 15:39:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232909AbiKGPjB (ORCPT ); Mon, 7 Nov 2022 10:39:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41468 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231936AbiKGPi7 (ORCPT ); Mon, 7 Nov 2022 10:38:59 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA3181EAFE for ; Mon, 7 Nov 2022 07:37:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667835478; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dNfP2j3bbtVZitCEodZjiNfOPVCG/GmURhlA5yLx2ao=; b=P0O12kj2BjN5X3Y7PEGf05g3shLzdjPJ1yXrPe0Q4Ii3La2XGMWGs4X4ArEd/rqnXaExxz Lr68+lvEMD1DtoQIYG45yMrVOOOwkgvILyIzzlxvLHY2Juv5sR//BpanKnZJvDao723tHA uGQzVOQOLEWmcb2SD08rhXLJrEvwujA= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-439-joB2cJcAO5eUknbipuE_cA-1; Mon, 07 Nov 2022 10:37:57 -0500 X-MC-Unique: joB2cJcAO5eUknbipuE_cA-1 Received: by mail-wm1-f69.google.com with SMTP id h8-20020a1c2108000000b003cf550bfc8dso8610740wmh.2 for ; Mon, 07 Nov 2022 07:37:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dNfP2j3bbtVZitCEodZjiNfOPVCG/GmURhlA5yLx2ao=; b=E44NAkmYuvD0hKUmDyDS92uSbkSzhRmJYIJ3VpfGKlRhgNFUyYagXGB6GWcUaLud+U gU7cYs/KLd+U/oKF4cAoNG6zlNTw45nI95wsXD+qFEtAfGQYc45nNKQI/PC6OKcndmRd neRZIRL2JBz3STu4o9ZQ5M26835IA1FH8Itg/kh7pdcNdP1O8+STvFku7Oq3Wi4DjG/L mCHq9iDjxDssbt6whzf5uhOJ3rkwYCFYGSYJbILeiXnfh/8NBJu60f2SFq7Jrr1CNVkC fY316u8l9UvL9OnevNs59OUZcJtHOtdNO9KBGLg3aZGVim8+v2Vk5R3OyzUL9j5dfbqb r6yw== X-Gm-Message-State: ACrzQf31srXOl4zwsXEJJpqHc29iSKphYuNTBUMvutvEg495Ax3GauV5 A+mo+9a/tvVcVf5Uvsh17mgBRxsUvflvTRuYdtl5duQ9IAdvZue/eCwNujrIvsKupbbBBl3lXT6 AuHcm3+vl1yUylGqD5YIU8wyb X-Received: by 2002:adf:e890:0:b0:22c:f296:1120 with SMTP id d16-20020adfe890000000b0022cf2961120mr572067wrm.369.1667835475781; Mon, 07 Nov 2022 07:37:55 -0800 (PST) X-Google-Smtp-Source: AMsMyM7Eq0lPe1aa4L/JM3FdjO2s3r41N1HB7mWOJ7dQXLUKvWX5gLCAh8J75OzN26tyCHQlyFviSg== X-Received: by 2002:adf:e890:0:b0:22c:f296:1120 with SMTP id d16-20020adfe890000000b0022cf2961120mr572064wrm.369.1667835475560; Mon, 07 Nov 2022 07:37:55 -0800 (PST) Received: from ?IPV6:2001:b07:6468:f312:9af8:e5f5:7516:fa89? ([2001:b07:6468:f312:9af8:e5f5:7516:fa89]) by smtp.googlemail.com with ESMTPSA id k28-20020a5d525c000000b0022e653f5abbsm7507544wrc.69.2022.11.07.07.37.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Nov 2022 07:37:54 -0800 (PST) Message-ID: <19c32786-6f5b-d438-269b-d29c104817ac@redhat.com> Date: Mon, 7 Nov 2022 16:37:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 4/8] KVM: SVM: move guest vmsave/vmload to assembly Content-Language: en-US To: Andrew Cooper , "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" Cc: "nathan@kernel.org" , "thomas.lendacky@amd.com" , "peterz@infradead.org" , "jmattson@google.com" , "seanjc@google.com" , "stable@vger.kernel.org" References: <20221107145436.276079-1-pbonzini@redhat.com> <20221107145436.276079-5-pbonzini@redhat.com> <6c8539fa-38b5-d307-675a-2e272f7a83d3@citrix.com> From: Paolo Bonzini In-Reply-To: <6c8539fa-38b5-d307-675a-2e272f7a83d3@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/7/22 16:32, Andrew Cooper wrote: >> - vmload(svm->vmcb01.pa); >> __svm_vcpu_run(vmcb_pa, svm); >> - vmsave(svm->vmcb01.pa); >> - >> vmload(__sme_page_pa(sd->save_area)); > > %gs is still the guests until this vmload has completed.  It needs to > move down into asm too. Sure, that's patch 6 in the series. See also cover letter: "this means moving guest vmload/vmsave and host vmload to assembly". Paolo