From: Jens Axboe <axboe@kernel.dk>
To: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>,
Paolo Valente <paolo.valente@linaro.org>
Cc: linux-block@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>,
Arianna Avanzini <avanzini.arianna@gmail.com>
Subject: Re: [PATCH] block, bfq: return nbytes and not zero from struct cftype .write() method
Date: Thu, 16 Aug 2018 13:11:49 -0600 [thread overview]
Message-ID: <19c68f93-017d-cda1-632f-039ca3ca0158@kernel.dk> (raw)
In-Reply-To: <f574e019-00f2-96c3-fc32-541c6584ca96@maciej.szmigiero.name>
On 8/15/18 3:56 PM, Maciej S. Szmigiero wrote:
> The value that struct cftype .write() method returns is then directly
> returned to userspace as the value returned by write() syscall, so it
> should be the number of bytes actually written (or consumed) and not zero.
>
> Returning zero from write() syscall makes programs like /bin/echo or bash
> spin.
Applied, thanks.
Just a heads-up that gmail thinks your email is spam.
--
Jens Axboe
next prev parent reply other threads:[~2018-08-16 19:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-15 21:56 Maciej S. Szmigiero
2018-08-16 19:11 ` Jens Axboe [this message]
2018-08-17 17:27 ` Maciej S. Szmigiero
2018-08-17 17:38 ` Jens Axboe
2018-08-28 14:38 ` (Was: [PATCH] block, bfq: return nbytes and not zero from struct cftype .write() method) Maciej S. Szmigiero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19c68f93-017d-cda1-632f-039ca3ca0158@kernel.dk \
--to=axboe@kernel.dk \
--cc=avanzini.arianna@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@maciej.szmigiero.name \
--cc=paolo.valente@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome