From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751603AbdJ1TSy (ORCPT <rfc822;w@1wt.eu>);
        Sat, 28 Oct 2017 15:18:54 -0400
Received: from mout.web.de ([212.227.17.11]:50002 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751387AbdJ1TSv (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 28 Oct 2017 15:18:51 -0400
Subject: Re: can: Use common error handling code in vxcan_newlink()
To: Oliver Hartkopp <socketcan@hartkopp.net>, linux-can@vger.kernel.org,
        netdev@vger.kernel.org
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
        Wolfgang Grandegger <wg@grandegger.com>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
References: <2e600d9a-faec-dd39-08f0-5a7fb260d7ca@users.sourceforge.net>
 <2ab5d794-7a5c-9036-835c-67cfcc541795@hartkopp.net>
 <d3bdd3c0-5a03-dd59-07ca-94b126c67f75@users.sourceforge.net>
 <264b3c2b-8354-5769-639c-ac8d2fcbe630@hartkopp.net>
 <5a76bb36-4ae0-eca2-ae34-69c2bfddb634@users.sourceforge.net>
 <4d612668-5423-4ce3-a4f5-ee394d7ddd21@hartkopp.net>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <19ca5f23-fbb0-aaae-bff5-d634af66c264@users.sourceforge.net>
Date: Sat, 28 Oct 2017 21:18:40 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <4d612668-5423-4ce3-a4f5-ee394d7ddd21@hartkopp.net>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 8bit
X-Provags-ID: V03:K0:U1Qdx4gs4/n6PzkQ19n5/+fExXRujCmpd0nh+Ml7nC/fYpoEHXX
 7hjClP6UJdfETwZaFlEh1EMBavn9GEx52tB0hiu5xwkF7YOmInjciC05e+3uNK3Y8aB1oRj
 IQfZnNTmPhav6wzoXX5x1IuGTD+knfVdurhvjJt/fb5BqA14K2ZL03DLYJuhgqAr78GjUu6
 Nv4xv7wNRqFb1a6NZG/AQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:7pB6TYDaYGc=:xm6/5eoO2HYBhN/wBMvZWO
 nnT0cTTbQt1r1IJlMlm/ldvEFFlk/EKmuRFUGObwosu4XlIJl4Q0OtG8akVIRtOXDH8Rc1TSg
 yqp3ztz3n5qiQXJZ+H9VWhxzy7N8ypYJzNrW+omw4F0UAlykDEvG1LAzKZhgADIhVUqOf0FUL
 99V3xRwKuqnu2piAkLThN8i/S4LVQpbmqJbd9K/DBNmQfIhWL4JCmfVwMT9dhBLkIjRuBIE1l
 kbtW8QVpj4eHMEJ56NsEhMGCbIloyr07+9rYZjdyWPTLonyIHgCYkJArMePN5b9XwRwWlFEpv
 Vjms/GFQEXy7lpeLKlhfKvCBlzmJgQp8QJ/C3I1j872YwpkvFfcHOdD0bCh/aIHHPDVvd+HmU
 kUhIu4DXU+cmaLsfMQLHmubP9bVjihRZc8/oiyF7QhhYD1ePlpRSDF5pypsEkwP3nM+oCLgMs
 Z68exnluI2jw7gSCl2YXzkmaTvonqL8hTE1BMgNAT7TnTwvWqxwdWeqjQp8BKvd5Zs2aKAI5X
 QktWmmp6Vc9cE5wpVtMnghSsayWndYNKGin/4frWKDYrNOnFi+pRkDOVnq8smvt0Cmep1QKo1
 hTVBFupD6STikX8FSGuGHXJsxGPO7k1S9wqvelEmD5lzscSs82OUQshJqmxLnRPLhC743yqjP
 BuE5eMios+Inrz93ljYBEnoGtndP6/vKWR1SfvZ8BzlBvssYlzXH495/8UqDsl4QbnNcIa8Fd
 h9uQR6/lkELOkU4CUcHTfTkJ7jYc8MAmfudXEqFKChlJPMrU20ZZbad/z8bzq3/nfPp7VgGUt
 drBiLf9YIi+epHDpMovXlpfxM4ISj/sO/hcFov6OAXBJu93aZo=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> If you want to change the semantic of the result check

I am curious if another source code reduction (by the deletion of “ < 0”)
will become acceptable at similar places.


> - this has to done consistently at all rtnl_configure_link() caller sites.

Are there any more functions to consider?


> And not only in vxcan.c

Are you interested in related adjustments for a bigger code base?

Regards,
Markus