From: Zheng Zengkai <zhengzengkai@huawei.com>
To: <dhowells@redhat.com>, <linux-afs@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Cc: <huawei.libin@huawei.com>
Subject: Re: [PATCH] afs: fix no return statement in function returning non-void
Date: Wed, 31 Mar 2021 10:32:38 +0800 [thread overview]
Message-ID: <19cc788d-2c14-99ef-1162-ed919364dcfd@huawei.com> (raw)
In-Reply-To: <20210327121624.194639-1-zhengzengkai@huawei.com>
Hi David and Reviewers,
> Add missing return to fix following compilation issue:
>
> fs/afs/dir.c: In function ‘afs_dir_set_page_dirty’:
> fs/afs/dir.c:51:1: error: no return statement in function
> returning non-void [-Werror=return-type]
>
> Fixes: f3ddee8dc4e2 ("afs: Fix directory handling")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zheng Zengkai <zhengzengkai@huawei.com>
> ---
> fs/afs/dir.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/afs/dir.c b/fs/afs/dir.c
> index 17548c1faf02..1795a05b7cb7 100644
> --- a/fs/afs/dir.c
> +++ b/fs/afs/dir.c
> @@ -48,6 +48,7 @@ static void afs_dir_invalidatepage(struct page *page, unsigned int offset,
> static int afs_dir_set_page_dirty(struct page *page)
> {
> BUG(); /* This should never happen. */
> + return 0;
> }
>
> const struct file_operations afs_dir_file_operations = {
Is there anyone who can take a look? ;-)
Thanks!
next prev parent reply other threads:[~2021-03-31 2:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-27 12:16 Zheng Zengkai
2021-03-31 2:32 ` Zheng Zengkai [this message]
2021-04-08 14:06 ` David Howells
2021-04-19 22:31 ` Randy Dunlap
2021-05-27 19:48 ` Randy Dunlap
2021-06-15 11:55 David Howells
2021-06-15 12:03 ` David Howells
2021-06-15 14:49 ` Linus Torvalds
2021-06-15 23:58 ` Randy Dunlap
2021-06-16 0:32 ` Linus Torvalds
2021-06-16 1:38 ` Randy Dunlap
2021-06-16 2:19 ` Randy Dunlap
2021-06-16 3:15 ` Zheng Zengkai
2021-06-16 12:56 ` Tom Rix
2021-06-16 14:34 ` Linus Torvalds
2021-06-16 16:22 ` Tom Rix
2021-06-16 16:29 ` Linus Torvalds
2021-06-18 15:23 ` Arnd Bergmann
2021-06-16 13:41 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19cc788d-2c14-99ef-1162-ed919364dcfd@huawei.com \
--to=zhengzengkai@huawei.com \
--cc=dhowells@redhat.com \
--cc=huawei.libin@huawei.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®