From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B671EE49A0 for ; Wed, 23 Aug 2023 14:32:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236462AbjHWOcv (ORCPT ); Wed, 23 Aug 2023 10:32:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236457AbjHWOcs (ORCPT ); Wed, 23 Aug 2023 10:32:48 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F836E69 for ; Wed, 23 Aug 2023 07:32:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692801121; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GzdoCs2Mn27/sh3oWYgFmEgOxiDPY2yxYeRmbUpWAOY=; b=Ul+fLz6cwzESlZIgU9/+1gAJ+F+pwvRic/ILmLJLMYcR4QKw6NL+KMlN3esdcbrCqBTRh9 E1PednEjmHM0bNLJ22ybM90cR8hpygHHGTYIvYEXm2fLCwbrhP9dnsLXXHb2LUPrnXSNG+ uhr+qGGr7LmL8TzC8Oa5ursfDVGK2S4= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-637-By5pYbz3NJyE96tNOsOK2Q-1; Wed, 23 Aug 2023 10:32:00 -0400 X-MC-Unique: By5pYbz3NJyE96tNOsOK2Q-1 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-99bcf6ae8e1so420880666b.0 for ; Wed, 23 Aug 2023 07:31:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692801118; x=1693405918; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GzdoCs2Mn27/sh3oWYgFmEgOxiDPY2yxYeRmbUpWAOY=; b=FWh6sFWO0MxEHxLBYAqJZ0m4axvLFzdUtTErBiCj0uQN/8KotfEx9bm5hMXqr4mMpD mKbgckhqp/GA3zzHySgzqPbBq3LHV7LeZU3S9HFIIIFEvtWXob7mFINvFLDW6MTVcmlJ HgzKD49UGMSN45AUoCcrUDJBXAiUF7LU2oLQDCFYshejvSry59tqbXrip5k+mHL6K+Rp 3+oazqe4lU23012Li6kg82sXFaxTK0A3jYdpG1+CKpQOTiqDN4m7xwvOYFqJqg2rZw3y 0+7k3G5llb0o4TxmCuFF2O8/ML0hHK2jtC4f44r22pcsyEEOdt3vROrSf0yT2J1jdtH+ nvLg== X-Gm-Message-State: AOJu0Yzk8I/LuZinjyXtICDKCMfT1IIUcCrfIaU3dRu66PigQIJNcGzK cP+x4O++HNaJ3Agxf0evusEKdnbFA208nDWa5zYq/bt88A/bQ8KPlrhM78zc6Df6FhccJjJzpby hrrUo0PlF77Qz7UtolUTmuS6yeW1ECu+Z X-Received: by 2002:a17:907:b15:b0:99b:ddac:d9d9 with SMTP id h21-20020a1709070b1500b0099bddacd9d9mr9977992ejl.53.1692801118466; Wed, 23 Aug 2023 07:31:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHZe+M+2IV0Biir6gicbEcM3wtv1kibH9AhosiD4ierXNGvPNyLBv2sq9vftQipzU9U4NlSog== X-Received: by 2002:a17:907:b15:b0:99b:ddac:d9d9 with SMTP id h21-20020a1709070b1500b0099bddacd9d9mr9977977ejl.53.1692801118169; Wed, 23 Aug 2023 07:31:58 -0700 (PDT) Received: from ?IPV6:2a02:810d:4b3f:de9c:642:1aff:fe31:a15c? ([2a02:810d:4b3f:de9c:642:1aff:fe31:a15c]) by smtp.gmail.com with ESMTPSA id mj14-20020a170906af8e00b0099c53c4407dsm9835727ejb.78.2023.08.23.07.31.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Aug 2023 07:31:57 -0700 (PDT) Message-ID: <19d68804-87f4-5f89-4a63-b85a9b204cd0@redhat.com> Date: Wed, 23 Aug 2023 14:36:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH drm-misc-next] drm/nouveau: uapi: don't pass NO_PREFETCH flag implicitly Content-Language: en-US To: Faith Ekstrand Cc: airlied@gmail.com, daniel@ffwll.ch, bskeggs@redhat.com, kherbst@redhat.com, lyude@redhat.com, faith.ekstrand@collabora.com, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20230822234139.11185-1-dakr@redhat.com> From: Danilo Krummrich Organization: RedHat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/23/23 04:53, Faith Ekstrand wrote: > On Tue, Aug 22, 2023 at 6:41 PM Danilo Krummrich > wrote: > > Currently, NO_PREFETCH is passed implicitly through > drm_nouveau_gem_pushbuf_push::length and drm_nouveau_exec_push::va_len. > > Since this is a direct representation of how the HW is programmed it > isn't really future proof for a uAPI. Hence, fix this up for the new > uAPI and split up the va_len field of struct drm_nouveau_exec_push, > such that we keep 32bit for va_len and 32bit for flags. > > For drm_nouveau_gem_pushbuf_push::length at least provide > NOUVEAU_GEM_PUSHBUF_NO_PREFETCH to indicate the bit shift. > > While at it, fix up nv50_dma_push() as well, such that the caller > doesn't need to encode the NO_PREFETCH flag into the length parameter. > > Signed-off-by: Danilo Krummrich > > --- >  drivers/gpu/drm/nouveau/nouveau_dma.c  |  7 +++++-- >  drivers/gpu/drm/nouveau/nouveau_dma.h  |  8 ++++++-- >  drivers/gpu/drm/nouveau/nouveau_exec.c | 15 ++++++++++++--- >  drivers/gpu/drm/nouveau/nouveau_gem.c  |  6 ++++-- >  include/uapi/drm/nouveau_drm.h         |  8 +++++++- >  5 files changed, 34 insertions(+), 10 deletions(-) > > diff --git a/drivers/gpu/drm/nouveau/nouveau_dma.c b/drivers/gpu/drm/nouveau/nouveau_dma.c > index b90cac6d5772..059925e5db6a 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_dma.c > +++ b/drivers/gpu/drm/nouveau/nouveau_dma.c > @@ -69,16 +69,19 @@ READ_GET(struct nouveau_channel *chan, uint64_t *prev_get, int *timeout) >  } > >  void > -nv50_dma_push(struct nouveau_channel *chan, u64 offset, int length) > +nv50_dma_push(struct nouveau_channel *chan, u64 offset, u32 length, > +             bool prefetch) >  { >         struct nvif_user *user = &chan->drm->client.device.user; >         struct nouveau_bo *pb = chan->push.buffer; >         int ip = (chan->dma.ib_put * 2) + chan->dma.ib_base; > >         BUG_ON(chan->dma.ib_free < 1); > +       WARN_ON(length > NV50_DMA_PUSH_MAX_LENGTH); > >         nouveau_bo_wr32(pb, ip++, lower_32_bits(offset)); > -       nouveau_bo_wr32(pb, ip++, upper_32_bits(offset) | length << 8); > +       nouveau_bo_wr32(pb, ip++, upper_32_bits(offset) | length << 8 | > +                       (prefetch ? 0 : (1 << 31))); > > > It feels a bit weird to be inverting this bit twice. IDK that it matters, though. I usually avoid negated argument names, in this case it kinda makes sense though. > > >         chan->dma.ib_put = (chan->dma.ib_put + 1) & chan->dma.ib_max; > > diff --git a/drivers/gpu/drm/nouveau/nouveau_dma.h b/drivers/gpu/drm/nouveau/nouveau_dma.h > index 035a709c7be1..fb471c357336 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_dma.h > +++ b/drivers/gpu/drm/nouveau/nouveau_dma.h > @@ -31,7 +31,8 @@ >  #include "nouveau_chan.h" > >  int nouveau_dma_wait(struct nouveau_channel *, int slots, int size); > -void nv50_dma_push(struct nouveau_channel *, u64 addr, int length); > +void nv50_dma_push(struct nouveau_channel *, u64 addr, u32 length, > +                  bool prefetch); > >  /* >   * There's a hw race condition where you can't jump to your PUT offset, > @@ -45,6 +46,9 @@ void nv50_dma_push(struct nouveau_channel *, u64 addr, int length); >   */ >  #define NOUVEAU_DMA_SKIPS (128 / 4) > > +/* Maximum push buffer size. */ > +#define NV50_DMA_PUSH_MAX_LENGTH 0x7fffff > + >  /* Object handles - for stuff that's doesn't use handle == oclass. */ >  enum { >         NvDmaFB         = 0x80000002, > @@ -89,7 +93,7 @@ FIRE_RING(struct nouveau_channel *chan) > >         if (chan->dma.ib_max) { >                 nv50_dma_push(chan, chan->push.addr + (chan->dma.put << 2), > -                             (chan->dma.cur - chan->dma.put) << 2); > +                             (chan->dma.cur - chan->dma.put) << 2, true); >         } else { >                 WRITE_PUT(chan->dma.cur); >         } > diff --git a/drivers/gpu/drm/nouveau/nouveau_exec.c b/drivers/gpu/drm/nouveau/nouveau_exec.c > index 0f927adda4ed..a123b07b2adf 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_exec.c > +++ b/drivers/gpu/drm/nouveau/nouveau_exec.c > @@ -164,8 +164,10 @@ nouveau_exec_job_run(struct nouveau_job *job) >         } > >         for (i = 0; i < exec_job->push.count; i++) { > -               nv50_dma_push(chan, exec_job->push.s[i].va, > -                             exec_job->push.s[i].va_len); > +               struct drm_nouveau_exec_push *p = &exec_job->push.s[i]; > +               bool prefetch = !(p->flags & DRM_NOUVEAU_EXEC_PUSH_NO_PREFETCH); > + > +               nv50_dma_push(chan, p->va, p->va_len, prefetch); >         } > >         ret = nouveau_fence_emit(fence, chan); > @@ -223,7 +225,14 @@ nouveau_exec_job_init(struct nouveau_exec_job **pjob, >  { >         struct nouveau_exec_job *job; >         struct nouveau_job_args args = {}; > -       int ret; > +       int i, ret; > + > +       for (i = 0; i < __args->push.count; i++) { > +               struct drm_nouveau_exec_push *p = &__args->push.s[i]; > + > +               if (p->va_len > NV50_DMA_PUSH_MAX_LENGTH) > +                       return -EINVAL; > > > This can probably be wrapped in unlikely().  Also, it'd be nice if we printed an error message like we do if you try to push too many things. Yep, will do. > > Looks good. Thanks! > > Reviewed-by: Faith Ekstrand > > > +       } > >         job = *pjob = kzalloc(sizeof(*job), GFP_KERNEL); >         if (!job) > diff --git a/drivers/gpu/drm/nouveau/nouveau_gem.c b/drivers/gpu/drm/nouveau/nouveau_gem.c > index f39360870c70..2f3dc4d71657 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_gem.c > +++ b/drivers/gpu/drm/nouveau/nouveau_gem.c > @@ -856,9 +856,11 @@ nouveau_gem_ioctl_pushbuf(struct drm_device *dev, void *data, >                 for (i = 0; i < req->nr_push; i++) { >                         struct nouveau_vma *vma = (void *)(unsigned long) >                                 bo[push[i].bo_index].user_priv; > +                       u64 addr = vma->addr + push[i].offset; > +                       u32 length = push[i].length & ~NOUVEAU_GEM_PUSHBUF_NO_PREFETCH; > +                       bool prefetch = !(push[i].length & NOUVEAU_GEM_PUSHBUF_NO_PREFETCH); > > -                       nv50_dma_push(chan, vma->addr + push[i].offset, > -                                     push[i].length); > +                       nv50_dma_push(chan, addr, length, prefetch); >                 } >         } else >         if (drm->client.device.info .chipset >= 0x25) { > diff --git a/include/uapi/drm/nouveau_drm.h b/include/uapi/drm/nouveau_drm.h > index b1ad9d5ffce8..8f16724b5d05 100644 > --- a/include/uapi/drm/nouveau_drm.h > +++ b/include/uapi/drm/nouveau_drm.h > @@ -138,6 +138,7 @@ struct drm_nouveau_gem_pushbuf_push { >         __u32 pad; >         __u64 offset; >         __u64 length; > +#define NOUVEAU_GEM_PUSHBUF_NO_PREFETCH (1 << 23) >  }; > >  struct drm_nouveau_gem_pushbuf { > @@ -338,7 +339,12 @@ struct drm_nouveau_exec_push { >         /** >          * @va_len: the length of the push buffer mapping >          */ > -       __u64 va_len; > +       __u32 va_len; > +       /** > +        * flags: the flags for this push buffer mapping > +        */ > +       __u32 flags; > +#define DRM_NOUVEAU_EXEC_PUSH_NO_PREFETCH 0x1 >  }; > >  /** > > base-commit: ad1367f831f8743746a1f49705c28e36a7c95525 > -- > 2.41.0 >