From: Andrew Lunn <andrew@lunn.ch>
To: Bastian Germann <bage@debian.org>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Russell King <linux@armlinux.org.uk>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Vladimir Oltean <olteanv@gmail.com>
Subject: Re: [PATCH net-next] net: mdio: handle broken-turn-around for non-PHY MDIO devices
Date: Fri, 20 Nov 2026 01:33:21 +0100 [thread overview]
Message-ID: <19d8bfb6-074e-4344-acf8-67872f7b3e48@lunn.ch> (raw)
In-Reply-To: <20261119231319.1256419-1-bage@debian.org>
On Fri, Nov 20, 2026 at 12:13:19AM +0100, Bastian Germann wrote:
> The "broken-turn-around" property is documented in mdio.yaml for any
> MDIO device, but the MDIO core currently parses it only for PHY devices
> in fwnode_mdiobus_phy_device_register(). Non-PHY devices, such as DSA
> switches, are registered through of_mdiobus_register_device(), where the
> property is ignored, so MDIO bus drivers that rely on phy_ignore_ta_mask
> still treat the turn-around/read failure as an error.
>
> Parse the property when registering a non-PHY MDIO device and set the
> corresponding bit in phy_ignore_ta_mask before registering the device.
What switch is causing you problems?
I do wounder if the call in fwnode_mdiobus_phy_device_register()
should be hoisted up into of_mdiobus_register_device, were it would be
common for both PHYs and MDIO devices.
Andrew
prev parent reply other threads:[~2026-11-20 0:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 23:13 Bastian Germann
2026-11-20 0:33 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19d8bfb6-074e-4344-acf8-67872f7b3e48@lunn.ch \
--to=andrew@lunn.ch \
--cc=bage@debian.org \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®