From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755964AbdIRPC1 (ORCPT ); Mon, 18 Sep 2017 11:02:27 -0400 Received: from mail-wm0-f51.google.com ([74.125.82.51]:44311 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755028AbdIRPCZ (ORCPT ); Mon, 18 Sep 2017 11:02:25 -0400 X-Google-Smtp-Source: AOwi7QDWjiY43uX+KWp1exgEXvyn5hKshkJhBq37BDHnn3Dzf7nAWYh+lbxsiiDfygW7lfh8fqNA8w== Subject: Re: [PATCH 3/4] nvmem: remove inline in drivers/nvmem/core.c To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, Masahiro Yamada References: <20170911090014.16806-1-srinivas.kandagatla@linaro.org> <20170911090014.16806-4-srinivas.kandagatla@linaro.org> <20170918140934.GA2512@kroah.com> From: Srinivas Kandagatla Message-ID: <19dc6087-67ae-5776-d4e4-3657f812e9aa@linaro.org> Date: Mon, 18 Sep 2017 16:02:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170918140934.GA2512@kroah.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/09/17 15:09, Greg Kroah-Hartman wrote: > On Mon, Sep 11, 2017 at 11:00:13AM +0200, srinivas.kandagatla@linaro.org wrote: >> From: Masahiro Yamada >> >> These two functions are defined in .c file, but called just once >> (at least for now). So, the compiler will fold them into their >> callers even without the "inline" markers. >> >> However, this kind of optimization should not be done by hand. >> It is compiler's judge after all. >> >> Signed-off-by: Masahiro Yamada >> Signed-off-by: Srinivas Kandagatla >> --- >> drivers/nvmem/core.c | 7 +++---- >> 1 file changed, 3 insertions(+), 4 deletions(-) > > This isn't really a bugfix, so should wait for 4.15-rc1. No rush for this patch, we can take it in 4.15-rc1.. thanks, srini > > thanks, > > greg k-h >