From: Alexander Sverdlin <alexander.sverdlin@nokia.com>
To: Florian Fainelli <f.fainelli@gmail.com>,
linux-arm-kernel@lists.infradead.org
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
Russell King <linux@armlinux.org.uk>,
Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH v6 0/2] ARM: Implement MODULE_PLT support in FTRACE
Date: Wed, 27 Jan 2021 11:43:56 +0100 [thread overview]
Message-ID: <19e02972-c2e2-0e5f-b9c7-9f750110db77@nokia.com> (raw)
In-Reply-To: <48289cbf-9108-2807-7143-c3ae625bd940@gmail.com>
Hello Florian,
On 27/01/2021 05:48, Florian Fainelli wrote:
>> FTRACE's function tracer currently doesn't always work on ARM with
>> MODULE_PLT option enabled. If the module is loaded too far, FTRACE's
>> code modifier cannot cope with introduced veneers and turns the
>> function tracer off globally.
>>
>> ARM64 already has a solution for the problem, refer to the following
>> patches:
>>
>> arm64: ftrace: emit ftrace-mod.o contents through code
>> arm64: module-plts: factor out PLT generation code for ftrace
>> arm64: ftrace: fix !CONFIG_ARM64_MODULE_PLTS kernels
>> arm64: ftrace: fix building without CONFIG_MODULES
>> arm64: ftrace: add support for far branches to dynamic ftrace
>> arm64: ftrace: don't validate branch via PLT in ftrace_make_nop()
>>
>> But the presented ARM variant has just a half of the footprint in terms of
>> the changed LoCs. It also retains the code validation-before-modification
>> instead of switching it off.
> We have been using those patches and I was wondering what happened after
> this version since they did not show up upstream nor in Russell's patch
> tracker? Would you be willing to resubmit them?
it's a pity, but nobody ever showed any interest to take them to fix real problem
in FTRACE. A grain of salt would be to remind, that no-one also replied that
the series helped him or a Tested-by: tag. This would probably wake more
interest from maintainers side.
Of course I can re-send them because I personally re-base them regularly.
--
Best regards,
Alexander Sverdlin.
prev parent reply other threads:[~2021-01-27 10:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 14:09 Alexander X Sverdlin
2020-02-17 14:09 ` [PATCH v6 1/2] ARM: PLT: Move struct plt_entries definition to header Alexander X Sverdlin
2020-02-17 14:09 ` [PATCH v6 2/2] ARM: ftrace: Add MODULE_PLTS support Alexander X Sverdlin
2021-01-27 4:48 ` [PATCH v6 0/2] ARM: Implement MODULE_PLT support in FTRACE Florian Fainelli
2021-01-27 10:43 ` Alexander Sverdlin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19e02972-c2e2-0e5f-b9c7-9f750110db77@nokia.com \
--to=alexander.sverdlin@nokia.com \
--cc=ard.biesheuvel@linaro.org \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®