mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Moshe Shemesh <moshe@nvidia.com>
To: Breno Leitao <leitao@debian.org>
Cc: <saeedm@nvidia.com>, <itayavr@nvidia.com>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<dcostantino@meta.com>, <kuba@kernel.org>
Subject: Re: mlx5: CX7: fw_tracer: crash at mlx5_tracer_print_trace()
Date: Thu, 16 Oct 2025 18:39:29 +0300	[thread overview]
Message-ID: <19e13479-861a-479c-8f5e-b9db229bfe38@nvidia.com> (raw)
In-Reply-To: <uhlgxrlphs6cufrbm7mkp3nmtkrvhtoxbgd6rt7uojogfrbdoc@4mgzpab3dv3a>



On 10/15/2025 3:26 PM, Breno Leitao wrote:
> 
> Hello Moshe,
> 
> On Wed, Oct 15, 2025 at 12:13:29PM +0300, Moshe Shemesh wrote:
>> On 10/9/2025 3:42 PM, Breno Leitao wrote:
>>>
>>> My understanding that we are printf %s with params[0], which is 557514328 (aka
>>> 0x213afe58). So, sprintf is trying to access the content of 0x213afe58, which
>>> is invalid, and crash.
>>>
>>> Is this a known issue?
>>
>> Not a known issue, not expected, thanks for reporting.
>> We will send patch to protect from such crash.
> 
> Thanks. how do you plan to protect it? I understand that the string is
> coming from the firmware and the kernel is just using it in snprintf. Is
> it right?

Yes, but FW should not use %s. Driver can check it.
> 
>> Please send FW version it was detected on.
> 
> `ethtool -i` outputs:
>          firmware-version: 28.44.2506 (FB_0000000030)

Thanks.
> 
> Thanks for your answer,
> --breno


  reply	other threads:[~2025-10-16 15:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-09 12:42 Breno Leitao
2025-10-15  9:13 ` Moshe Shemesh
2025-10-15 12:26   ` Breno Leitao
2025-10-16 15:39     ` Moshe Shemesh [this message]
2025-11-03 10:45   ` Usama Arif
2025-11-04 12:09     ` Moshe Shemesh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19e13479-861a-479c-8f5e-b9db229bfe38@nvidia.com \
    --to=moshe@nvidia.com \
    --cc=dcostantino@meta.com \
    --cc=itayavr@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=leitao@debian.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=saeedm@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®