From: Waiman Long <llong@redhat.com>
To: Carlos Llamas <cmllamas@google.com>,
Boqun Feng <boqun.feng@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, kernel-team@android.com,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>
Subject: Re: [PATCH v3 2/3] lockdep: clarify size for LOCKDEP_*_BITS configs
Date: Thu, 24 Oct 2024 15:00:48 -0400 [thread overview]
Message-ID: <19e32325-8e1b-4a9b-ae74-22448847d189@redhat.com> (raw)
In-Reply-To: <20241024183631.643450-3-cmllamas@google.com>
On 10/24/24 2:36 PM, Carlos Llamas wrote:
> The LOCKDEP_*_BITS configs control the size of internal structures used
> by lockdep. The size is calculated as a power of two of the configured
> value (e.g. 16 => 64KB). Update these descriptions to more accurately
> reflect this, as "Bitsize" can be misleading.
>
> Suggested-by: Andrew Morton <akpm@linux-foundation.org>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Boqun Feng <boqun.feng@gmail.com>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Waiman Long <longman@redhat.com>
> Cc: Will Deacon <will@kernel.org>
> Signed-off-by: Carlos Llamas <cmllamas@google.com>
> ---
> lib/Kconfig.debug | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index c8b1db37abe6..5a769cbf4bb2 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1522,7 +1522,7 @@ config LOCKDEP_SMALL
> bool
>
> config LOCKDEP_BITS
> - int "Bitsize for MAX_LOCKDEP_ENTRIES"
> + int "Size for MAX_LOCKDEP_ENTRIES (as Nth power of 2)"
> depends on LOCKDEP && !LOCKDEP_SMALL
> range 10 24
> default 15
> @@ -1530,7 +1530,7 @@ config LOCKDEP_BITS
> Try increasing this value if you hit "BUG: MAX_LOCKDEP_ENTRIES too low!" message.
>
> config LOCKDEP_CHAINS_BITS
> - int "Bitsize for MAX_LOCKDEP_CHAINS"
> + int "Size for MAX_LOCKDEP_CHAINS (as Nth power of 2)"
> depends on LOCKDEP && !LOCKDEP_SMALL
> range 10 21
> default 16
> @@ -1538,7 +1538,7 @@ config LOCKDEP_CHAINS_BITS
> Try increasing this value if you hit "BUG: MAX_LOCKDEP_CHAINS too low!" message.
>
> config LOCKDEP_STACK_TRACE_BITS
> - int "Bitsize for MAX_STACK_TRACE_ENTRIES"
> + int "Size for MAX_STACK_TRACE_ENTRIES (as Nth power of 2)"
> depends on LOCKDEP && !LOCKDEP_SMALL
> range 10 26
> default 19
> @@ -1546,7 +1546,7 @@ config LOCKDEP_STACK_TRACE_BITS
> Try increasing this value if you hit "BUG: MAX_STACK_TRACE_ENTRIES too low!" message.
>
> config LOCKDEP_STACK_TRACE_HASH_BITS
> - int "Bitsize for STACK_TRACE_HASH_SIZE"
> + int "Size for STACK_TRACE_HASH_SIZE (as Nth power of 2)"
> depends on LOCKDEP && !LOCKDEP_SMALL
> range 10 26
> default 14
> @@ -1554,7 +1554,7 @@ config LOCKDEP_STACK_TRACE_HASH_BITS
> Try increasing this value if you need large STACK_TRACE_HASH_SIZE.
>
> config LOCKDEP_CIRCULAR_QUEUE_BITS
> - int "Bitsize for elements in circular_queue struct"
> + int "Size for elements in circular_queue struct (as Nth power of 2)"
> depends on LOCKDEP
> range 10 26
> default 12
Acked-by: Waiman Long <longman@redhat.com>
next prev parent reply other threads:[~2024-10-24 19:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-24 18:36 [PATCH v3 0/3] lockdep: minor config and documentation fixes Carlos Llamas
2024-10-24 18:36 ` [PATCH v3 1/3] lockdep: fix upper limit for LOCKDEP_*_BITS configs Carlos Llamas
2024-12-24 18:53 ` [tip: locking/core] lockdep: Fix " tip-bot2 for Carlos Llamas
2024-10-24 18:36 ` [PATCH v3 2/3] lockdep: clarify size " Carlos Llamas
2024-10-24 19:00 ` Waiman Long [this message]
2024-12-24 18:53 ` [tip: locking/core] lockdep: Clarify " tip-bot2 for Carlos Llamas
2024-10-24 18:36 ` [PATCH v3 3/3] lockdep: document MAX_LOCKDEP_CHAIN_HLOCKS calculation Carlos Llamas
2024-10-24 19:01 ` Waiman Long
2024-10-25 3:01 ` Huang, Ying
2024-12-24 18:53 ` [tip: locking/core] lockdep: Document " tip-bot2 for Carlos Llamas
2024-10-28 17:34 ` [PATCH v3 0/3] lockdep: minor config and documentation fixes Boqun Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19e32325-8e1b-4a9b-ae74-22448847d189@redhat.com \
--to=llong@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=boqun.feng@gmail.com \
--cc=cmllamas@google.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®