From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2105C2749C1 for ; Sat, 11 Jul 2026 15:47:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783784824; cv=none; b=LEImgNEvSB3vy1gAhMcjMZsE8ltvgnc6xVHoQDVUmmZ1gxwwqewK1Td+P0OsAqX3AsIA9iS0Q/ZzC39HOyGBzIVmNOfyYCjS4QiMLB4Xaqj0/HX+CTAbvjA/PgvketfN9bMnAcdqqbh4RprmqbLXlauVw+xclh3wIHLji63RN5I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783784824; c=relaxed/simple; bh=phmWq8Qnt1oy+8TTFZk9uFwYG+tN1XQwPKBgPsW/sOQ=; h=Message-ID:Date:MIME-Version:From:Subject:To:References: In-Reply-To:Content-Type; b=SHaDmmvCFRuxlLENFzVPc4AnwhiDWEXAWcAC0iqG8HaQ75PG7UKWiWOkml5q+i9WVcDBKnDL4qbyTnGVyfGoDIKUTloS0YBNFdygaNNiLgKbDP6bOV0QplDEh+YpT9M10kxYa9KAtp45bMh6JWE7rIPo49b5qoTBH8X/ZUP/t1o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sbWqso7H; arc=none smtp.client-ip=209.85.208.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sbWqso7H" Received: by mail-lj1-f173.google.com with SMTP id 38308e7fff4ca-39c908d6cb6so16541981fa.1 for ; Sat, 11 Jul 2026 08:47:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783784821; x=1784389621; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :references:to:subject:from:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to:content-type; bh=W5/VwZ6Oxc77zqLMYyebH7iPvq7p0LfzuLIs9aQ8Sj4=; b=sbWqso7HvZk9MlIMwAQEago6ONinMDmcAQuOIpEKajtEwmvbThEl347sGuuZEtZuE4 GULRIt7ZfcXv7JMC17WAUig8fVmaU9iTaL5duot20xbN+/UtajKFB4DN6nbYwmutOmmj uYxH/gnvKqZdyK5CQPqP0iDG25t2wwqG2COq7HZan70el+inEvbCx8pBaqqbi8wULps2 EMbuHjqGWQdey4o9tjm5oVXVlBZe0QMXScvpFgrbS64wn2jnGnETcrlmWtjKfFKI19no 731zZT7X+FVfiOGAtdaCfLIWMspFH1lxC5Jpjm1uZQtGcEn/rfrd7hj/EnLQRsXcBhFj L68A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783784821; x=1784389621; h=content-transfer-encoding:content-type:in-reply-to:content-language :references:to:subject:from:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=W5/VwZ6Oxc77zqLMYyebH7iPvq7p0LfzuLIs9aQ8Sj4=; b=SskANs+JE33gGe3e4UHeHGCJa0BDi3ambL0nFqvLemyGzed5Nxyk+IPsy2KgOs5XKw 9/BD1sRnDDp+RlSZAzgp/4YFKAeioBtUtBs9O3OZBHsRKMIegT4zlVDqYmNtT4MBXvsx RizpV614Lx53vLlKn2B12EqLocdbM/wURwdMLEOZ/Mauw2gUT+PMH8siVvksjB8Jx3HA xc80Pathx43qHew1SVic1KXD/o5ezSHS0DmwRQU7cXxEy8xtTjLbhdGKom+e2eO8tWN7 YhdChLIAgKH163L7erP3AieKJKGAXixHE4GDWcnYSjnE2ZgnbyRkWVp+FqVfBbIIj7L4 rDcg== X-Forwarded-Encrypted: i=1; AHgh+Ro5rQl2MVCOwzpotRxj3xCkCJ834/YeLK8POqoS3Raai+9Vm4aMpy1wG6Pt9HNIZKIdY/zAuHFpHdprnXQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxworCCCCckjBH83swUoZAepELN/RmD/aKin9lSxvk57tMmKLAl kryY39UX9xY4C3vdfMjuojaWriuaCW1XCCHBsakD3V5BoLuUm4fTdhrp X-Gm-Gg: AfdE7ckENJJXWBD5Fy+9ICODuMc0sAjMW0/bGstR+bEwUw9K+OaFWEOZNUtA3F3qBEx PEh4csvcb8b0ZFQEgJz3qYYCcnRvkyYIv5elgDNVkOZtSD9ZQ/EFxxMd0aNAMWkRh6ucAes3vkU H/M1B2F8uWNUsoAP3+r9OLQk88veSMUoYWk6nZljKS2GtMuEe5mVuf0ft2Zm8pWHo04Gxg4dJmq 4SdJSwsDfbWYyWpZ9ji08Qry7rpMxx/eq0jXdBwi8KYELnzlJ+L2tY/9g2m2FSUjoHDy1XNrKXp OEUkZlncEDQVO2544JRLP5V6z2yWvYh8djN0/31QEtFd5rFuCPZLJsZQI55DpNYbvzZqv5zr+tm vcn9Wx3YjRTk6Uq2myx04sRtKfQ9JVrtnsksuyECjvlI8/XDN26uPVBKxO++P+6ifB3G5TgiqQS wYLB4VVG+XCjHUo9m8fEtT8x10DqD5jjoHwHSPGMUGhVX1y7U= X-Received: by 2002:a05:651c:25d5:20b0:39c:a09d:c48b with SMTP id 38308e7fff4ca-39caa8940cbmr5046721fa.36.1783784821119; Sat, 11 Jul 2026 08:47:01 -0700 (PDT) Received: from [192.168.1.89] (c-85-228-45-68.bbcust.telenor.se. [85.228.45.68]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-39c84b83a93sm17206711fa.24.2026.07.11.08.46.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 11 Jul 2026 08:46:59 -0700 (PDT) Message-ID: <19e99783-df6e-eca5-ba79-40fd55404bf6@outbound.gmail.com> Date: Sat, 11 Jul 2026 17:46:31 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 From: Eli Billauer Subject: Re: [PATCH 3/3] char: xillybus: Remove redundant dev_err() To: Pan Chuang , Arnd Bergmann , Greg Kroah-Hartman , "open list:XILLYBUS DRIVER" References: <20260710105318.376496-1-panchuang@vivo.com> <20260710105318.376496-4-panchuang@vivo.com> Content-Language: en-US In-Reply-To: <20260710105318.376496-4-panchuang@vivo.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/07/2026 12:53, Pan Chuang wrote: > Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in > devm_request_*_irq()"), devm_request_irq() automatically logs > detailed error messages on failure. Remove the now-redundant > driver-specific dev_err() calls. > My opinion about error messages is the more the merrier, but I suppose this is part of a more general code cleanup. As this specific error message isn't expected to happen often, I have no reason to object. Thanks & regards, Eli Acked-by: Eli Billauer