mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: sam@ravnborg.org, Miquel Raynal <miquel.raynal@bootlin.com>,
	"Maciej W. Rozycki" <macro@orcam.me.uk>
Cc: sparclinux@vger.kernel.org, linux-parport@lists.infradead.org,
	"David S. Miller" <davem@davemloft.net>,
	Andreas Larsson <andreas@gaisler.com>,
	Arnd Bergmann <arnd@arndb.de>,
	linux-kernel@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 4/6] usb: host: uhci-grlib.c: Fix build, add platform_device
Date: Fri, 23 Feb 2024 16:31:56 -0800	[thread overview]
Message-ID: <19ecb47a-a168-49df-9673-bc1522f7d2c4@infradead.org> (raw)
In-Reply-To: <20240223-sam-fix-sparc32-all-builds-v1-4-5c60fd5c9250@ravnborg.org>



On 2/23/24 11:36, Sam Ravnborg via B4 Relay wrote:
> From: Sam Ravnborg <sam@ravnborg.org>
> 
> Fix the followig build error:
> uhci-grlib.c:92:29: error: invalid use of undefined type 'struct platform_device'
> 
> The fix was straightforward, and no attempt was made to understand why
> the build failed.
> 
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
> Cc: Andreas Larsson <andreas@gaisler.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

This looks good but the same patch is already in linux-next, courtesy of
Andreas.

> ---
>  drivers/usb/host/uhci-grlib.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/host/uhci-grlib.c b/drivers/usb/host/uhci-grlib.c
> index ac3fc5970315..cfebb833668e 100644
> --- a/drivers/usb/host/uhci-grlib.c
> +++ b/drivers/usb/host/uhci-grlib.c
> @@ -22,6 +22,7 @@
>  #include <linux/of_irq.h>
>  #include <linux/of_address.h>
>  #include <linux/of_platform.h>
> +#include <linux/platform_device.h>
>  
>  static int uhci_grlib_init(struct usb_hcd *hcd)
>  {
> 

-- 
#Randy

  reply	other threads:[~2024-02-24  0:32 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-23 19:36 [PATCH 0/6] sparc32: build fixes for all{yes,mod}config builds Sam Ravnborg via B4 Relay
2024-02-23 19:36 ` [PATCH 1/6] sparc32: Use generic cmpdi2/ucmpdi2 variants Sam Ravnborg via B4 Relay
2024-02-24  0:27   ` Randy Dunlap
2024-02-24  2:54   ` Maciej W. Rozycki
2024-02-23 19:36 ` [PATCH 2/6] sparc32: Fix build with trapbase Sam Ravnborg via B4 Relay
2024-02-24  0:29   ` Randy Dunlap
2024-02-23 19:36 ` [PATCH 3/6] mtd: maps: sun_uflash: Declare uflash_devinit static Sam Ravnborg via B4 Relay
2024-02-24  0:30   ` Randy Dunlap
2024-02-23 19:36 ` [PATCH 4/6] usb: host: uhci-grlib.c: Fix build, add platform_device Sam Ravnborg via B4 Relay
2024-02-24  0:31   ` Randy Dunlap [this message]
2024-02-23 19:36 ` [PATCH 5/6] sparc32: Do not select GENERIC_ISA_DMA Sam Ravnborg via B4 Relay
2024-02-24  0:32   ` Randy Dunlap
2024-02-24  2:55   ` Maciej W. Rozycki
2024-02-24  5:29     ` Maciej W. Rozycki
2024-02-24  7:59       ` Sam Ravnborg
2024-02-24 11:24       ` Arnd Bergmann
2024-02-24 17:14         ` Sam Ravnborg
2024-02-23 19:36 ` [PATCH 6/6] sparc32: Fix parport build with sparc32 Sam Ravnborg via B4 Relay
2024-02-24  0:34   ` Randy Dunlap
2024-02-24  3:02   ` Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19ecb47a-a168-49df-9673-bc1522f7d2c4@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=andreas@gaisler.com \
    --cc=arnd@arndb.de \
    --cc=davem@davemloft.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-parport@lists.infradead.org \
    --cc=macro@orcam.me.uk \
    --cc=miquel.raynal@bootlin.com \
    --cc=sam@ravnborg.org \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®