From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C8BCC56202 for ; Thu, 26 Nov 2020 14:57:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4773820B80 for ; Thu, 26 Nov 2020 14:57:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391297AbgKZO5T (ORCPT ); Thu, 26 Nov 2020 09:57:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389878AbgKZO5S (ORCPT ); Thu, 26 Nov 2020 09:57:18 -0500 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7EA9DC0613D4; Thu, 26 Nov 2020 06:57:18 -0800 (PST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: koike) with ESMTPSA id 052381F4490B Subject: Re: [PATCH] media: rockchip: rkisp1: Fix typos in comments and macro definitions To: Peilin Ye , Dafna Hirschfeld Cc: Mauro Carvalho Chehab , Heiko Stuebner , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20201126122148.9162-1-yepeilin.cs@gmail.com> From: Helen Koike Message-ID: <19ef2031-1e09-6418-1bce-7c5713d296d7@collabora.com> Date: Thu, 26 Nov 2020 11:57:10 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201126122148.9162-1-yepeilin.cs@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Peilin, On 11/26/20 9:21 AM, Peilin Ye wrote: > Fix 4 typos under drivers/media/platform/rockchip/rkisp1/ found by > checkpatch, including the RKISP1_CIF_MI_{M,S}P_PINGPONG_ENABLE macro > definitions. > > Signed-off-by: Peilin Ye Thanks Acked-by: Helen Koike > --- > Hi Helen, Dafna, > > I noticed that the RKISP1_CIF_MI_{M,S}P_PINGPONG_ENABLE macros are not > being used yet, but according to page 12 of this developer guide [1] I > think they are for *enabling* the ping-pong ("double buffers") mode? Looks like. The documentation I have doesn't explain much about this mode, it just mention that bit is used to enable it, and that MI_{MP,SP}_{CR,CB}_BASE_AD_INIT2 are used to configure base address 2. Regards, Helen > > Based on linux-next 9d3e48f20e11 ("Add linux-next specific files for > 20201125"). > > Thanks, > Peilin Ye > > [1] https://dl.vamrs.com/products/rock960/docs/sw/Rockchip%C2%A0Linux%20Camera%C2%A0Developer%20Guide%20V1.1.pdf#page=12 > > drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c | 4 ++-- > drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c > index b81235afd053..94b65680c4c1 100644 > --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c > +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-capture.c > @@ -46,7 +46,7 @@ enum rkisp1_plane { > /* > * @fourcc: pixel format > * @fmt_type: helper filed for pixel format > - * @uv_swap: if cb cr swaped, for yuv > + * @uv_swap: if cb cr swapped, for yuv > * @write_format: defines how YCbCr self picture data is written to memory > * @output_format: defines sp output format > * @mbus: the mbus code on the src resizer pad that matches the pixel format > @@ -870,7 +870,7 @@ static void rkisp1_cap_stream_disable(struct rkisp1_capture *cap) > { > int ret; > > - /* Stream should stop in interrupt. If it dosn't, stop it by force. */ > + /* Stream should stop in interrupt. If it doesn't, stop it by force. */ > cap->is_stopping = true; > ret = wait_event_timeout(cap->done, > !cap->is_streaming, > diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h b/drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h > index 049f6c3a11df..8a8d960a679c 100644 > --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h > +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-regs.h > @@ -106,8 +106,8 @@ > #define RKISP1_CIF_MI_SP_Y_FULL_YUV2RGB BIT(8) > #define RKISP1_CIF_MI_SP_CBCR_FULL_YUV2RGB BIT(9) > #define RKISP1_CIF_MI_SP_422NONCOSITEED BIT(10) > -#define RKISP1_CIF_MI_MP_PINGPONG_ENABEL BIT(11) > -#define RKISP1_CIF_MI_SP_PINGPONG_ENABEL BIT(12) > +#define RKISP1_CIF_MI_MP_PINGPONG_ENABLE BIT(11) > +#define RKISP1_CIF_MI_SP_PINGPONG_ENABLE BIT(12) > #define RKISP1_CIF_MI_MP_AUTOUPDATE_ENABLE BIT(13) > #define RKISP1_CIF_MI_SP_AUTOUPDATE_ENABLE BIT(14) > #define RKISP1_CIF_MI_LAST_PIXEL_SIG_ENABLE BIT(15) >