From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794861138; b=NBlGwS5YZvs7yuOZTaDCyyQ+0rM/l1FEUJw8eG3r/tui9+K+miICp2H6g8wP/KzSEpzb /f3eFb+L+sBRBdGm/G4THt0T5R337RHIBEC1B1ESmpSXzDbp9koFqvmdgBAEBD8Imidh9 4qX/if3rHCWLm9fscFWxB1LWRK2fGfaxKd64qTRol0AaldsieiHMeLgZ+9UoAP0zgc9oq LW/65nK3j+nBv0uUCPsl9SR37dhD5Nw3jXeesdnw4bwP01iMqV9SxcX+wnSVyofZyE4Ke LV3w2hNXmLR6BS3fcladLZemIdnvYrP6DBpRlsgxzsYobDLqB5U1W8RG/20iz7qmF3A== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794861138; h=Received:DKIM-Signature:Message-ID:Date:MIME-Version:User-Agent: Subject:To:Cc:References:From:Content-Language:Autocrypt:In-Reply-To: Content-Type:Content-Transfer-Encoding; bh=cSymAHtSTg9MrbbuavNs8edEjM4tR6Glt6TgXdMzi/A=; b=dBwx8Fi/0JgCQwtcx3el4asgtqbXVsXIZqenbQzi/fjcz/vn07sI0HOwrBbXz2ZPVgx7 lxe1tEmf6fXhoHREC3324T3HXY4pGG0xRX805XLnogjVUuYi49lNWfAvFc72JdLUmahpa MtnFdtxZgqZ2WkWCWlLfXggDgGjsx7zBTGS6PJh6dbl/aQio0udj2zC7LVmqezyq6nxru 1Ggn0IV2w03MzKbbpNNv7wI+396I8YGYvJjX5jsxY7Mq7Mggco9mxBpk1iGTw1ZCQwNQs fIrjoIqJenaUe6aECxpCLzbNF2KSAQ12dSSCO0PuQWIQPQRc0hIVeD5Ujdb/IM2a5vA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=Vbv6Njp2; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AB49606A31C; Mon, 16 Nov 2026 20:32:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=Vbv6Njp2 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 49E0F1F000C4; Mon, 16 Nov 2026 20:32:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794861137; bh=cSymAHtSTg9MrbbuavNs8edEjM4tR6Glt6TgXdMzi/A=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=Vbv6Njp2KLEJHIydFEEfCotyeJuqayD9Sy+dYVwcC9Qj/OoLscJ0W+s8Iy26p3DDA 6KFtMZhtKJC8zGtC3E+gUdJ403cN81FSz4W65tr/Jv6q6xbEXGWaggjYEv+/r9vXnM NMi2QPIv0uUu5p+fiORRAgn5DugWKFefEAzh852mRS439hc9djnHcPPeTgGRZDlPqe HTNxMLSvKgKLZzTq9/xtQhPrJ357+1dLguwZXVZwbF+S9QUFLn2dd8ClOxmziRgPOW Jz77F5RiulDKG5if0VtPTDOn4pNyHMLMKVLYKeVTBXzP+9h2gs2mIQ09w7wnxg2ZmI Os+woIRAQQW2g== Message-ID: <19f00f83-070c-44b0-a842-dc2fa6dd668e@kernel.org> Date: Mon, 16 Nov 2026 21:32:04 +0100 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 6/9] mm/huge_memory: build the moved huge zero PMD from the destination VMA To: Tal Zussman , Andrew Morton , Mike Rapoport , Peter Xu , James Houghton , Andrea Arcangeli , Suren Baghdasaryan , Balbir Singh , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Pedro Falcato , Michal Hocko , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Andrei Vagin , Muhammad Usama Anjum , Stephen Rothwell , Arnd Bergmann , Zi Yan , Matthew Brost , Joshua Hahn , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Usama Arif , Kiryl Shutsemau , Muchun Song , Oscar Salvador , =?UTF-8?Q?Miko=C5=82aj_Lenczewski?= Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org References: <20261116-uffd-state-fixes-v2-0-4397a0196479@columbia.edu> <20261116-uffd-state-fixes-v2-6-4397a0196479@columbia.edu> From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <20261116-uffd-state-fixes-v2-6-4397a0196479@columbia.edu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/16/26 21:02, Tal Zussman wrote: > move_pages_huge_pmd() builds the destination PMD for the huge zero page > by copying the source PMD and clearing its uffd bit, so the destination > keeps the protection of the source. > > A source VMA registered for RWP can map the huge zero page with a > PAGE_NONE PMD, and UFFDIO_MOVE does not check how the source is > registered. The destination then gets a PAGE_NONE PMD without the uffd > bit, although nothing asked for that in the destination VMA. > > The next access fixes it up through the NUMA hinting fault path. Until > then, the first access to the destination takes a spurious fault and GUP > has to take the fault path. The impact on userspace is small. > > The moved entry must have the protection of the destination VMA. To fix > it, build the entry from the vm_page_prot of the destination VMA, as > move_zeropage_pte() does for the small zero page, and keep marking it > soft-dirty. A destination VMA registered for RWP still gets its PMD > re-armed afterwards. > > Fixes: 763f43865fc4 ("mm: preserve RWP marker across PTE rewrites") > Reviewed-by: Kiryl Shutsemau (Meta) > Tested-by: Gregory Price (Meta) > Reviewed-by: Gregory Price (Meta) > Signed-off-by: Tal Zussman > --- > mm/huge_memory.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 5e2629602221..a2b1ac11e7dd 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -3003,9 +3003,9 @@ int move_pages_huge_pmd(struct mm_struct *mm, pmd_t *dst_pmd, pmd_t *src_pmd, pm > /* Follow mremap() behavior and treat the entry dirty after the move */ > _dst_pmd = pmd_mkwrite(pmd_mkdirty(_dst_pmd), dst_vma); > } else { > - src_pmdval = pmdp_huge_clear_flush(src_vma, src_addr, src_pmd); > - _dst_pmd = move_soft_dirty_pmd(src_pmdval); > - _dst_pmd = clear_uffd_wp_pmd(_dst_pmd); > + pmdp_huge_clear_flush(src_vma, src_addr, src_pmd); > + _dst_pmd = folio_mk_pmd(huge_zero_folio, dst_vma->vm_page_prot); > + _dst_pmd = move_soft_dirty_pmd(pmd_mkspecial(_dst_pmd)); Yeah, mostly what we do in set_huge_zero_folio(). Acked-by: David Hildenbrand (Arm) -- Cheers, David