From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756956AbYDUPNp (ORCPT ); Mon, 21 Apr 2008 11:13:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753370AbYDUPNe (ORCPT ); Mon, 21 Apr 2008 11:13:34 -0400 Received: from wr-out-0506.google.com ([64.233.184.231]:58268 "EHLO wr-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753349AbYDUPNd (ORCPT ); Mon, 21 Apr 2008 11:13:33 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=KeI/PTLbmyJhlFO4MmTuwHOIashh9LLq3j9l4cNU78aYCPUTRmmK8b1wI8m9R3TF3Fz4OqhKPTiVdFaMOBCnSjHir4jXd8sSdlCe3goBkPuxK23DTs0Xll7WzJi5/5SiXysTs8EuvKl8n4IXElHwyPgVAsq+VIyq40zshPg3pPQ= Message-ID: <19f34abd0804210813u72b6b670j2d2477ebf187563a@mail.gmail.com> Date: Mon, 21 Apr 2008 17:13:31 +0200 From: "Vegard Nossum" To: "Adrian Bunk" Subject: Re: [Bug 10489] Kprobe smoke test lockdep warning Cc: ananth@in.ibm.com, anil.s.keshavamurthy@intel.com, davem@davemloft.net, mhiramat@redhat.com, bugme-daemon@bugzilla.kernel.org, "jean-marc LACROIX" , linux-kernel@vger.kernel.org, "Ingo Molnar" , "Arjan van de Ven" In-Reply-To: <20080421150656.GJ6011@cs181133002.pp.htv.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080421150656.GJ6011@cs181133002.pp.htv.fi> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 21, 2008 at 5:06 PM, Adrian Bunk wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=10489 > > Please reply via email (more information from the submitter is in the > Bugzilla entry). > > > ReportedBy: jeanmarc.lacroix@free.Fr > > Earliest failing kernel version: 2.6.25 > Distribution: DEbian Etch > Hardware Environment: PIII > Software Environment: > Problem Description: Warning at boot after running all > embedded test > > Steps to reproduce: boot !!! > > > 2.701005] Registering sys device '' > [ 2.702320] Registering sys device '' > [ 2.703711] Registering sys device '' > [ 2.704536] Initializing RT-Tester: OK > [ 2.704824] device: 'snapshot': device_add > [ 2.705140] PM: Adding info for No Bus:snapshot > [ 2.706804] audit: initializing netlink socket (disabled) > [ 2.707199] type=2000 audit(1208713807.707:1): initialized > [ 2.707509] Kprobe smoke test started > [ 2.709300] ------------[ cut here ]------------ > [ 2.709420] WARNING: at kernel/lockdep.c:2658 check_flags+0x4d/0x12c() > [ 2.709541] Modules linked in: > [ 2.709588] Pid: 1, comm: swapper Not tainted 2.6.25.jml.057 #1 > [ 2.709588] [] warn_on_slowpath+0x41/0x51 > [ 2.709588] [] ? save_stack_trace+0x1d/0x3b > [ 2.709588] [] ? save_trace+0x37/0x89 > [ 2.709588] [] ? kernel_map_pages+0x103/0x11c > [ 2.709588] [] ? native_sched_clock+0xca/0xea > [ 2.709588] [] ? mark_held_locks+0x41/0x5c > [ 2.709588] [] ? kprobe_exceptions_notify+0x322/0x3af > [ 2.709588] [] ? trace_hardirqs_on+0xf1/0x119 > [ 2.709588] [] ? kprobe_exceptions_notify+0x355/0x3af > [ 2.709588] [] check_flags+0x4d/0x12c > [ 2.709588] [] lock_release+0x58/0x195 > [ 2.709588] [] ? __atomic_notifier_call_chain+0x0/0x80 > [ 2.709588] [] __atomic_notifier_call_chain+0x5a/0x80 > [ 2.709588] [] atomic_notifier_call_chain+0xc/0xe > [ 2.709588] [] notify_die+0x2d/0x2f > [ 2.709588] [] do_debug+0x67/0xfe > [ 2.709588] [] debug_stack_correct+0x27/0x30 > [ 2.709588] [] ? kprobe_target+0x1/0x34 > [ 2.709588] [] ? init_test_probes+0x50/0x186 > [ 2.709588] [] init_kprobes+0x85/0x8c > [ 2.709588] [] kernel_init+0x13d/0x298 > [ 2.709588] [] ? kernel_init+0x0/0x298 > [ 2.709588] [] ? kernel_init+0x0/0x298 > [ 2.709588] [] kernel_thread_helper+0x7/0x10 > [ 2.709588] ======================= > [ 2.709588] ---[ end trace 778e504de7e3b1e3 ]--- > [ 2.709588] possible reason: unannotated irqs-off. > [ 2.709588] irq event stamp: 370065 > [ 2.709588] hardirqs last enabled at (370065): [] > kprobe_exceptions_notify+0x322/0x3af > [ 2.709588] hardirqs last disabled at (370064): [] > do_int3+0x1d/0x7d > [ 2.709588] softirqs last enabled at (370050): [] > __do_softirq+0xfa/0x100 > [ 2.709588] softirqs last disabled at (370045): [] > do_softirq+0x74/0xd9 > [ 2.714751] Kprobe smoke test passed successfully > [ 2.716150] Total HugeTLB memory allocated, 0 > [ 2.717288] VFS: Disk quotas dquot_6.5.1 > [ 2.717689] Dquot-cache hash table entries: 1024 (order 0, 4096 bytes) > [ 2.719630] device class 'bsg': registering > [ 2.720568] Block layer SCSI generic (bsg) driver version 0.4 loaded (major > 253) > [ 2.720619] io scheduler noop registered > [ 2.720732] io scheduler anticipatory registered > [ 2.720848] io scheduler deadline registered > [ 2.721089] io scheduler cfq registered (default) > [ 2.721354] pci 0000:00:01.0: Boot video device > This is because kprobes (just like kmemcheck and mmiotrace) needs to disable interrupts while it single-steps the instruction. This is not dangerous, and should be fixed by doing as the warning suggests, by annotating the irqs-off. I don't remember the name of the function(s), it is probably somewhere in lockdep.h. Vegard -- "The animistic metaphor of the bug that maliciously sneaked in while the programmer was not looking is intellectually dishonest as it disguises that the error is the programmer's own creation." -- E. W. Dijkstra, EWD1036