From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759675AbYDZQ5V (ORCPT ); Sat, 26 Apr 2008 12:57:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758571AbYDZQ5M (ORCPT ); Sat, 26 Apr 2008 12:57:12 -0400 Received: from wf-out-1314.google.com ([209.85.200.172]:18042 "EHLO wf-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755743AbYDZQ5K (ORCPT ); Sat, 26 Apr 2008 12:57:10 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=J906SZj2A/5Ers0pkTHoSayxbKF79cvkLxYUArsUO5yPDXh8wmTz5rxW0HpKuZIOnJJktGAoxXlhidLVgp34bF7dmVrOTaoYYi5GB5H7+moQ4eh18L3hM0N+2LFj6t7GMs4fGRsEjsBK04oQA4OgAr+sntQNWkIKOPlIkQVRkDk= Message-ID: <19f34abd0804260957i62db6929s2a4227a517f3c9a1@mail.gmail.com> Date: Sat, 26 Apr 2008 18:57:09 +0200 From: "Vegard Nossum" To: "Adrian Bunk" Subject: Re: [PATCH] headerdep: a tool for detecting inclusion cycles in header file Cc: "Sam Ravnborg" , "Pekka Enberg" , linux-kbuild@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20080426164450.GK2252@cs181133002.pp.htv.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080426134554.GA20727@damson.getinternet.no> <20080426164450.GK2252@cs181133002.pp.htv.fi> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/26/08, Adrian Bunk wrote: > On Sat, Apr 26, 2008 at 03:45:54PM +0200, Vegard Nossum wrote: > > > Hi Sam, > > > > Maybe something like this could be useful for cleaning up headers (and > > maintaining that cleanliness once it has been achieved). What do you think? > > >... > > And another note (after looking at the Cc list): > > Header cleanup is *not* something suitable as a first task for a janitor. Hehe, yes, I could not agree more! I have been trying to resolve some of these errors myself, but it's incredibly hard to get right. The reason I CCed kernel-janitors is that this IS a janitorial project. But I am not implying that janitor means "newbie" or trivial. At least the way I see it, janitor work is cleaning up, but not necessarily easy work. But I agree, definitely not a first task job. > The interesting cases are non-trivial. > > And you need cross compilers for all architectures since fiddling with > #include's under include/ breaks code left and right that only compiled > due to some implicit #include (and if it still works due to another > implicit #include on x86 the latter might not be present on all > architectures). Yep. I have been compiling cross-compilers myself. As a btw, I had already started some project to distribute binary cross-compilers http://folk.uio.no/vegardno/crosstool/ for the purpose of making cross-compiling easier to get started with. (It would be cool to have a complete suite of working cross-compilers in a single download.) Vegard -- "The animistic metaphor of the bug that maliciously sneaked in while the programmer was not looking is intellectually dishonest as it disguises that the error is the programmer's own creation." -- E. W. Dijkstra, EWD1036