From: "Vegard Nossum" <vegard.nossum@gmail.com>
To: "Sam Ravnborg" <sam@ravnborg.org>
Cc: "Ingo Molnar" <mingo@elte.hu>,
linux-kernel@vger.kernel.org,
"the arch/x86 maintainers" <x86@kernel.org>,
"Peter Zijlstra" <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH] x86: more header fixes
Date: Thu, 26 Jun 2008 15:44:51 +0200 [thread overview]
Message-ID: <19f34abd0806260644s30698d34jd227c170aae8278c@mail.gmail.com> (raw)
In-Reply-To: <20080626133047.GA11762@uranus.ravnborg.org>
On Thu, Jun 26, 2008 at 3:30 PM, Sam Ravnborg <sam@ravnborg.org> wrote:
> Can I ask you to chase all uses of #include <asm-x86/xxx.h>
> and convert them to #include <asm/xxx.h>
>
> When we move include/asm-x86 to arch/x86/include/asm this is needed and
> better to fix these sooner.
Hm. I can't really seem to find many:
./Documentation/lguest/lguest.c:#include "asm-x86/bootparam.h"
./arch/um/sys-x86_64/syscall_table.c:#include <asm-x86/unistd_64.h>
./arch/um/sys-x86_64/syscall_table.c:#include <asm-x86/unistd_64.h>
./arch/ia64/ia32/audit.c:#include <asm-x86/unistd_32.h>
..and I don't even know how to fix them. It seems that we might want
to use filesystem links here instead? (Git should be able to handle
that.)
E.g. so that arch/ia64/include/asm/unistd_32.h ->
arch/x86/include/asm/unistd_32.h. Then arch/ia64/ia32/audit.c can
#include <asm/unistd_32.h>.
Vegard
--
"The animistic metaphor of the bug that maliciously sneaked in while
the programmer was not looking is intellectually dishonest as it
disguises that the error is the programmer's own creation."
-- E. W. Dijkstra, EWD1036
next prev parent reply other threads:[~2008-06-26 13:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-10 21:45 Vegard Nossum
2008-06-18 10:30 ` Ingo Molnar
2008-06-18 16:19 ` Vegard Nossum
2008-06-26 12:02 ` Ingo Molnar
2008-06-26 13:30 ` Sam Ravnborg
2008-06-26 13:44 ` Vegard Nossum [this message]
2008-06-26 17:30 ` Sam Ravnborg
2008-06-26 16:53 ` Vegard Nossum
2008-07-01 9:28 ` Ingo Molnar
2008-07-16 11:51 ` Ingo Molnar
2008-07-16 12:50 ` Vegard Nossum
2008-07-16 13:08 ` Ingo Molnar
2008-07-16 13:17 ` Ingo Molnar
2008-07-16 13:46 ` Vegard Nossum
2008-07-16 14:22 ` Ingo Molnar
2008-07-22 12:32 ` Vegard Nossum
2008-07-22 10:36 ` Ingo Molnar
2008-07-22 11:13 ` Vegard Nossum
2008-07-22 11:38 ` Ingo Molnar
2008-07-22 18:27 ` Vegard Nossum
2008-07-26 13:08 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19f34abd0806260644s30698d34jd227c170aae8278c@mail.gmail.com \
--to=vegard.nossum@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sam@ravnborg.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®