mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Vegard Nossum" <vegard.nossum@gmail.com>
To: "Eric Sesterhenn" <snakebyte@gmx.de>
Cc: "Anton Altaparmakov" <aia21@cam.ac.uk>,
	linux-ntfs-dev@lists.sourceforge.net,
	linux-kernel@vger.kernel.org
Subject: Re: [Linux-NTFS-Dev] Oops with corrupted NTFS image
Date: Mon, 7 Jul 2008 15:03:53 +0200	[thread overview]
Message-ID: <19f34abd0807070603p23b30372l5bee26b05b6fa9c7@mail.gmail.com> (raw)
In-Reply-To: <20080707122450.GC19313@alice>

On Mon, Jul 7, 2008 at 2:24 PM, Eric Sesterhenn <snakebyte@gmx.de> wrote:
> (gdb) l *(ntfs_read_locked_inode+0x16c)
> 0xc030adbc is in ntfs_read_locked_inode (fs/ntfs/time.h:90).
> 85      static inline struct timespec ntfs2utc(const sle64 time)
> 86      {
> 87              struct timespec ts;
> 88
> 89              /* Subtract the NTFS time offset. */
> 90              u64 t = (u64)(sle64_to_cpu(time) - NTFS_TIME_OFFSET);
> 91              /*
> 92               * Convert the time to 1-second intervals and the remainder to
> 93               * 1-nano-second intervals.
> 94               */
> (gdb) quit
>
> Not sure why this happens. I checked out a fresh git tree to
> make sure my tree isnt broken or something. Might gcc be bogus
> or the debug information and the bug happens in reality somewhere else?

Are you sure you didn't recompile/relink vmlinux after getting the
error? If not, maybe it's gdb which gets confused (somehow) by the
inlining.

Your 'Code:' line decodes to these instructions:

   0:   8b 58 08                mov    0x8(%eax),%ebx
   3:   8b 70 0c                mov    0xc(%eax),%esi

And I find this in my own compiled vmlinux at:

c025bcc1:       8b 58 08                mov    0x8(%eax),%ebx
c025bcc4:       8b 70 0c                mov    0xc(%eax),%esi

which is at...

    $ addr2line -e vmlinux -i c025bcc1
    fs/ntfs/inode.c:670

which is...

        vi->i_mtime = ntfs2utc(si->last_data_change_time);

which is probably what is causing the NULL pointer dereference.


Vegard

-- 
"The animistic metaphor of the bug that maliciously sneaked in while
the programmer was not looking is intellectually dishonest as it
disguises that the error is the programmer's own creation."
	-- E. W. Dijkstra, EWD1036

  reply	other threads:[~2008-07-07 13:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-06 17:21 Eric Sesterhenn
2008-07-07  8:07 ` [Linux-NTFS-Dev] " Anton Altaparmakov
2008-07-07 12:24   ` Eric Sesterhenn
2008-07-07 13:03     ` Vegard Nossum [this message]
2008-07-07 13:26       ` Carl-Daniel Hailfinger
2008-07-07 13:33         ` Vegard Nossum
2008-07-07 13:21   ` Carl-Daniel Hailfinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19f34abd0807070603p23b30372l5bee26b05b6fa9c7@mail.gmail.com \
    --to=vegard.nossum@gmail.com \
    --cc=aia21@cam.ac.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-ntfs-dev@lists.sourceforge.net \
    --cc=snakebyte@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®