mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Vegard Nossum" <vegard.nossum@gmail.com>
To: "David Miller" <davem@davemloft.net>
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, penberg@cs.helsinki.fi, rjw@sisk.pl
Subject: Re: [bug, netconsole, SLUB] BUG skbuff_head_cache: Poison overwritten
Date: Fri, 18 Jul 2008 09:03:50 +0200	[thread overview]
Message-ID: <19f34abd0807180003m7bdf832g141777751d7ea563@mail.gmail.com> (raw)
In-Reply-To: <20080717.190315.186892939.davem@davemloft.net>

On Fri, Jul 18, 2008 at 4:03 AM, David Miller <davem@davemloft.net> wrote:
>> On Thu, Jul 17, 2008 at 11:42 PM, Ingo Molnar <mingo@elte.hu> wrote:
>> >
>> > A regression to v2.6.26:
>> >
>> > I started getting this skb-head corruption message today, on a T60
>> > laptop with e1000:
>> >
>> > PM: Removing info for No Bus:vcs11
>> > device: 'vcs11': device_create_release
>> > =============================================================================
>> > BUG skbuff_head_cache: Poison overwritten
>> > -----------------------------------------------------------------------------
>> >
>> > INFO: 0xf658ae9c-0xf658ae9c. First byte 0x6a instead of 0x6b
>>
>> 1. Notice the range. It's just a single byte.
>> 2. Notice the value. It's just a ++.
>
> It's supposed to be 0x6b, this would be a "--"

You're right! Oops. In my defence, I wrote that at 2 AM last night ;-)

> Also it (more likely IMHO) could be clearing a flag with the value 0x01.

It could be. But like I said in a later e-mail, the thing is likely
sk_buff->truesize. Which is not a flags variable. It _is_ however, a
counter, which is frequently -= and atomic_sub()ed.

That field is also an int, not a byte like I suggested above. This is
fine, though. "--" on an int can of course legitimately update/change
just the lower byte of an int.

But.. it could also be some random corruption coming from elsewhere.
Maybe even bad RAM (it's just a single bit anyway). But that's less
likely.


Vegard

-- 
"The animistic metaphor of the bug that maliciously sneaked in while
the programmer was not looking is intellectually dishonest as it
disguises that the error is the programmer's own creation."
	-- E. W. Dijkstra, EWD1036

  reply	other threads:[~2008-07-18  7:04 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-17 21:42 Ingo Molnar
2008-07-17 21:45 ` David Miller
2008-07-17 22:06   ` Ingo Molnar
2008-07-17 22:09     ` David Miller
2008-07-17 22:43     ` Ingo Molnar
2008-07-17 23:15 ` Vegard Nossum
2008-07-17 23:35   ` Vegard Nossum
2008-07-17 23:52   ` Ingo Molnar
2008-07-18  0:01     ` Ingo Molnar
2008-07-18  0:05     ` Vegard Nossum
2008-07-18  0:16       ` Ingo Molnar
2008-07-18  2:13     ` David Miller
2008-07-18  2:03   ` David Miller
2008-07-18  7:03     ` Vegard Nossum [this message]
2008-07-18  7:12       ` David Miller
2008-07-18  9:05       ` Ingo Molnar
2008-07-18 19:10       ` [bug] Attempt to release alive inet socket f6fac040 Ingo Molnar
2008-07-18 19:55         ` Ingo Molnar
2008-07-17 23:27 ` [bug, netconsole, SLUB] BUG skbuff_head_cache: Poison overwritten Vegard Nossum
2008-07-17 23:56   ` Ingo Molnar
2008-07-21 11:41     ` Vegard Nossum
2008-07-18  5:46 ` Evgeniy Polyakov
2008-07-18  9:02   ` Pekka Enberg
2008-07-18  9:09     ` Ingo Molnar
2008-07-18  9:15       ` Pekka Enberg
2008-07-18 10:16     ` Evgeniy Polyakov
2008-07-18 14:44       ` Pekka Enberg
2008-07-18 14:48         ` Christoph Lameter
2008-07-18 16:07         ` Evgeniy Polyakov
2008-07-18  9:00 ` Pekka J Enberg
2008-07-18  9:11   ` Ingo Molnar
2008-07-18  9:16     ` Pekka Enberg
2008-07-18 13:54       ` Christoph Lameter
2008-07-21  9:41     ` Ingo Molnar
2008-07-21  9:52       ` Pekka Enberg
2008-07-21 10:06         ` Evgeniy Polyakov
2008-07-21 10:50           ` Ingo Molnar
2008-07-21 11:03             ` Vegard Nossum
2008-07-21 11:13               ` Ingo Molnar
2008-07-21 16:19               ` Christoph Lameter
2008-07-21 20:23                 ` Vegard Nossum
2008-07-21 11:25             ` Evgeniy Polyakov
2008-07-21 11:55               ` Ingo Molnar
2008-07-21 12:57                 ` Evgeniy Polyakov
2008-07-21 14:01                   ` Ingo Molnar
2008-07-21 19:21                 ` Ingo Molnar
2008-07-21 21:24                   ` Evgeniy Polyakov
2008-07-21 23:33                     ` David Miller
2008-07-22  7:50                       ` Ingo Molnar
2008-07-22 13:34                         ` Ingo Molnar
2008-07-23 22:31                           ` David Miller
2008-07-23 22:40                             ` Jeff Kirsher
2008-07-21 16:22           ` Christoph Lameter
2008-07-21 19:57             ` Evgeniy Polyakov
2008-07-21 20:05               ` Ingo Molnar
2008-07-21 20:22                 ` Vegard Nossum
2008-07-18 13:55   ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19f34abd0807180003m7bdf832g141777751d7ea563@mail.gmail.com \
    --to=vegard.nossum@gmail.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=netdev@vger.kernel.org \
    --cc=penberg@cs.helsinki.fi \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome