From: "Vegard Nossum" <vegard.nossum@gmail.com>
To: "Ingo Molnar" <mingo@elte.hu>
Cc: "Randy Dunlap" <randy.dunlap@oracle.com>,
lkml <linux-kernel@vger.kernel.org>,
vegardno@ifi.uio.no, penberg@cs.helsinki.fi,
akpm <akpm@linux-foundation.org>
Subject: Re: [PATCH -next] kmemcheck: include module.h to prevent warnings
Date: Sat, 26 Jul 2008 20:28:04 +0200 [thread overview]
Message-ID: <19f34abd0807261128k185110faxedd2a1d2a6078bfc@mail.gmail.com> (raw)
In-Reply-To: <20080726154346.GB15945@elte.hu>
On Sat, Jul 26, 2008 at 5:43 PM, Ingo Molnar <mingo@elte.hu> wrote:
>
> * Randy Dunlap <randy.dunlap@oracle.com> wrote:
>
>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>
>> kmemcheck/shadow.c needs to include <linux/module.h> to prevent
>> the following warnings:
>>
>> linux-next-20080724/arch/x86/mm/kmemcheck/shadow.c:64: warning : data definition has no type or storage class
>> linux-next-20080724/arch/x86/mm/kmemcheck/shadow.c:64: warning : type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
>> linux-next-20080724/arch/x86/mm/kmemcheck/shadow.c:64: warning : parameter names (without types) in function declaration
>
> applied to tip/kmemcheck - thanks Randy.
I am obviously also grateful for this patch. Thanks!
Vegard
--
"The animistic metaphor of the bug that maliciously sneaked in while
the programmer was not looking is intellectually dishonest as it
disguises that the error is the programmer's own creation."
-- E. W. Dijkstra, EWD1036
prev parent reply other threads:[~2008-07-26 18:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-24 23:09 Randy Dunlap
2008-07-24 23:27 ` Pekka Enberg
2008-07-26 15:43 ` Ingo Molnar
2008-07-26 18:28 ` Vegard Nossum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19f34abd0807261128k185110faxedd2a1d2a6078bfc@mail.gmail.com \
--to=vegard.nossum@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=penberg@cs.helsinki.fi \
--cc=randy.dunlap@oracle.com \
--cc=vegardno@ifi.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®