Re: latest -git: BUG: unable to handle kernel paging request (numaq_tsc_disable)

["Vegard Nossum" <vegard.nossum@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1517 bytes --]

On Wed, Aug 20, 2008 at 6:12 PM, Vegard Nossum <vegard.nossum@gmail.com> wrote:
> On Wed, Aug 20, 2008 at 5:40 PM, Vegard Nossum <vegard.nossum@gmail.com> wrote:
>> On Wed, Aug 20, 2008 at 5:28 PM, Vegard Nossum <vegard.nossum@gmail.com> wrote:
>>> Hi,
>>>
>>> This actually hardlocked my machine and I had to add an extra patch to
>>> get any output at all. Base version is latest git, commit
>>> 1fca25427482387689fa27594c992a961d98768f.
>>>
>>
>> ...
>>
>>> Booting processor 1/1 ip 6000
>>> <1>BUG: unable to handle kernel paging request at c08a45f0
>>> <1>IP: [<c08a45f0>] numaq_tsc_disable+0x0/0x40
>>> <0> [<c0678676>] ? init_intel+0x196/0x360
>>
>> Seems to be a section mismatch; init_intel() is __cpuinit while
>> numaq_tsc_disable() is __init. Seems to be introduced in:
>>
>> commit 64898a8bad8c94ad7a4bd5cc86b66edfbb081f4a
>> Author: Yinghai Lu <yhlu.kernel@gmail.com>
>> Date:   Sat Jul 19 18:01:16 2008 -0700
>>
>>    x86: extend and use x86_quirks to clean up NUMAQ code
>
> Oops, I am wrong about numaq_tsc_disable() being __init. Still, I
> believe that Yinghai might be able to say what's really wrong :-)

Err... No, I am confusing myself! I had already applied a patch to
change it to __cpuinit :-/

The good news is that the bug is now fixed. Patch attached.


Vegard

-- 
"The animistic metaphor of the bug that maliciously sneaked in while
the programmer was not looking is intellectually dishonest as it
disguises that the error is the programmer's own creation."
	-- E. W. Dijkstra, EWD1036

[-- Attachment #2: 0001-x86-numaq-fix-section-mismatch.patch --]
[-- Type: application/octet-stream, Size: 890 bytes --]

From dc2da937d5fb8934edd95a621895299a6185e1a2 Mon Sep 17 00:00:00 2001
From: Vegard Nossum <vegardno@ben.ifi.uio.no>
Date: Wed, 20 Aug 2008 18:15:21 +0200
Subject: [PATCH] x86/numaq: fix section mismatch

This section mismatch would lead to this crash:

BUG: unable to handle kernel paging request at c08a45f0
IP: [<c08a45f0>] numaq_tsc_disable+0x0/0x40

Cc: Yinghai Lu <yhlu.kernel@gmail.com>
Signed-off-by: Vegard Nossum <vegardno@ifi.uio.no>
---
 arch/x86/kernel/numaq_32.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/numaq_32.c b/arch/x86/kernel/numaq_32.c
index b8c4561..eecc8c1 100644
--- a/arch/x86/kernel/numaq_32.c
+++ b/arch/x86/kernel/numaq_32.c
@@ -73,7 +73,7 @@ static void __init smp_dump_qct(void)
 }
 
 
-void __init numaq_tsc_disable(void)
+void __cpuinit numaq_tsc_disable(void)
 {
 	if (!found_numaq)
 		return;
-- 
1.5.6.4