From: "Vegard Nossum" <vegard.nossum@gmail.com>
To: "Ingo Molnar" <mingo@elte.hu>
Cc: "Pekka Enberg" <penberg@cs.helsinki.fi>, linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] kmemcheck updates for tip/kmemcheck
Date: Mon, 8 Sep 2008 17:26:25 +0200 [thread overview]
Message-ID: <19f34abd0809080826s758a212x22f17e1836e27e2@mail.gmail.com> (raw)
In-Reply-To: <19f34abd0809080824k4dc5e4faq777f7fb3b5fe05fe@mail.gmail.com>
On Mon, Sep 8, 2008 at 5:24 PM, Vegard Nossum <vegard.nossum@gmail.com> wrote:
> On Mon, Sep 8, 2008 at 5:17 PM, Ingo Molnar <mingo@elte.hu> wrote:
>> +#if defined(CONFIG_SMP) && !defined(CONFIG_KMEMCHECK_USE_SMP)
>
> Should really be just:
>
> +#if defined(CONFIG_SMP)
>
> Can you amend?
Er, also written like:
+#ifdef CONFIG_SMP
Bonk.
Vegard
--
"The animistic metaphor of the bug that maliciously sneaked in while
the programmer was not looking is intellectually dishonest as it
disguises that the error is the programmer's own creation."
-- E. W. Dijkstra, EWD1036
next prev parent reply other threads:[~2008-09-08 15:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-07 20:09 Vegard Nossum
2008-09-08 15:17 ` Ingo Molnar
2008-09-08 15:24 ` Vegard Nossum
2008-09-08 15:26 ` Vegard Nossum [this message]
2008-09-08 17:08 ` Ingo Molnar
-- strict thread matches above, loose matches on Subject: below --
2008-08-29 21:19 Vegard Nossum
2008-09-06 17:16 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19f34abd0809080826s758a212x22f17e1836e27e2@mail.gmail.com \
--to=vegard.nossum@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®