From: Vegard Nossum <vegard.nossum@gmail.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Pekka Enberg <penberg@cs.helsinki.fi>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH] signals: don't copy siginfo_t on dequeue
Date: Thu, 26 Feb 2009 21:18:32 +0100 [thread overview]
Message-ID: <19f34abd0902261218u388de998l1204857bde9bbe32@mail.gmail.com> (raw)
In-Reply-To: <20090226191509.GA6204@redhat.com>
2009/2/26 Oleg Nesterov <oleg@redhat.com>:
> So. dequeue_signal() returns NULL if there is no siginfo queued. In that
> case we assume that the signal is not pending.
>
> But this is not right. Think about SEND_SIG_FORCED, or __sigqueue_alloc()
> failure when the signal is sent. Or look at zap_other_threads() for example,
> it just sets the bit in ->pending but doesn't queue siginfo.
I will investigate. Thanks for looking, and thanks for the pointers :-)
Vegard
--
"The animistic metaphor of the bug that maliciously sneaked in while
the programmer was not looking is intellectually dishonest as it
disguises that the error is the programmer's own creation."
-- E. W. Dijkstra, EWD1036
next prev parent reply other threads:[~2009-02-26 20:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-26 18:44 Vegard Nossum
2009-02-26 18:50 ` Ingo Molnar
2009-02-26 19:10 ` Vegard Nossum
2009-02-26 20:19 ` Oleg Nesterov
2009-02-26 20:27 ` Ingo Molnar
2009-02-26 19:15 ` Oleg Nesterov
2009-02-26 20:18 ` Vegard Nossum [this message]
2009-02-26 20:36 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19f34abd0902261218u388de998l1204857bde9bbe32@mail.gmail.com \
--to=vegard.nossum@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®