From: Vegard Nossum <vegard.nossum@gmail.com>
To: Eric Paris <eparis@redhat.com>
Cc: Jonathan Corbet <corbet@lwn.net>,
linux-kernel@vger.kernel.org, linus-fsdevel@vger.kernel.org,
viro@zeniv.linux.org.uk, hch@infradead.org, agruen@suse.de
Subject: Re: [PATCH 10/10] send events using read
Date: Wed, 4 Nov 2009 09:07:42 +0100 [thread overview]
Message-ID: <19f34abd0911040007i738bfc4eq5481b6c85117d525@mail.gmail.com> (raw)
In-Reply-To: <1257296148.2891.223.camel@dhcp231-106.rdu.redhat.com>
2009/11/4 Eric Paris <eparis@redhat.com>:
> On Tue, 2009-11-03 at 16:59 -0700, Jonathan Corbet wrote:
>> Hi, Eric,
>>
>> This is not a full review, but I did notice a problem as I was trying to
>> figure out the new API...
>
> This is a rip off of inotify which was introduced in commit 3632dee2f8b
> from Vegard Nossum back in January. I can't seem to find any discussion
> of this before it went into Linus' tree, so if someone knows how this
> patch got to Linus and what was said about it, I'd like to know. Thanks
> for unwittingly finding and inotify bug!
I don't have a git tree handy, but I think this is the locking
imbalance fix. It went to the security list, so that's probably why
you didn't find it. As far as I can tell, the code in question was
wrong even before that patch, though.
Vegard
prev parent reply other threads:[~2009-11-04 8:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-31 18:47 [PATCH 01/10] vfs: introduce FMODE_NONOTIFY Eric Paris
2009-10-31 18:47 ` [PATCH 02/10] fanotify: fscking all notification system Eric Paris
2009-11-06 15:31 ` Eric Paris
2009-11-06 15:54 ` Andreas Gruenbacher
2009-10-31 18:47 ` [PATCH 03/10] fanotify:drop notification if they exist in the outgoing queue Eric Paris
2009-10-31 18:47 ` [PATCH 04/10] fanotify: merge notification events with different masks Eric Paris
2009-10-31 18:47 ` [PATCH 05/10] fanotify: do not clone on merge unless needed Eric Paris
2009-10-31 18:47 ` [PATCH 06/10] fanotify: fanotify_init syscall declaration Eric Paris
2009-10-31 18:48 ` [PATCH 07/10] fanotify: fanotify_init syscall implementation Eric Paris
2009-10-31 18:48 ` [PATCH 08/10] fanotify: sys_fanotify_mark declartion Eric Paris
2009-10-31 18:48 ` [PATCH 09/10] fanotify: fanotify_mark syscall implementation Eric Paris
2009-10-31 18:48 ` [PATCH 10/10] send events using read Eric Paris
2009-11-03 23:59 ` Jonathan Corbet
2009-11-04 0:55 ` Eric Paris
2009-11-04 8:07 ` Vegard Nossum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19f34abd0911040007i738bfc4eq5481b6c85117d525@mail.gmail.com \
--to=vegard.nossum@gmail.com \
--cc=agruen@suse.de \
--cc=corbet@lwn.net \
--cc=eparis@redhat.com \
--cc=hch@infradead.org \
--cc=linus-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®