From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2FFBD2264A9 for ; Mon, 29 Dec 2025 10:19:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767003573; cv=none; b=l0jRzM+PHHybfLyURbD4qmDBemxML2eeHNsn7jjj9eXUckvHOMbX0O28MG79S29KGQPJI4q9tzSrPmIq1RPFQd4YtxiHYKGfmv+GB4uopU3nQRf1fc6X86Tn4W1fVGtbkW9Gbl5dAGNvpsiw0kehFUhtholvPOJnrMQMYKrGIqQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767003573; c=relaxed/simple; bh=bAlbsLq2CbFPJyLvOnaYwzljMRSxyhtx+g0Q0M0KB4w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NvbwI0g7sAZFN4eEeIxrLyzrmpwUzKd/Vaqam2vZGzJ7SYphmm4jhfLZtcnO9l6Nd7WdgFEx65dhuzjgfYW00J/RVBKr1M5EkJ1HZvz07qEkmwWriGaxZMPaOeVvMSSRZNKoMcnY2pOGFVekRKsY/5jfPMDKXiv0h6O0KL8HbdU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dfG0DGs3; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AzPMtbkF; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dfG0DGs3"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AzPMtbkF" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BSNrhH1123547 for ; Mon, 29 Dec 2025 10:19:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= yBrqNsep9SvRFRsP0TEHPmoDqVkS06GgAJCQ8yqPKEs=; b=dfG0DGs30+P4p9VZ i0KCZpvNpD0VKNYEkw/1DkD7kFdAF1Xg+E8kkMCCuqG5gvRRLT+A0g1BclbJ/aPn yth2ZbNj40U601V0xe/Fd1+DaOHYdL0dCZOE5M3g+VU2b/XiBiVwp2/pjygo07yR bAfdW3/dyg45gzvlONsU2fcmafWVPOrfgG4x6Iqv6MmujFlAb/WMtvM4qNoHUlua nHxwk87SLdJh35b2XShN7a6CuglSDJ5cRG6S5DLb+4q1c7/5MlbYz8GyY/EHnU6T SAhRoRB5aApxDiodJbciBGW2tSS3pyyv65uFVw0K3gIZ1SGgLu7lGrOXJaotBk4c 0fNoqg== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ba7u5m1n8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 29 Dec 2025 10:19:30 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-34aa1d06456so20782830a91.0 for ; Mon, 29 Dec 2025 02:19:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767003570; x=1767608370; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yBrqNsep9SvRFRsP0TEHPmoDqVkS06GgAJCQ8yqPKEs=; b=AzPMtbkF7Dj0pldLpqnbvs2ov/8ZL+rgBRFc69cK6FHawoH5yO+8R0ZBcevt5cBXD0 u1/o1yY5Xr7KnZO/POqfeIUnw4X2rR9EnYrVwlde9eWlJzlJu6baDEEz+fOCUQ02PaRV zqzn17lT1GzTkDk7TZfHpHOFQFc2ouSw3KzaS6iNwBBoVfuuRYx0V7ASsEExEG4Q8oFH XWPMbizOZhnGxFRp2H4npte1SgSNWlHuJqHOHwRkW9L7jAAKfbGe/z3y2mlIuUgvxyfX 7S1nTMCFeOvsYdPmpeIR0qfMOKRk+9kpsw5w1S++TOgG0pIxUPO+skLCTKuaEMgvgx67 aKqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767003570; x=1767608370; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yBrqNsep9SvRFRsP0TEHPmoDqVkS06GgAJCQ8yqPKEs=; b=cY74Dczu6d9FJha+UrDKOOidyRfeBrkxBnG3bDF2Vr3rVoXe5auB0+CHCugcjoJrSo QNvM/gdduqAc+ccsTUilckaRgcCv3a7QNcfL92b2iAFqr6LldXcvTKppRda5tT1e7VIE D/zLu849mTTQVzQMLRaP4Fl9dJ+YsDMb8AWq7QjX5AsO0HExBkzVQBs8KJ+N9xa24z9P RNucIClASuK0OzvxOPGXtcxqfrOpD2CTheMBrmZJ7eScU+5DOcPtMcxPe4sIgmoYgPCX u/nlny5mmYUE1m3WKqtVzrvCmVCeZHP7GpMDByXzyLBN6vscwb8vBZ5ZBxYkYc61j1lc Phhg== X-Forwarded-Encrypted: i=1; AJvYcCWC50Wc7F9mwNYYK4JbtRobri+PYjznFernS7cxpwsalkCl/pZEZ29skB4D8C3mzfzbpHtvCsPaSvkjgL0=@vger.kernel.org X-Gm-Message-State: AOJu0YyfNnHGclC1PukGRcOrhDDI+nDCHJE9xW7N/i1BwrbEwVFcysGQ VJMuYgZHlRxW3n5qH/tis7fVbC0gxLbpTQnEnml/tYX6I43C2vQa+KS7T5zMCXzP0ANds3gm/un CfVPu3Yi4jlxOZegA0gfuXZ/Ap8ZhYAfO1OXZ59vw1f+tWZJb66plE2hbrVbtZI/uogo= X-Gm-Gg: AY/fxX5l2dVCq15ojqpFfauWSuvuW/GJa6FeTucfnOmpg2rR5YvvVz4kF1+gU4THNY9 8JtdgXWcdzgbPoZYT8SSKT/sBb2BUGsIZ/QLqZj/dZro477bgqpeeyhuFg6wkFdhv+hDwRpRe71 xG1sHr19r3bzunt7Zle2SRo8jlrsV7HEF2bbhWumb4e4329OMz7byiTe+9cy3Ry8/qePVa7saio 4++QR7+LlATkjx7RCgEHLocRRMVGg8bgLlk049bQM964Vsmhp+WBbezn5eiuPAUD70WVD2krCYR 3qHS/uEiuqrendgkd7YfLAaBPeTl8koV/JFAFBOLVGxfDKfMJ5Alp7SnbWwfYTBcWwG158kxh4R xMDPKZKOfYtYC5y/LVNXqDedG+dilaZ1Wy9E8cToTXrcQCC2R9mkxjwf5p1YDLT8dS9Ac X-Received: by 2002:a17:90b:2585:b0:340:bb51:17eb with SMTP id 98e67ed59e1d1-34e92131db5mr27227369a91.15.1767003569831; Mon, 29 Dec 2025 02:19:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IGpI1tIheAK3Jc5YakDDEgyL6hZjQFrDx1wSiLJUOLGWDC/LzO6W44QB/3UCmbiVxqphTxoVA== X-Received: by 2002:a17:90b:2585:b0:340:bb51:17eb with SMTP id 98e67ed59e1d1-34e92131db5mr27227348a91.15.1767003569321; Mon, 29 Dec 2025 02:19:29 -0800 (PST) Received: from [10.133.33.5] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34e70dcc7bcsm29853573a91.13.2025.12.29.02.19.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Dec 2025 02:19:29 -0800 (PST) Message-ID: <19f46c69-fbfc-4129-98ae-fc5aef3f75eb@oss.qualcomm.com> Date: Mon, 29 Dec 2025 18:19:25 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] arm64: dts: qcom: Commonize IQ-X-IOT DTSI To: Krzysztof Kozlowski , YijieYang Cc: andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20251222-purwa-v1-0-14ab9316e5ff@oss.qualcomm.com> <20251222060335.3485729-3-yijie.yang@oss.qualcomm.com> <20251222-fluorescent-turkey-of-gallantry-df0906@quoll> <6421f044-2b07-4518-9edc-b9b2ef49f4fb@kernel.org> <8bcf058f-5bf9-46ce-a188-e94954101f2f@oss.qualcomm.com> <4f79d090-7d1c-4fb3-a835-a7e4ff96f79c@oss.qualcomm.com> <448f2efa-5b1e-4855-a62d-2e375938b36f@kernel.org> Content-Language: en-US From: Tingwei Zhang In-Reply-To: <448f2efa-5b1e-4855-a62d-2e375938b36f@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: ZVftQCELigxdIxqnxrirm3o1Mtw_2ugd X-Proofpoint-ORIG-GUID: ZVftQCELigxdIxqnxrirm3o1Mtw_2ugd X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjI5MDA5NSBTYWx0ZWRfX1uxWVffsLJYr omZX5UcM1OPlhn2bX9wWKNV4Ugm2ZZrMy9qe2q9EZ85x58WwZiiXyHimVOq/Y1ikn9vQBC4K5B/ Nbc2nmj57S3Odakx9cVR1eQ2MWdMQ3SoyEgrl+BwHp7sDzlGKp6lvi9MQqeW2Nq84CBhF35HUHu sMNUgOyyLTN2mM69AGJXMnAvu9952toXJSgtSYrhTDRSHxrTPa6OjEGMXnnePLr7NFoRm81TxPK dy/hNc5Wh7HiHa84S0KGulgwAhuMsJEzqSjD30+rZdQl+EXhlalZhFLkScqv5L/4wyMkzaLbOui PKraiE3s9FoaAJP8BudhAj8c3TG0BMf4KOEXf9MsDN/H8yQGTxCrMOhuIzidAMg1uJuY37YxuG6 xbIWZjr4E4JuDshBtyxwbWvcfXVvwrhQgrMAULhp7BdU9pQc8/x0POD0VbbmG4DQhiSgA8il3lh 561P9cvg4Wk1S+cyr8g== X-Authority-Analysis: v=2.4 cv=DptbOW/+ c=1 sm=1 tr=0 ts=695255b2 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=-EYVSfHI5QxSVCcxwr0A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-29_03,2025-12-29_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 clxscore=1015 spamscore=0 priorityscore=1501 suspectscore=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512290095 On 12/29/2025 3:21 PM, Krzysztof Kozlowski wrote: > On 29/12/2025 02:23, Tingwei Zhang wrote: >> >> On 12/24/2025 8:12 AM, Tingwei Zhang wrote: >>> On 12/23/2025 9:41 PM, Krzysztof Kozlowski wrote: >>>> On 23/12/2025 04:38, Tingwei Zhang wrote: >>>>> On 12/22/2025 5:11 PM, Krzysztof Kozlowski wrote: >>>>>> On Mon, Dec 22, 2025 at 02:03:28PM +0800, YijieYang wrote: >>>>>>> From: Yijie Yang >>>>>>> >>>>>>> HAMOA-IOT-EVK and PURWA-IOT-EVK share a similar board design. Extract >>>>>>> the common components into separate files for better maintainability. >>>>>> SoMs do not share actual hardware. DTSI does not represent what looks >>>>>> similar to you, but actually common parts. >>>>> Purwa SOM board and Hamoa SOM board share same design. They share same PCB. >>>>> The difference is only on chip. Purwa SOM board has Purwa and Hamoa SOM board >>>>> has Hamoa on it.  >>>> I do not speak about boards. Read carefully feedback and respond to the >>>> actual feedback, not some other arguments. >>>> >>>> NAK >>> In this change, the SoM hardware except SoC is described by iq-x-iot-som.dtsi since it's common between Hamoa and Purwa. Hamoa and Purwa SoC hardware is described in hamoa.dtsi and purwa.dtsi. Hamoa-iot-som.dtsi includes iq-x-iot-som.dtsi and hamoa.dtsi. This change could reduce the duplicate code and review effort on a totally new purwa-iot-som.dtsi. If we found any bug, it can be fixed in one common file instead of two separate files. Same idea is used in x1-crd.dtsi. X1e80100-crd.dts include x1-crd.dtsi and hamoa.dtsi. >> Krzysztof, >> Please let me know your opinion on this. This could be a common case for >> Hamoa/Purwa boards share same PCB. Share same dtsi file like x1-crd.dtsi > It's not the same PCB. You did not really respond to my first message, > so I responded to you - I do not speak about boards. Then again you did > not respond to it and brought some irrelevant arguments. > >> would reduce maintenance effort. > Does not matter, I do not question this. Why are you responding to some > questions which were never asked? > > DTSI represents actual shared physical aspect and you cannot share SoM > physically. It's not the same PCB, because you do not have a socket on > the SoM. I didn't make myself clear enough. The SOM PCB I referred here is just the circuit board excluding the components on it.  Let me rephrase. Hamoa and Purwa SOM boards have very similar hardware design. They share same circuit board and most the components on it. The only difference is Hamoa SOM board has Hamoa SoC while Purwa SOM board has Purwa SoC. I agree they are not same PCB since the SoCs are different.  However, I still think it's better to use common dtsi iq-x-iot-som.dtsi since their hardware design is very similar.  I'll invite Konrad to chime in here as author of x1-crd.dtsi and Qualcomm SoC maintainer. I think we are facing similar case on purwa evk and purwa crd. Align to same strategy for device tree topology would be good. > Best regards, > Krzysztof