From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f100.google.com (mail-yx1-f100.google.com [74.125.224.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 253EF4DB57F for ; Tue, 14 Jul 2026 16:54:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.100 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784048050; cv=none; b=lyxDDBfE7e8BfhtBpM9u5SuUU4BjWdQTdMZ40fgAYyoGQW17QSG00K2N6QCkMBVKOAuwBOnJKOk9hXkcaGe7sZJw9105zrXZGebPF7LBCAq1XTNsRQxiKOkLvyYffo7f1t9VSeab/fUgrQGS+STdHPtjjMkybGdCEOEb+P95RCs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784048050; c=relaxed/simple; bh=QpVWA5kBxLRil/3cTlurIa3Gg0zOcMLKe2INn1/y+4Q=; h=From:To:CC:Date:Message-ID:In-Reply-To:References:Subject: MIME-Version:Content-Type; b=Tnfdz0nJBk/dvOrVK+q+vKlnIZ+STe59nCiTG1eCVxiadOlI64oCvyi99LHVVriwyPM6y0hOqwP8A0WK41z2gdDsHNIgSHsOz8ufpvZjdPkBmb+Js6TRbdmgibfrfUV5HUlULJBvdmibcbDoH/4r+JDdywbFz2GrJUEasgHoSM0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=QBZ98Snf; arc=none smtp.client-ip=74.125.224.100 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="QBZ98Snf" Received: by mail-yx1-f100.google.com with SMTP id 956f58d0204a3-66771ded50aso6866879d50.1 for ; Tue, 14 Jul 2026 09:54:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784048048; x=1784652848; h=content-transfer-encoding:content-type:mime-version:subject :user-agent:references:in-reply-to:message-id:date:cc:to:from :dkim-signature:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ptG2LrgVCiWDRJ0AJb0FvkOQlNYFLwr7+eK1TRT2NT4=; b=dMVtmNltAZI+X8G67Cqk/HD7fK49uf2/YcJd9hsIbdg06458DRoZufQiYfQfzWETCF vWJJiCpLLPIA/9B0+UK0atWpmlFaiJ18G3u1KF6L/MFK9GJQ/5C8pSgYSmM3yuH4ttg9 bVWYOCV67Yz39jd0JCtK94aFBfCZ9rjGR6Jo3MmYC9cuoPFIMDumRtRGbdCGRnvjtDQb jJ+EfKSHR2c1lge/wSoseIormqZjqSD9OOEnHaoL7QAiA1vaRNXXaeGMxSnIYDLvf/nt 7qZ6pciUgx5VaVBQWLe6syDngn5NQYbrzM6UGi56l/z98X7Oo6fyqUvRGVsrH7hT99bX PVGA== X-Forwarded-Encrypted: i=1; AHgh+RpKDwL50/X41boqBPtx5Ji8R+29tG6VTr+/oCIg/hpVlrz7vlq5XVpHGYFOjfco+hZPozWJlziWHNpxkjI=@vger.kernel.org X-Gm-Message-State: AOJu0YyqfpY2gRn6G9Fpp5hNRpTDLx5JPWVK7EHSQLvAPJkReS1XEgDZ z0y3UsDZLHdUw0Ys4H+loMlCzC3b8wtleFL8LbxKkuxqtvKMrHlKyVgwvmXRDdUUw2t6xrzm6Ve D7szgl1ZUH++n209G7UduOmAalV9CqlWXkF7aQ3bMslsR7/yCzpGbmDFNeY37P9bahNmhHhN8ST yG4M/CUzrPE0viyezYamURbnE5FcFKXBJ7qtST0Lza1Yk7YL5WJlDnNu6/Ih8UX8AEcGLCxpbYf yuuhVpo7l6BJaVH3izYUoXsQw== X-Gm-Gg: AfdE7cll1WWXQlkaBHuCnzP5k5c8tYulY+12OnR2DjPioH/eK5WcCtMqbqu6Ckk03pa XfLWr6jR/hd/NumNBaXrFq05/pFNJgSjH3Tc+U3ApTFsIwm2fgP4efb/vlLBjlpbQF59UBMTPwQ l8DyzGIHYZvDMgb/Q7CZAj7G3tWXrcmtbTvDQBawHUTg4rOcctyhMBsY5AJ1Z2po4e4NPoqjMUP Ayeu33R/NRTzMtRjQA3XzPgj2qFkImDsJmeGlhjmNIhQBalgrebYOaR+hyDnw+KrgE/WrAsKiC/ 6PD8Vgy3TPLFSwt7/XfuHPpXXuyMxOieEJ9p0yB+xoA9JHfv261QwHIfg6fL980S/Fq6r1ggtST AJDvIVz8YgqEDv5mhTr7vxnBB4kvTsvl1dRRCp3CMVTr/mkbD1VwiQC3TIFBcyHN8CduvWy5u1k iQ5gzHTxsRoEU0ykOeLhy9ypiprQMZHeuvicK6cX3Bo0Wc+pO9BpfB X-Received: by 2002:a05:690e:1447:b0:667:c0f0:6072 with SMTP id 956f58d0204a3-667d7b3a656mr9791590d50.26.1784048047919; Tue, 14 Jul 2026 09:54:07 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-117.dlp.protect.broadcom.com. [144.49.247.117]) by smtp-relay.gmail.com with ESMTPS id 956f58d0204a3-667874ca5b5sm1190291d50.0.2026.07.14.09.54.07 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Jul 2026 09:54:07 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-c11f2b9f62fso95477266b.2 for ; Tue, 14 Jul 2026 09:54:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1784048046; x=1784652846; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:subject :user-agent:references:in-reply-to:message-id:date:cc:to:from:from :to:cc:subject:date:message-id:reply-to:content-type; bh=ptG2LrgVCiWDRJ0AJb0FvkOQlNYFLwr7+eK1TRT2NT4=; b=QBZ98Snf/9Zq+wjlsGCHqvUCptOX/VPFbqXKc+lrvYZA/hBdG1/j28NQpPafUFgvq3 fm5YFTH2mQ0xiUX/Qc9CBoZhDQ2rOsOMGFuNNs5GM4uPbIs822kbvjL1T/2Hc+c9GITc VRjEv7trb6z6EZoBt/mjMNx4WpfhU7HSLI0qA= X-Forwarded-Encrypted: i=1; AHgh+RpcUVPIhfTucOENcnkNlPWM6oMrFwV89G/26LRcSfXAOyI2Fvo5R8L+EW6MKVFSs9AW3M1m7QskimhcplM=@vger.kernel.org X-Received: by 2002:a17:907:6e86:b0:c12:4c5b:f170 with SMTP id a640c23a62f3a-c161f469872mr712371066b.62.1784048046305; Tue, 14 Jul 2026 09:54:06 -0700 (PDT) X-Received: by 2002:a17:907:6e86:b0:c12:4c5b:f170 with SMTP id a640c23a62f3a-c161f469872mr712367266b.62.1784048045367; Tue, 14 Jul 2026 09:54:05 -0700 (PDT) Received: from [100.98.74.8] ([109.37.130.223]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c15db22ed68sm890052966b.35.2026.07.14.09.54.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jul 2026 09:54:04 -0700 (PDT) From: Arend van Spriel To: Gokul Sivakumar CC: LiangCheng Wang , Kalle Valo , Angus Ainslie , Wig Cheng , , , , , , Date: Tue, 14 Jul 2026 18:54:04 +0200 Message-ID: <19f618cc7e0.2873.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> In-Reply-To: References: <20260713-b43752-f2-blksz-v1-1-8697fcfeaef4@gmail.com> <36f4388a-b856-438c-8ef4-795a7b1eda3e@broadcom.com> User-Agent: AquaMail/1.59.0 (build: 105900627) Subject: Re: [PATCH] wifi: brcmfmac: set F2 blocksize to 256 for BCM43752 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="us-ascii" Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Op 13 juli 2026 13:52:28 schreef Gokul Sivakumar : > On 07/13, Arend van Spriel wrote: >> On 13/07/2026 10:50, LiangCheng Wang wrote: >>> The BCM43752 is not reliable with the default 512-byte SDIO function 2 >>> block size: on an i.MX8MP board with an AMPAK AP6275S module at >>> SDR104 / 200 MHz, an iperf TX stress test kills WLAN within seconds: >>> >>> mmc_submit_one: CMD53 sg block write failed -84 >>> brcmf_sdio_dpc: failed backplane access over SDIO, halting operation >>> >>> Commit d2587c57ffd8 ("brcmfmac: add 43752 SDIO ids and initialization") >>> set up the 43752 like the 4373 for the F2 watermark but missed the F2 >>> block size, which the 4373 limits to 256 bytes. The vendor driver >>> (bcmdhd) also programs a 256-byte F2 block size for this chip and runs >>> the same hardware without errors. >>> >>> Group the 43752 with the 4373, matching the F2 watermark handling. >>> With this change a 10-minute bidirectional iperf3 soak completes with >>> zero SDIO errors at ~270 Mbit/s in each direction. >>> >>> Fixes: d2587c57ffd8 ("brcmfmac: add 43752 SDIO ids and initialization") >>> Cc: stable@vger.kernel.org # <= 6.16 needs the CYPRESS_43752 id name >> >> Looks good to me but the stable instruction looks confusion. What do you >> mean. If there is no 43752 support there is no need for this patch, right? > > Arend, one year back, from Infineon we had submitted a patch [1] to correct > the vendor ownership of 43752. i.e, SDIO_DEVICE_ID_BROADCOM_CYPRESS_4373 got > replaced with SDIO_DEVICE_ID_BROADCOM_43752. > > So in the older kernel versions like v6.16.x which does not have patch [1], > the 43752 support exists, but with SDIO_DEVICE_ID_BROADCOM_CYPRESS_43752. > So his instruction is to, again replace SDIO_DEVICE_ID_BROADCOM_4373 with > SDIO_DEVICE_ID_BROADCOM_CYPRESS_43752 in his patch [2] while cherry-picking > to the older stable trees. > > Rather than that, I would suggest to cherry-pick both the patches [1] & [2] > to stable trees, since the new patch [2] is dependent on existing patch [1]. Agreed. Thanks for your guidance. Regards, Arend > > [1] > https://lore.kernel.org/linux-wireless/20250724101136.6691-1-gokulkumar.sivakumar@infineon.com/ > [2] > https://lore.kernel.org/linux-wireless/20260713-b43752-f2-blksz-v1-1-8697fcfeaef4@gmail.com/ > > Gokul > >>> Signed-off-by: LiangCheng Wang >>> ---