From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f227.google.com (mail-pg1-f227.google.com [209.85.215.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A87904D98FA for ; Tue, 14 Jul 2026 17:03:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.227 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784048598; cv=none; b=grUkr664VHaw5OIV9hJwdvQX4b36/3hufThqvvLttuaCRp4VTwqJcIqujDfcJwzJsC1ZDXqmdGkW+TbOYVhHfAH2akj2UAQ72/PrBgRTNgLl6E/2xJI3qLBvAMq0EGu60kDK8bRCBTpZKjyJkZo8R8TImj+oIYhBLYGOuBJZZOs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784048598; c=relaxed/simple; bh=RrM+CrO/r8o7FGUOsnl8gZr1EiYzoxDBKu+JkNQEhU4=; h=From:To:CC:Date:Message-ID:In-Reply-To:References:Subject: MIME-Version:Content-Type; b=SVrWjJyY9XBnCPyWHhIrH/t1DdDzm6wIb5qvdLicNuwmSkrPtpzn1GRV08l+wZdiPGiIIi6GUXFh0oP3f/+86bZGhYpkF23WXFjdRQqMnl9es2l81tzi0XKPl8K8wBUfEcJ2dh72JaPVNYpJMPa+MYjL95XssWuBL2WxiRfgOO8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=euuod8Fq; arc=none smtp.client-ip=209.85.215.227 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="euuod8Fq" Received: by mail-pg1-f227.google.com with SMTP id 41be03b00d2f7-c9e7391839cso1100250a12.0 for ; Tue, 14 Jul 2026 10:03:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784048597; x=1784653397; h=content-transfer-encoding:content-type:mime-version:subject :user-agent:references:in-reply-to:message-id:date:cc:to:from :dkim-signature:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=W3XaKw1mZ5safaShnh8fqMEdlQ2rL6BwLt+Z3QDeOIY=; b=HAEnwH7jpjK3ekknIWFavIKdhCE1nhvUHqUJmbkKs4ZjZI7W9NswqxD/FeIiBw+oA4 YtBndUEyQarN+N9WwBaW8gzp3k11gnaXqCqF4iQAXIehrOKIL1fEFzir/Q4xuuMbfDyi lVbOmY6Z4djSejm5dGRAlmXM4AKynWUaCHhtmFzta0pwBNm+efEr+pWu7t0cxNet1EYu qbCrUap1xy7QIh+7Pe3tmMx89BYNY+4Vp8/tkkFdyY5keWaXq8qLxE2meni2Nh2PvLL9 XmSW3OgDvriUzqEAO3moksE6e0oMWZaMomIdJR9kbGq/u27lkvb5ij+jP4gqKyjFd7Go tD1A== X-Forwarded-Encrypted: i=1; AHgh+RrNz/Wqp0s1zqvl7LjMG1P9eef9AbaBOW99f6uoRwKwma2XC4FpDqOLAQ6Y5EBOd6omWQr9HXdcW83svn0=@vger.kernel.org X-Gm-Message-State: AOJu0YwEaV7Dzp5Ix9o6upVlQ9KvbEijL9RFj3cMRkcLEsR8+4OwGgfB k4pxgtSwH62V8n6vYHTulwbmbJUJEpqLx4qDu0jAT6r6QAYkpPCOpKAoj91mJRpOwKR4kiodw7D sI8iTOj7lOPboZq2PIjbyc259Mry14C8YKGIr90Sxnld3qreybXQErahcqibIDDS8fm73TCZO82 2pBePmhxBje2mINH7G629VAPmJNKlc7xxAwLIxQSxkANXtoP8+lgt8OmkO8l6jV42JFVrM6YFP2 f4oiflvBr2FcfETDVPBTvE19w== X-Gm-Gg: AfdE7cmDqyKeMrC69CaDXvx1E76bfaMXqrTXkM8/IrYZF9XEJvoxJr92dVSNPh/bUg8 dV6awOmeh5H2fOHnvK4t8pK8a2sPg0Z3s9Aie5OfZSrmOp8u1yKWMB4ZuvYJfnGNcznF/hsGz8s CMZ/n/qWEIm1zEzyio2P8J0xkd1h+0ugM/1Zcw1Oah1C5yM2UeT1aYQcJBKN5rdykwsA3Tw65K/ lkuLX2YCPhk4sWXbvi5JOHkm0hMObAi77e7vtyY9MBcsJSfWYRRcaYq0iXS8LwiURQ3JqbiSTF5 g51PQzmgzrZ18VcSb2gSXI2A7cs9qzHuq+iOFFB62JuV+OkdE50mEe2Mp0d1jf2Uhh4v9700YeP ia+5hxK7xWf72HKvNcD6gx/G4A/sJOE7eQoPB27OEBB0wDcbcoeZMkphr+AfJA1JxUCX4QiO0lH faNt2Y/TBzF61ra9Pqoua6AsSIv/uRsIKxckanZqFywcKbtSKlHMIb X-Received: by 2002:a05:6a21:4606:b0:3bf:6c08:2848 with SMTP id adf61e73a8af0-3c1108c1c8amr15803121637.55.1784048596747; Tue, 14 Jul 2026 10:03:16 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-117.dlp.protect.broadcom.com. [144.49.247.117]) by smtp-relay.gmail.com with ESMTPS id 41be03b00d2f7-cb2517fda32sm4752a12.7.2026.07.14.10.03.16 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Jul 2026 10:03:16 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-c15b8701fe4so237894566b.2 for ; Tue, 14 Jul 2026 10:03:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1784048594; x=1784653394; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:subject :user-agent:references:in-reply-to:message-id:date:cc:to:from:from :to:cc:subject:date:message-id:reply-to:content-type; bh=W3XaKw1mZ5safaShnh8fqMEdlQ2rL6BwLt+Z3QDeOIY=; b=euuod8Fqcfp8ICKefFJ9ybVoubYd7r5xnu/Dg4cfK3jG/3XBZ9yz56iRluKr5vx3pC dT11B2mAyJpdA/K7r/T7Lu2AmbbxLl+tEHCTXZZ7kZWHXnYfAEAfs7rA360nt8i5QW1I VAnFdJ/Whmtriyt4IfE+Wbsam3dXWXxT70Eag= X-Forwarded-Encrypted: i=1; AHgh+RrfpshVewOhm8tZv15v+AtSC96A6XLZtTD4+j21F82+dEXRTd7kmf85ZSZelBI0RcTHC6z/xAX0jIALmdo=@vger.kernel.org X-Received: by 2002:a17:907:8e11:b0:c16:5b2e:f972 with SMTP id a640c23a62f3a-c165b2eff60mr300352666b.53.1784048594374; Tue, 14 Jul 2026 10:03:14 -0700 (PDT) X-Received: by 2002:a17:907:8e11:b0:c16:5b2e:f972 with SMTP id a640c23a62f3a-c165b2eff60mr300349566b.53.1784048593952; Tue, 14 Jul 2026 10:03:13 -0700 (PDT) Received: from [100.98.74.8] ([109.37.130.223]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c15b7561db1sm1136622566b.12.2026.07.14.10.03.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jul 2026 10:03:13 -0700 (PDT) From: Arend van Spriel To: LiangCheng Wang , Gokul Sivakumar CC: Kalle Valo , Angus Ainslie , Wig Cheng , , , , , , Date: Tue, 14 Jul 2026 19:03:13 +0200 Message-ID: <19f61952868.2873.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> In-Reply-To: <20260714022859.1849447-1-zaq14760@gmail.com> References: <20260713-b43752-f2-blksz-v1-1-8697fcfeaef4@gmail.com> <36f4388a-b856-438c-8ef4-795a7b1eda3e@broadcom.com> <20260714022859.1849447-1-zaq14760@gmail.com> User-Agent: AquaMail/1.59.0 (build: 105900627) Subject: Re: [PATCH] wifi: brcmfmac: set F2 blocksize to 256 for BCM43752 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="us-ascii" Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Op 14 juli 2026 04:29:16 schreef LiangCheng Wang : > Hi Arend, > > On 13/07/2026 12:51, Arend van Spriel wrote: >> Looks good to me but the stable instruction looks confusion. What do you >> mean. If there is no 43752 support there is no need for this patch, right? > > Thank you for the review, and thanks Gokul for the detailed > explanation - that is exactly what I meant, and sorry the annotation > was not clearer. To summarize: 43752 support has been present since > v5.15 (commit d2587c57ffd8 ("brcmfmac: add 43752 SDIO ids and > initialization")), under the SDIO_DEVICE_ID_BROADCOM_CYPRESS_43752 id > name. Commit 74e2ef72bd4b ("wifi: brcmfmac: fix 43752 SDIO FWVID > incorrectly labelled as Cypress (CYW)"), which landed in v6.18, > renamed it to SDIO_DEVICE_ID_BROADCOM_43752. > > I also have to correct myself here: the boundary in the annotation > should have been "<= 6.17" rather than "<= 6.16", since the rename > only landed in v6.18. Apologies for the extra confusion. > > Gokul's suggestion of cherry-picking the rename patch together with > this one into the stable trees sounds cleaner to me than editing the > id name while backporting, so I would be glad to go with that. > > If it helps, I would be happy to send a v2 with the stable annotation > in the prerequisite format from > Documentation/process/stable-kernel-rules.rst: > > Cc: # 74e2ef72bd4b: wifi: brcmfmac: fix 43752 SDIO > FWVID incorrectly labelled as Cypress (CYW) > > Please let me know if you would prefer that, or if the patch is fine > to take as is. Cc: instructions to stable should stick to the stable-kernel-rules format if possible. I suspect there is a bit of scripting sifting through it. Regards, Arend > Best regards, > LiangCheng