From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f97.google.com (mail-pj1-f97.google.com [209.85.216.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 777BF364935 for ; Fri, 7 Aug 2026 16:52:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.97 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786121532; cv=none; b=aQpFKcvQ1zdXQUcTXCyug8Q8q4xe99Tu3bGkiQJdJ/E1xzAvSMP/INrm0qBcWR8TaEtnnmMsLQk6Zv3mIGGBitAqpL8NBq2Ke6Bse4U5G+b/HVUBRJuSeW6MrUIKgsp3s45d1wT7izcPfNzc87HQ7SMvCwQ9QrCnlh7kVcAnr+I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786121532; c=relaxed/simple; bh=O58BTvrNM2aC7RLe/NA9M4KfX96TgIfxhat39lMlpy0=; h=From:To:CC:Date:Message-ID:In-Reply-To:References:Subject: MIME-Version:Content-Type; b=mLFh9UIcXX9PZLg8VuJWc/cvUVPneV2Ssbn36RRm9fEJ2nux3+k/tDHKimfyyeTotCK8fLhoUc4s5a7BGtFUXJjNFXxCHi++TVzHlaOSY0GUCUo37k2LoIGrocS6bdQCYU2ESaYZn2So6uQ5liKUJMZR+xiq0Z6o86ARZXKZpI8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=e4hUl3Fe; arc=none smtp.client-ip=209.85.216.97 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="e4hUl3Fe" Received: by mail-pj1-f97.google.com with SMTP id 98e67ed59e1d1-38f0f132f56so1820180a91.0 for ; Fri, 07 Aug 2026 09:52:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786121531; x=1786726331; h=content-transfer-encoding:content-type:mime-version:subject :user-agent:references:in-reply-to:message-id:date:cc:to:from :dkim-signature:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=sK4XYhySCSAmfEvjmTkEI+hN3CX6qZ07+OcZw718arQ=; b=sCdGVjJPcB5/hCMMDW1/Gi0eqwi1Ol9SPgxwbrhdcRxk74zMbyOu2dprlQVRZaUw6K QjfMYNKxpS3UMUQ3GIHnFLLQmkoV22goKrq/XJ1Iw1oSzGB900MzJPCVK9wup+iIDJGY yY1iRL1q1CvIR6TlO8dcA9uH8ih1ngt0SlprpkxmnsNnKKT/D0pKwAJvv7UGwgUU+B7w iMb6OENDzQiI65xZjAjV71XvH04XSvVG3yZV+oSRDVrWJPKzFFiiKvofS227tpnGXSH7 DAh9WJi648zYsafkqndfXRu9ppf02NOhIZKHRtoGS2/vPMziwxE0AWn5XKjNPpen63Hf zWWQ== X-Forwarded-Encrypted: i=1; AHgh+Rr980NzfNQt5CO+Rat7OrMQel90OUc6dxuDScScUjg+gJlsyuGVEZ2oGrlgi6Zy+bbTQZejIe9rCgNkUVs=@vger.kernel.org X-Gm-Message-State: AOJu0YwlyNdeKDFV4E9vrxR5eE7HUmn0hufYw3PtKruHAgWPo+AsT8je Bf53BlOk2R1bKhhbDdvXjQfW0bcOmOjL4LjZhZUC0PotK8LtO0XYEnn6cG2bf2gI4zDiBVqL/dz TdZPiqF2RK6c86gP+k6FQ39DOAPWsfVU8uZJjlSM4IsjwCp/kH8CjFswBGalwL6AtSes+mUsEw8 4jbVnQjvnytY7uBZupXkX2ItbzvnVaER1IHxZolSQWDhE2F1oAxMAdOzbsTPFO5lgRszZYR1NVz A1xvPR49HuIge9ctg0t/+sEhw== X-Gm-Gg: AR+sD11PeVdAcbvSkGpwQ8hqvX8aFnXrfr96JNThrvme89HkcsvNrqxnlrnZTO2S5O6 3/scLq5xEOFjR9mmFCg//aRrv2m0md2d3rmXtCAMBTuNTga3rsBD5h8KuIeDAjVX0fW7t0zLuCk BE1e/5f8pPnt8MhsL41DnaNDB6vWnaAtqU7T3T0gdtZBoA5lNz0wLKfrnJOUo4V7VA+39PZb+eS SN8sv+CXgqlrXhmY8bdXBXVz2J+l4n5WSxA8RZtt0/nvjJzbqnVttApkqbCILhuPkhpPwQvQ2kW 8JvJpvIWwS4DF2bUVnKPhPYSEKCUhabw2CjaxAli3ZTYGsxR1cZ7ya+RQ+ET6rlqe08k+1F0DV2 XazORx1WJgLbgInV5Tnnv58Q3+iA6SxucuJPIl285lwDv/ln8TrfS/3QePB5B//BKi32Ft9VsmD UsOoTymBnuj9ri1NMbodTM5iM0ti24oteboLvJExI= X-Received: by 2002:a17:90a:f950:b0:38f:a81:15b1 with SMTP id 98e67ed59e1d1-39083b4baa0mr9016354a91.19.1786121530710; Fri, 07 Aug 2026 09:52:10 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-20.dlp.protect.broadcom.com. [144.49.247.20]) by smtp-relay.gmail.com with ESMTPS id a92af1059eb24-141018c2abcsm308899c88.0.2026.08.07.09.52.10 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Aug 2026 09:52:10 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2ccb6f6a3f4so36272955ad.1 for ; Fri, 07 Aug 2026 09:52:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1786121528; x=1786726328; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:subject :user-agent:references:in-reply-to:message-id:date:cc:to:from:from :to:cc:subject:date:message-id:reply-to:content-type; bh=sK4XYhySCSAmfEvjmTkEI+hN3CX6qZ07+OcZw718arQ=; b=e4hUl3FejJZoFo0SiVH25+eT/u0KfMe4x9RBNhPQc078ZfBxgf60PXCGQku5zhmH7c 8vSUiezD4MKui6jx8D9M6LIKNLGCrjQ8rz9CRXhbQ/rThUnUNyES8DP8VsVSMn//iT9a htNC9K8z1SF/UeAEmE7VyRAozGq2K0LT5XYVs= X-Forwarded-Encrypted: i=1; AHgh+RpsfH+LUntr53WczobSd1XIzFwvfnKIsIm/6coP8cGQbrZ8UA948fysa/NKSFNC71V8OZ+4kKUwOUKJHwc=@vger.kernel.org X-Received: by 2002:a17:903:2289:b0:2d2:72b6:556b with SMTP id d9443c01a7336-2d2b2e9258fmr175735ad.13.1786121528511; Fri, 07 Aug 2026 09:52:08 -0700 (PDT) X-Received: by 2002:a17:903:2289:b0:2d2:72b6:556b with SMTP id d9443c01a7336-2d2b2e9258fmr175115ad.13.1786121528066; Fri, 07 Aug 2026 09:52:08 -0700 (PDT) Received: from [10.229.40.14] ([192.19.176.227]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-315bec2ec20sm10580276eec.28.2026.08.07.09.52.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Aug 2026 09:52:07 -0700 (PDT) From: Arend van Spriel To: Bogdan Nicolae CC: , , , , Date: Fri, 07 Aug 2026 18:52:03 +0200 Message-ID: <19fdd238f38.2873.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> In-Reply-To: <20260807163418.487508-1-bogdan.nicolae@gmail.com> References: <20260807163418.487508-1-bogdan.nicolae@gmail.com> User-Agent: AquaMail/2.6.0 (build: 200600043) Subject: Re: [PATCH v6] wifi: brcmfmac: cyw: pass PMKID to firmware if present Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="us-ascii" Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Op 7 augustus 2026 18:37:48 schreef Bogdan Nicolae : > Zero out auth_status on initialization. Otherwise, garbage will > leak from the stack to the firmware (when ssid is less than 32 bytes > and/or when params->pmkid is set). Then, pass the params->pmkid to the > firmware (without it, the firmware caches a garbage PMKID on successful > authentication and denies a subsequent association request that includes > the PMKID). > > Fixes: 66f909308a7c ("wifi: brcmfmac: cyw: support external SAE > authentication in station mode") > Signed-off-by: Bogdan Nicolae > Acked-by: Arend van Spriel Hi Bogdan, Looks good so my Acked-by: still stands. Thanks for going with the flow. Regards, Arend > --- > v6: Fixed diff line number > v5: Fixed line length > 80 chars > v4: Fixed indentation > v3: Added Fixes, Cc: stable, and Acked-by tags > v2: Split into a separate patch > > drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/core.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-)