From: Andreas Ziegler <andreas.ziegler@fau.de>
To: Markus Mayer <mmayer@broadcom.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>, linux-pm@vger.kernel.org
Subject: Re: [PATCH v3] cpufreq: brcmstb-cpufreq: CPUfreq driver for older Broadcom STB SoCs
Date: Mon, 28 Nov 2016 10:33:28 +0100 [thread overview]
Message-ID: <19fea35d-98de-2367-96c8-101d34aa93d8@fau.de> (raw)
In-Reply-To: <5995ce7b-6a00-8944-a8b9-b256abf4d92e@fau.de>
Forgot to CC linux-kernel and linux-pm in my first message.
On 11/28/2016 10:28, Andreas Ziegler wrote:
> Hi Markus,
>
> your patch "cpufreq: brcmstb-cpufreq: CPUfreq driver for older Broadcom STB
> SoCs" showed up in linux-next today, and I noticed a small error in it.
>
> In drivers/cpufreq/brcmstb-cpufreq.c, line 214 there is an IS_ENABLED()
> statement with CONFIG_ARM_BRCM_AVS_CPUFREQ. This symbol, however, does not exist
> - making the if condition always evaluate to false. Did you mean to use
> CONFIG_ARM_BRCMSTB_AVS_CPUFREQ (note the STB after BRCM)?
>
> I noticed this mistake by running 'scripts/checkkconfigsymbols -f --force -f
> next-20161124..next-20161128', which essentialy diffs the last two
> linux-next releases and looks for undefined/unknown Kconfig symbols.
> You can also run the script on single commits with -c to test them.
>
> Best regards,
>
> Andreas
>
next parent reply other threads:[~2016-11-28 9:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5995ce7b-6a00-8944-a8b9-b256abf4d92e@fau.de>
2016-11-28 9:33 ` Andreas Ziegler [this message]
2016-11-22 21:32 Markus Mayer
2016-11-28 10:14 ` Arnd Bergmann
2016-11-28 13:29 ` Rafael J. Wysocki
2016-11-28 17:12 ` Markus Mayer
2016-11-28 20:58 ` Arnd Bergmann
2016-11-28 21:07 ` Markus Mayer
2016-12-02 0:50 ` Markus Mayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19fea35d-98de-2367-96c8-101d34aa93d8@fau.de \
--to=andreas.ziegler@fau.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mmayer@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®