Re: [PATCH] usb: dwc3: core: clarify usb-phy array binding

[Kumar Gala <galak@codeaurora.org>]

On Aug 9, 2013, at 11:28 AM, Mark Rutland wrote:

> On Fri, Aug 09, 2013 at 04:40:32PM +0100, Kumar Gala wrote:
>> The binding spec wasn't clear that the order of the phandles in the
>> usb-phy array has meaning.  Clarify this point in the binding that
>> it should be <USB2-HS-PHY, USB3-SS-PHY>.
>> 
>> Signed-off-by: Kumar Gala <galak@codeaurora.org>
>> ---
>> Documentation/devicetree/bindings/usb/dwc3.txt | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>> 
>> diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt
>> index 7a95c65..8a9770b 100644
>> --- a/Documentation/devicetree/bindings/usb/dwc3.txt
>> +++ b/Documentation/devicetree/bindings/usb/dwc3.txt
>> @@ -6,7 +6,9 @@ Required properties:
>>  - compatible: must be "synopsys,dwc3"
>>  - reg : Address and length of the register set for the device
>>  - interrupts: Interrupts used by the dwc3 controller.
>> - - usb-phy : array of phandle for the PHY device
>> + - usb-phy : array of phandle for the PHY device.  The first element
>> +   in the array is expected to be a handle to the USB2/HS PHY and
>> +   the second element is expected to be a handle to the USB3/SS PHY
> 
> Just to check - it's not valid to have a USB3 phy without a USB2 phy?

Don't know, hopefully Felipe will chime in on that.

- k

--
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation