From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A84BF3FD157 for ; Tue, 28 Apr 2026 12:08:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777378135; cv=none; b=MNT2eNvriIFkBP9f59Rv9U+garqqdN1wHS+TRGJWuoHkMa31F+q33BiNPRGY1hBItDuJaJdVnNOe1lwyWE/lRmf+pmvhNNuC7ZIrYQh8Q1NUvrkr9BEW8X9Fglv8Z9HMguL1+0raiCEWaCcrwFzgt7SLgejGOTgY7NcducdBwGA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777378135; c=relaxed/simple; bh=xOhWPcwO2wN6l/nn57ba9S9CEWCXh7DmXlEixifjiQk=; h=Date:From:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=Vz5WT2qXChHo0Dh5aPlTxGO4XYLZurEQdRwibhpeTBeZD7FMexIb2jHqwc+vOWUzUjqUK0Zveq739mcQyuIztt9b/ukenaUmazwhCMag2qe3Beuf1NQ5cimets0CLm7wliE92EkA8mX1Nw4Q4E5v361CU4wm5x9O8Ss7N5BWEuA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AbvFR3IU; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AbvFR3IU" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-82d0b68837aso6746201b3a.2 for ; Tue, 28 Apr 2026 05:08:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777378130; x=1777982930; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=1ECW+0bs502uiqVG6Y4a6wbsseWKAdQ8DxJiILAPJZI=; b=AbvFR3IUAnzA2YRKFMDcbJp/CKpaWpLkUljltjn7FjYgXatlyqhrw14VoYIpNUQxSv bfjazvX8V3FT9huI7Pz+FxlI8hfDg/uDMHFy8eeKC7gUA4NE4itxmuyZyvpTgMeiZMJE X2AUOI/5zgtUTUmhfzhEG5sKpAxgg95GX9nBze11r8ZLSEJSXWoXQ8wPi8yVn8KCn1Oc foACTs1PGBSgncNrAsN/yKxtoVxo0/nWpEjrjntwN6MnmcOIuzrp+pn61dg+z83X3kmi uo1TCfuDADO6jFIHYI1Rkg3eYrH3MtqMeeJqVGU5ne/DTop0za4tlti+EIt//XQwliqK U7Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777378130; x=1777982930; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1ECW+0bs502uiqVG6Y4a6wbsseWKAdQ8DxJiILAPJZI=; b=LBnVmZ+z5bMeBASi+ygA53lCrK1xUsCNyk8+L7NOIFSNwPSewgQgtwIYNsmZOB7KDc j4PBX6jiyZ10aTUYHl2ewwErae2W8mrqVMCEvfR5PXaYrX6wi9dpX2TYF/4uHrRlMVl0 7R5D+i9Ce+g4oMlg12NJKvrrynEyivLaHYz7bJU2Lo/LRIs4aeuS8EEmROtbPjXOd96a LhpxBg8hb6QtP3YKqSSjVWElZIq/MXDLKrrIWzRwRbDuMJMGlJPlr666hqYkbCoIFyPt gWmXbl2YznBgy+Tyg45ktWjp7cDqWUUewYj1keB/lcRnySKp3Ic1f2j6N7QeM7zjaDhh JO6g== X-Forwarded-Encrypted: i=1; AFNElJ+nTAVRhkwnmnqPv/c5iopmH58XZ2M0glX0qznef7rXiPORHFLM8YADr6otdURnyf06X0hWFVoP/tLCHcw=@vger.kernel.org X-Gm-Message-State: AOJu0YxZla9/9IntQXbq1wCaSqCDpaTo6yAqDHPPMf+bBxy27MsKIhXv 9EMMr7xKcwEjRMQIlfPaOZVfnbRWh+HGVpG7kBe0Daq5DJlMF4DTuxB5 X-Gm-Gg: AeBDieuCxjT6A4AH5JHqZSfZnPzPaVExIr8vyOn2CBQnNmVbBGtIX2m/BJCUI/r7LAo GzEqaFpuAGbKeB1QwKPq2glhrXtU1UhqQDXclzSysIbfiE7AGrOZHhgR69bRD+rxSs8viH7bKBj x/RgQnrkLRkDz1rCI4+LUUD8Sxc3tRNKonB+mCrkgXTQqCbm52Q9TN/ffsVbvKL8HbRznEmDUya mq2o20SvgQ8Vv6SEEfIfDRC/caKB8Pc9wuksswv9m3o7C7wWx9b7R4nBf6zzVddG9r0KTYDb7qk QI82Mu/utsKxwfV3I8qUHmrLM+xcuFfeqPJmvac+2UnPyJoP+T5Hkge7ZiE5OyDYfac3YW/5ZhW K79STuyCxvWPmFj+NVCSZQ7rqcwCRRCdJsgxHp69RtSDAtEzqoWnX+ZTizBeOIctwJgXa6zzs/V dz0YLn+wn2kl9bnWTSz3I9QNKOkg5Oni2Z37cF9H0X02r0 X-Received: by 2002:a05:6a00:4c85:b0:82f:74b2:7fba with SMTP id d2e1a72fcca58-834dda8c794mr3045617b3a.4.1777378130380; Tue, 28 Apr 2026 05:08:50 -0700 (PDT) Received: from ehlo.thunderbird.net ([2401:4900:5760:4f51::e34:334f]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-834dae0091asm2749844b3a.10.2026.04.28.05.08.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Apr 2026 05:08:49 -0700 (PDT) Date: Tue, 28 Apr 2026 17:36:46 +0530 From: Sanjay Chitroda To: Andy Shevchenko CC: jikos@kernel.org, jic23@kernel.org, srinivas.pandruvada@linux.intel.com, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, sakari.ailus@linux.intel.com, linux-input@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_02/10=5D_iio=3A_orientation=3A_adapt?= =?US-ASCII?Q?_to_hid=5Fsensor=5Fremove=5Ftrigger=28=29_API_change?= User-Agent: Thunderbird for Android In-Reply-To: References: <20260428071613.1134053-1-sanjayembedded@gmail.com> <20260428071613.1134053-3-sanjayembedded@gmail.com> Message-ID: <1AD74A89-246F-4ABE-8088-E7A45DC3A4C0@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 28 April 2026 1:52:48=E2=80=AFpm IST, Andy Shevchenko wrote: >On Tue, Apr 28, 2026 at 12:46:05PM +0530, Sanjay Chitroda wrote: > >> Update the driver to match the updated hid_sensor_remove_trigger() >> prototype, which no longer requires struct iio_dev=2E > >You haven't compiled the previous patch, right? >This is not the way how all this should be done=2E > >Also NAK to the patch 1 as even unused parameter is there for the sake of >consistency=2E The prototype to allocate and other in the similar group a= ll >have it=2E Hi Andy, Thank for the review comment=2E I agree your point for consistency=2E However primary object of this pre-series is to prepare the drivers for de= vm_ conversation=2E I would prepare devm_ wrapper for the hid_sensor_setup_trigger() and respe= ctive resource release hid_sensor_remove_trigger()=2E =2E=2E=2E devm_hid_sensor_setup_trigger( =2E=2E=2E )=20 { =2E=2E=2E =2E=2E hid_sensor_setup_trigger(); =2E=2E=2E=2E devm_add_action_or_release(dev, hid_sensor_remove_trigger, attrb) =2E=2E=2E=2E=2E=2E } I observed that many HID IIO drivers are not covered fully with managed AP= I=2E This devm_* sensor setup trigger would use across multiple HID IIO sensors= and will go step forward for managed API support=2E >