From: Marcel Holtmann <marcel@holtmann.org>
To: Vladis Dronov <vdronov@redhat.com>
Cc: Johan Hedberg <johan.hedberg@gmail.com>,
linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
Suraj Sumangala <suraj@atheros.com>,
Frederic Danis <frederic.danis@linux.intel.com>,
Loic Poulain <loic.poulain@intel.com>,
Balakrishna Godavarthi <bgodavar@codeaurora.org>,
syzkaller@googlegroups.com
Subject: Re: [PATCH] Bluetooth: hci_uart: check for missing tty operations in protocol handlers
Date: Thu, 25 Jul 2019 16:31:31 +0200 [thread overview]
Message-ID: <1B4CE156-DB18-4010-ACB8-93A70AD1A3C5@holtmann.org> (raw)
In-Reply-To: <74627941.4546902.1564064789961.JavaMail.zimbra@redhat.com>
Hi Vladis,
>> why is this one hidden behind CONFIG_PM? The general baud rate changes are
>> independent of runtime power management support.
>
> hci_bcm calls hci_uart_set_flow_control() only from functions hidden behind
> #ifdef-CONFIG_PM (surely this can change in the future), and so without
> CONFIG_PM set it cannot hit the bug (as of now). So I've hidden the check
> for tiocm[gs]et() behind #ifdef-CONFIG_PM too.
>
> If you tell me it is better to remove this #ifdef, I'll remove it.
just remove it since I think that is a coincidence actually. And I think you also need to add a check in hci_h5.c since that got Realtek support, it should also use flow control or baud rate settings.
>> And I would introduce a bool hci_uart_has_tiocm_support(struct hci_uart *)
>> helper.
>
> Great, I will add it to the v2 fix. I guess a good place for it is hci_ldisc.c,
> near hci_uart_set_flow_control(), isn't it?
Sounds good.
Regards
Marcel
prev parent reply other threads:[~2019-07-25 14:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 12:09 Vladis Dronov
2019-07-25 12:59 ` Marcel Holtmann
2019-07-25 14:26 ` Vladis Dronov
2019-07-25 14:31 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1B4CE156-DB18-4010-ACB8-93A70AD1A3C5@holtmann.org \
--to=marcel@holtmann.org \
--cc=bgodavar@codeaurora.org \
--cc=frederic.danis@linux.intel.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@intel.com \
--cc=suraj@atheros.com \
--cc=syzkaller@googlegroups.com \
--cc=vdronov@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®