From: Marcel Holtmann <marcel@holtmann.org>
To: Colin King <colin.king@canonical.com>
Cc: Johan Hedberg <johan.hedberg@gmail.com>,
linux-bluetooth@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: btintel: make array 'param' static, shrinks object size
Date: Sat, 6 Jan 2018 17:43:52 +0100 [thread overview]
Message-ID: <1B85A899-6FB7-4BDB-B123-848C14BDFE54@holtmann.org> (raw)
In-Reply-To: <20180106162328.18625-1-colin.king@canonical.com>
Hi Colin,
> Don't populate the const read-only array 'param' on the stack but instead
> make it static. Makes the object code smaller by nearly 20 bytes:
>
> Before:
> text data bss dec hex filename
> 11605 2629 64 14298 37da linux/drivers/bluetooth/btintel.o
>
> After:
> text data bss dec hex filename
> 11531 2685 64 14280 37c8 linux/drivers/bluetooth/btintel.o
>
> (gcc version 7.2.0 x86_64)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/bluetooth/btintel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
prev parent reply other threads:[~2018-01-06 16:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-06 16:23 Colin King
2018-01-06 16:43 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1B85A899-6FB7-4BDB-B123-848C14BDFE54@holtmann.org \
--to=marcel@holtmann.org \
--cc=colin.king@canonical.com \
--cc=johan.hedberg@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®