From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00F4B63D for ; Tue, 1 Oct 2024 06:56:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727765799; cv=none; b=lh5vJ5wru7IrpQosyoxWPLtpWSN53Ihrg+0O2TH/2RQ+sfpTliRJvcInmMLlNWE9NuMdzF/zd2mHvdgeBCN1VqwZVsrmipnL7m2ddhVMaUiKzbrXAxvvLkS3lvsor8ME0VI1kkpXme6ieYRSlLjQgEM2BWfZityM1eChqdcNqFc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727765799; c=relaxed/simple; bh=P2iz+8xGuqHWu/q5RowKgPmgCIQJNV10OcVir0GCkb8=; h=Date:From:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=ejo6JU9Q11zGo+uO1yJGTg+fVExFNjtIYZWntrT8Lo/xbjdTQGoeuLjBgRMunMGA5HHgtvacbCRn+TBot2PiPfgcbXJy1TyH2IfS7Q/IqpQ0FECBnxytkzJ1LTHu0lP08uT3/uWrc8fKnepIIyDnqdft7kHDyIIScmx5Pg8fyK0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=u3Z7m3OK; arc=none smtp.client-ip=209.85.167.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="u3Z7m3OK" Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-539973829e7so1639394e87.0 for ; Mon, 30 Sep 2024 23:56:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1727765795; x=1728370595; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=Ryx/pMOkdMVMTPBu2h9pcD06K8eaJT9I2qHgxYrkpHU=; b=u3Z7m3OKfcGpX8tDingpXUYrr7SDOyZHtqgtfUBfAcZ2nrZQtHSXNgvQMpjUGySsF1 2uNCThU+Z14/p3VRb89DHfqpqURPUP/sq5dPUfV6UUTl8wP4X5JIRxzfzO+wuV0qm/wE JZBLtLPzc4QYOKVLM52+c29g/4sLMzQTFbPHhj7V4jh8BPdSH3rVt0UBmfBV8Zi0QdQN iSel9Xe6887hhbNE1TiuxL+indVNXW0XGK/v38iyxW9zx8Ch4kKR2cKPGI0PwgfU8B9o RRtzQycK+l5crnx22oA7ztZe26gfnQawsLUVTYAwBe5Lk4ULaNXg2LCaGpA66Ef092PQ I6pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727765795; x=1728370595; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Ryx/pMOkdMVMTPBu2h9pcD06K8eaJT9I2qHgxYrkpHU=; b=wT5H/vjEjqA+406tLx7dvoHxmEFTRH/HeqhCz+ry7dCY3j0nEEVLyBcBrgo6RkdzDb CCp3Ittj7s+uyvQCPh6bee4/W9XtWe3dtwDXU840geOdYd1enJSuJEkrBhfxTCc1lEmY FblDx2Bc9QKDRZ6ATB44EDCcm19Tbmk6MzgkU6JhdcgKIBYfPiyyXcWmAYIH/sNjJUCz mZEOIOpcCw0kpcH8PtXME+3OKuUwDFmFC5SJcE7yPYC63VYtE5jQGiAwX5SB9QVhfGsd YoWQh7A0QdCh7kHMOL5gpl6wJQCWyrhM6KSMsX0MR7HZSe3Iegs9Hx2VaUrAOpBrX9nH tFVw== X-Forwarded-Encrypted: i=1; AJvYcCV47nxT9ejaaVVIqy5PC5M83y48h1GfgarwbJM2SOHpnSur1hoOVQ8Tb1MfK+8D5aVU49sQCAY6yQ4UsQk=@vger.kernel.org X-Gm-Message-State: AOJu0Ywa6/vOesGfp55wIhLqN0AlTRtixLrQgSNcLliAFhCiZIFvrrsy S8IhCLlbj2FZLDQUN9ZwZtt9kANgRkGA8rv4zj8F17qWfUAC7AYQkq17cetmNVA= X-Google-Smtp-Source: AGHT+IGmpVzWubILBrr/NVsOGugY2yx5KSFiqaVKZfoYXmMzEejhXHiw9mEnypO4ONCw02IXyohG0A== X-Received: by 2002:a05:6512:3d93:b0:535:65ce:e901 with SMTP id 2adb3069b0e04-5389fc32b7dmr7801243e87.4.1727765794825; Mon, 30 Sep 2024 23:56:34 -0700 (PDT) Received: from [127.0.0.1] ([37.155.94.96]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c88248af1bsm5618973a12.75.2024.09.30.23.56.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Sep 2024 23:56:34 -0700 (PDT) Date: Tue, 01 Oct 2024 09:56:30 +0300 From: Dmitry Baryshkov To: Bjorn Andersson CC: Sibi Sankar , konradybcio@kernel.org, krzk+dt@kernel.org, robh+dt@kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org, abel.vesa@linaro.org, srinivas.kandagatla@linaro.org Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_2/2=5D_arm64=3A_dts=3A_qcom=3A_Add_?= =?US-ASCII?Q?X1E001DE_Snapdragon_Devkit_for_Windows?= User-Agent: K-9 Mail for Android In-Reply-To: References: <20240911073337.90577-1-quic_sibis@quicinc.com> <20240911073337.90577-3-quic_sibis@quicinc.com> Message-ID: <1BBC34CC-92D9-4F6E-8DFA-1F2DA36D545A@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On October 1, 2024 5:42:35 AM GMT+03:00, Bjorn Andersson wrote: >On Wed, Sep 11, 2024 at 10:55:05AM GMT, Dmitry Baryshkov wrote: >> On Wed, Sep 11, 2024 at 01:03:37PM GMT, Sibi Sankar wrote: >[=2E=2E] >> > diff --git a/arch/arm64/boot/dts/qcom/x1e001de-devkit=2Edts b/arch/ar= m64/boot/dts/qcom/x1e001de-devkit=2Edts >[=2E=2E] >> > + >> > +&pcie5 { >> > + perst-gpios =3D <&tlmm 149 GPIO_ACTIVE_LOW>; >> > + wake-gpios =3D <&tlmm 151 GPIO_ACTIVE_LOW>; >> > + >> > + vddpe-3v3-supply =3D <&vreg_wwan>; >>=20 >> Please use pwrseq instead=2E >>=20 > >What benefit is there to wrap a single 3=2E3V regulator in pwrseq driver? First of all, is it really just a 3=2E3V? Second, is it actually powering = up the host controller (as expressed in the device tree? Is it a power supp= ly to the slot (in this case, I think, it should be expressed differently)?= Or is it a power supply to the card itself? > >> > + >> > + pinctrl-0 =3D <&pcie5_default>; >> > + pinctrl-names =3D "default"; >> > + >> > + status =3D "okay"; >> > +}; >> > + >> > +&pcie5_phy { >> > + vdda-phy-supply =3D <&vreg_l3i_0p8>; >> > + vdda-pll-supply =3D <&vreg_l3e_1p2>; >> > + >> > + status =3D "okay"; >> > +}; >> > + >> > +&pcie6a { >> > + perst-gpios =3D <&tlmm 152 GPIO_ACTIVE_LOW>; >> > + wake-gpios =3D <&tlmm 154 GPIO_ACTIVE_LOW>; >> > + >> > + vddpe-3v3-supply =3D <&vreg_nvme>; >>=20 >> Please use pwrseq instead=2E >>=20 > >Ditto Same set of questions=2E > >Regards, >Bjorn --=20 With best wishes Dmitry