From: Segher Boessenkool <segher@kernel.crashing.org>
To: David Woodhouse <dwmw2@infradead.org>
Cc: "Jörn Engel" <joern@wohnheim.fh-wedel.de>,
"Jonathan McDowell" <noodles@earth.li>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add Amstrad Delta NAND support.
Date: Sat, 20 May 2006 02:10:57 +0200 [thread overview]
Message-ID: <1C9E7AB3-2DD3-40EA-B0F1-E0713A58E490@kernel.crashing.org> (raw)
In-Reply-To: <1148034391.3875.109.camel@pmac.infradead.org>
>>>> And please create a structure containing both struct mtd_info and
>>>> struct nand_chip. Then use sizeof(that structure)...
> It's fine as-is. The claim that it's nicer to introduce an extra
> datatype just for the allocation is subjective, at best.
Not just for the allocation, but also for getting the address of
the second struct, after that allocation.
If the second struct has bigger alignment required than the first,
the current code gets the second struct misaligned. Putting both
into one bigger struct would add the required padding.
(Say: sizes 4 and 8, alignment requirements 4 and 8 resp.)
Segher
next prev parent reply other threads:[~2006-05-20 0:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-18 16:09 Jonathan McDowell
2006-05-18 16:57 ` Jörn Engel
2006-05-19 9:01 ` Jonathan McDowell
2006-05-19 9:32 ` David Vrabel
2006-05-19 10:01 ` Jonathan McDowell
2006-05-19 10:03 ` Jörn Engel
2006-05-19 10:26 ` David Woodhouse
2006-05-20 0:10 ` Segher Boessenkool [this message]
2006-05-19 22:20 ` Jonathan McDowell
2006-05-20 14:10 ` Jonathan McDowell
2006-05-21 17:12 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1C9E7AB3-2DD3-40EA-B0F1-E0713A58E490@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=dwmw2@infradead.org \
--cc=joern@wohnheim.fh-wedel.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=noodles@earth.li \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®