From: Craig Tatlor <ctatlor97@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: linux-arm-msm@vger.kernel.org,Sebastian Reichel
<sre@kernel.org>,Mark Rutland <mark.rutland@arm.com>,Mauro
Carvalho Chehab <mchehab@kernel.org>,"David S. Miller"
<davem@davemloft.net>,Greg Kroah-Hartman
<gregkh@linuxfoundation.org>,Linus Walleij
<linus.walleij@linaro.org>,Andrew Morton
<akpm@linux-foundation.org>,Randy Dunlap
<rdunlap@infradead.org>,linux-pm@vger.kernel.org,devicetree@vger.kernel.org,linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/3] dt-bindings: power: supply: qcom_bms: Add bindings
Date: Fri, 13 Apr 2018 18:08:54 +0100 [thread overview]
Message-ID: <1D7FA61D-2233-45DC-A244-B2914BB1B29F@gmail.com> (raw)
In-Reply-To: <20180413163527.ludqnnc5nkj4spre@rob-hp-laptop>
On 13 April 2018 17:35:27 BST, Rob Herring <robh@kernel.org> wrote:
>On Sat, Apr 07, 2018 at 06:57:45PM +0100, Craig Tatlor wrote:
>> Add bindings for the Qualcomm Battery Monitoring system.
>>
>> Signed-off-by: Craig Tatlor <ctatlor97@gmail.com>
>> ---
>> .../bindings/power/supply/qcom_bms.txt | 93
>+++++++++++++++++++
>> 1 file changed, 93 insertions(+)
>> create mode 100644
>Documentation/devicetree/bindings/power/supply/qcom_bms.txt
>>
>> diff --git
>a/Documentation/devicetree/bindings/power/supply/qcom_bms.txt
>b/Documentation/devicetree/bindings/power/supply/qcom_bms.txt
>> new file mode 100644
>> index 000000000000..6296399edc09
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/power/supply/qcom_bms.txt
>> @@ -0,0 +1,93 @@
>> +Qualcomm Battery Measurement System
>> +
>> +The Qualcomm Battery Measurement System is found inside of Qualcomm
>PM8941
>
>Is it Monitoring or Measurment?
>
>> +PMICs. It provides OCV and coulomb counter registers that allow the
>kernel
>> +to infer a capacity level.
>
>s/kernel/OS/
>
>OCV?
Open Circuit Voltage - should I expand this?
>
>> +
>> +Required properties:
>> +- compatible: Should contain "qcom,pm8941-bms".
>> +- reg: Specifies the SPMI address and length of
>the
>> + controller's registers.
>> +- interrupts: OCV threshold interrupt.
>> +- io-channels: Should contain IIO channel specifier for
>the
>> + ADC channel that reports battery temperature.
>> +- io-channel-names: Should contain "temp".
>> +- qcom,fcc-temp-legend: An array containing the temperature, in
>degC,
>> + for each column of the FCC lookup table.
>
>What's FCC?
Full charge capacity - Should i also expand this? or maybe explain in header paragraph?
>
>> +- qcom,fcc-lut: An array of FCC values in mah, one entry
>for each
>> + temperature defined in in qcom,fcc-temp-legend.
>> +- qcom,ocv-temp-legend: An array containing the temperature, in
>degC,
>> + for each column of the OCV lookup table.
>> +- qcom,ocv-capacity-legend: An array containing the capacity for
>each
>> + row of the OCV lookup table.
>> +- qcom,ocv-lut: An array of OCV values in mV, one entry
>for each
>> + capacity defined in qcom,ocv-capacity-legend.
>
>Need to specify the sizes of these if not 32-bit.
Right.
>
>All these seem to have units, so add unit suffixes as defined in
>property-units.txt.
Will do.
>
>> +
>> +Example:
>> +
>> + pm8941_vadc: vadc@3100 {
>
>adc@...
Okay.
>
>> + compatible = "qcom,spmi-vadc";
>> + reg = <0x3100>;
>> + interrupts = <0x0 0x31 0x0 IRQ_TYPE_EDGE_RISING>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + #io-channel-cells = <1>;
>> +
>> + bat_temp {
>> + reg = <VADC_LR_MUX1_BAT_THERM>;
>> + };
>> + };
>> +
>> + bms@4000 {
>> + compatible = "qcom,pm8941-bms";
>> + reg = <0x4000>;
>> + interrupts = <0x0 0x40 0x4 IRQ_TYPE_EDGE_RISING>;
>> + interrupt-names = "ocv_thr";
>> +
>> + io-channels = <&pm8941_vadc VADC_LR_MUX1_BAT_THERM>;
>> + io-channel-names = "temp";
>> +
>> + qcom,fcc-temp-legend = /bits/ 8 <(-10) 0 25 50 65>;
>> + qcom,fcc-lut = /bits/ 16 <6010 6070 6680 6780 6670>;
>> +
>> + qcom,ocv-capacity-legend = /bits/ 8 <100 95 90 85
>> + 80 75 70 65
>> + 60 55 50 45
>> + 40 35 30 25
>> + 20 15 10 9
>> + 8 7 6 5 4
>> + 3 2 1 0>;
>> +
>> + qcom,ocv-temp-legend = /bits/ 8 <(-10) 0 25 50 65>;
>> + qcom,ocv-lut = /bits/ 16 <4288 4288 4306 4315 4315
>> + 4261 4241 4259 4266 4246
>> + 4201 4181 4201 4207 4187
>> + 4153 4133 4150 4155 4135
>> + 4105 4085 4100 4104 4084
>> + 4058 4038 4052 4058 4038
>> + 4012 3992 4004 4014 3994
>> + 3970 3950 3959 3971 3951
>> + 3931 3911 3915 3927 3907
>> + 3899 3879 3880 3884 3864
>> + 3873 3853 3851 3853 3833
>> + 3848 3828 3827 3829 3809
>> + 3829 3809 3808 3809 3789
>> + 3815 3795 3791 3791 3771
>> + 3801 3781 3775 3772 3752
>> + 3785 3765 3751 3746 3726
>> + 3767 3747 3727 3719 3699
>> + 3750 3730 3702 3692 3672
>> + 3728 3708 3680 3672 3652
>> + 3720 3700 3676 3665 3645
>> + 3712 3692 3670 3660 3645
>> + 3695 3675 3658 3648 3633
>> + 3662 3647 3629 3620 3610
>> + 3620 3605 3589 3580 3570
>> + 3562 3552 3538 3529 3519
>> + 3490 3480 3474 3470 3465
>> + 3403 3398 3388 3380 3375
>> + 3320 3300 3255 3221 3206
>> + 3000 3000 3000 3000 3000>;
>> + };
>> + };
>> +};
>> --
>> 2.17.0
>>
next prev parent reply other threads:[~2018-04-13 17:08 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-07 13:59 [PATCH v3 1/3] power: supply: Add support for the Qualcomm Battery Monitoring System Craig Tatlor
2018-04-07 13:59 ` [PATCH v3 2/3] dt-bindings: power: supply: qcom_bms: Add bindings Craig Tatlor
2018-04-07 13:59 ` [PATCH v3 3/3] MAINTAINERS: Add entry for the Qualcomm BMS Craig Tatlor
2018-04-07 16:37 ` [PATCH v3 1/3] power: supply: Add support for the Qualcomm Battery Monitoring System Randy Dunlap
2018-04-07 17:40 ` Craig Tatlor
2018-04-07 17:54 ` Craig Tatlor
2018-04-07 17:57 ` [PATCH v4 " Craig Tatlor
2018-04-07 17:57 ` [PATCH v4 2/3] dt-bindings: power: supply: qcom_bms: Add bindings Craig Tatlor
2018-04-13 16:35 ` Rob Herring
2018-04-13 17:08 ` Craig Tatlor [this message]
2018-04-13 17:10 ` Craig Tatlor
2018-04-15 12:55 ` Craig Tatlor
2018-04-18 21:16 ` Rob Herring
2018-04-07 17:57 ` [PATCH v4 3/3] MAINTAINERS: Add entry for the Qualcomm BMS Craig Tatlor
2018-04-26 11:34 ` [PATCH v4 1/3] power: supply: Add support for the Qualcomm Battery Monitoring System Linus Walleij
2018-04-30 18:06 ` Craig Tatlor
2018-06-07 18:12 ` [PATCH v5 1/4] fixp-arith: add a linear interpolation function Craig Tatlor
2018-06-07 18:12 ` [PATCH v5 2/4] power: supply: Add support for the Qualcomm Battery Monitoring System Craig Tatlor
2018-06-07 19:08 ` Randy Dunlap
2018-06-13 15:58 ` Craig Tatlor
2018-06-07 18:12 ` [PATCH v5 3/4] dt-bindings: power: supply: qcom_bms: Add bindings Craig Tatlor
2018-06-11 18:15 ` Rob Herring
2018-06-13 16:00 ` Craig Tatlor
2018-06-07 18:12 ` [PATCH v5 4/4] MAINTAINERS: Add entry for the Qualcomm BMS Craig Tatlor
2018-06-13 11:06 ` [PATCH v5 1/4] fixp-arith: add a linear interpolation function Linus Walleij
2018-06-13 11:12 ` Linus Walleij
2018-06-13 16:01 ` Craig Tatlor
2018-06-13 16:06 ` [PATCH v6 " Craig Tatlor
2018-06-13 16:06 ` [PATCH v6 2/4] power: supply: Add support for the Qualcomm Battery Monitoring System Craig Tatlor
2018-06-14 14:06 ` Linus Walleij
2018-06-13 16:06 ` [PATCH v6 3/4] dt-bindings: power: supply: qcom_bms: Add bindings Craig Tatlor
2018-06-13 22:53 ` Matthias Kaehlcke
2018-06-13 16:06 ` [PATCH v6 4/4] MAINTAINERS: Add entry for the Qualcomm BMS Craig Tatlor
2018-06-14 15:14 ` [PATCH v7 1/4] fixp-arith: add a linear interpolation function Craig Tatlor
2018-06-14 15:14 ` [PATCH v7 2/4] power: supply: Add support for the Qualcomm Battery Monitoring System Craig Tatlor
2018-09-16 13:48 ` Sebastian Reichel
2018-09-20 14:43 ` Craig
2018-06-14 15:14 ` [PATCH v7 3/4] dt-bindings: power: supply: qcom_bms: Add bindings Craig Tatlor
2018-09-16 12:10 ` Sebastian Reichel
2018-09-20 14:32 ` Craig
2018-09-20 16:58 ` Sebastian Reichel
2018-09-20 19:13 ` Craig
2018-09-20 21:42 ` Sebastian Reichel
2018-09-20 20:08 ` Baolin Wang
2018-09-20 22:13 ` Sebastian Reichel
2018-09-21 15:40 ` Linus Walleij
2018-06-14 15:14 ` [PATCH v7 4/4] MAINTAINERS: Add entry for the Qualcomm BMS Craig Tatlor
2018-08-10 20:21 ` [PATCH] clk: qcom: Add Global Clock controller (GCC) driver for SDM660 Craig Tatlor
2018-08-11 21:30 ` kbuild test robot
2018-08-11 21:30 ` [RFC PATCH] clk: qcom: gcc_sdm660_hws[] can be static kbuild test robot
2018-08-13 6:55 ` [PATCH] clk: qcom: Add Global Clock controller (GCC) driver for SDM660 Taniya Das
2018-08-13 7:45 ` Craig Tatlor
2018-09-24 12:44 ` Heiko Stuebner
2018-09-24 14:33 ` Craig
2018-08-13 9:44 ` Craig Tatlor
2018-09-25 16:35 ` [PATCH v2] " Craig Tatlor
2018-09-25 17:35 ` [PATCH v3] " Craig Tatlor
2018-09-27 19:51 ` Rob Herring
2018-10-08 6:51 ` Craig
2018-10-16 22:05 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1D7FA61D-2233-45DC-A244-B2914BB1B29F@gmail.com \
--to=ctatlor97@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=rdunlap@infradead.org \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®