From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752815AbcBKCw3 (ORCPT ); Wed, 10 Feb 2016 21:52:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40680 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750801AbcBKCw1 convert rfc822-to-8bit (ORCPT ); Wed, 10 Feb 2016 21:52:27 -0500 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 9.2 \(3112\)) Subject: Re: [PATCH] ceph: fix a wrong comparison From: "Yan, Zheng" In-Reply-To: <1455125883-27735-1-git-send-email-a.s.protopopov@gmail.com> Date: Thu, 11 Feb 2016 10:52:14 +0800 Cc: Sage Weil , Ilya Dryomov , ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: <1ED8DAC2-EEA9-4D59-A396-A0B08FC92416@redhat.com> References: <1455125883-27735-1-git-send-email-a.s.protopopov@gmail.com> To: Anton Protopopov Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Feb 11, 2016, at 01:38, Anton Protopopov wrote: > > A negative value rc compared to the positive value ENOENT in the > finish_read() function. > > Signed-off-by: Anton Protopopov > --- > fs/ceph/addr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c > index c222137..1b809c9 100644 > --- a/fs/ceph/addr.c > +++ b/fs/ceph/addr.c > @@ -276,7 +276,7 @@ static void finish_read(struct ceph_osd_request *req, struct ceph_msg *msg) > for (i = 0; i < num_pages; i++) { > struct page *page = osd_data->pages[i]; > > - if (rc < 0 && rc != ENOENT) > + if (rc < 0 && rc != -ENOENT) > goto unlock; > if (bytes < (int)PAGE_CACHE_SIZE) { > /* zero (remainder of) page */ Good catch, thanks Yan, Zheng > -- > 2.6.5 >