From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8925DC43461 for ; Fri, 4 Sep 2020 13:32:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 35D822073B for ; Fri, 4 Sep 2020 13:32:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=crapouillou.net header.i=@crapouillou.net header.b="rHqRPCH+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730479AbgIDNcT (ORCPT ); Fri, 4 Sep 2020 09:32:19 -0400 Received: from crapouillou.net ([89.234.176.41]:54374 "EHLO crapouillou.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730395AbgIDN1w (ORCPT ); Fri, 4 Sep 2020 09:27:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1599226069; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BeyOxd0Z1Sl90VNPLBeBKSGBp6sDPp1jUNoeYAamw2w=; b=rHqRPCH+e3RIZgT/ZmBUIcGgflAwzW/zRzxhQm134TCinJ8+jJflEVGv2aIfS93Jl9B0Q2 k/wr1ozEbeiEYrAkOYk8Mgr07xpj84fyU+CdxJUsoocj01SVLA+U8mL3k/JrtMB90FnEJk 9BTLeEkA0wV0NxR2JxUlfLU8NI3Mr10= Date: Fri, 04 Sep 2020 15:27:37 +0200 From: Paul Cercueil Subject: Re: [PATCH v2 1/3] pinctrl: Ingenic: Add SSI pins support for JZ4770 and JZ4780. To: =?UTF-8?b?5ZGo55Cw5p2w?= Cc: linus.walleij@linaro.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, aric.pzqi@ingenic.com, dongsheng.qiu@ingenic.com, rick.tyliu@ingenic.com, yanfei.li@ingenic.com, sernia.zhou@foxmail.com, zhenwenjin@gmail.com Message-Id: <1QY4GQ.ER1P2TWMJCKH@crapouillou.net> In-Reply-To: <20200831154324.64951-2-zhouyanjie@wanyeetech.com> References: <20200831154324.64951-1-zhouyanjie@wanyeetech.com> <20200831154324.64951-2-zhouyanjie@wanyeetech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Zhou, Le lun. 31 ao=C3=BBt 2020 =C3=A0 23:43, =E5=91=A8=E7=90=B0=E6=9D=B0 (Zhou Y= anjie)=20 a =C3=A9crit : > Add SSI pins support for the JZ4770 SoC and the > JZ4780 SoC from Ingenic. >=20 > Signed-off-by: =E5=91=A8=E7=90=B0=E6=9D=B0 (Zhou Yanjie) > --- >=20 > Notes: > v1->v2: > Rebase on top of kernel 5.9-rc3. >=20 > drivers/pinctrl/pinctrl-ingenic.c | 267=20 > ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 267 insertions(+) >=20 > diff --git a/drivers/pinctrl/pinctrl-ingenic.c=20 > b/drivers/pinctrl/pinctrl-ingenic.c > index a8d1b53ec4c1..00f29fd684fa 100644 > --- a/drivers/pinctrl/pinctrl-ingenic.c > +++ b/drivers/pinctrl/pinctrl-ingenic.c > @@ -633,6 +633,46 @@ static int jz4770_uart2_data_pins[] =3D { 0x5c,=20 > 0x5e, }; > static int jz4770_uart2_hwflow_pins[] =3D { 0x5d, 0x5f, }; > static int jz4770_uart3_data_pins[] =3D { 0x6c, 0x85, }; > static int jz4770_uart3_hwflow_pins[] =3D { 0x88, 0x89, }; > +static int jz4770_ssi0_dt_a_pins[] =3D { 0x15, }; > +static int jz4770_ssi0_dt_b_pins[] =3D { 0x35, }; > +static int jz4770_ssi0_dt_d_pins[] =3D { 0x55, }; > +static int jz4770_ssi0_dt_e_pins[] =3D { 0x71, }; > +static int jz4770_ssi0_dr_a_pins[] =3D { 0x14, }; > +static int jz4770_ssi0_dr_b_pins[] =3D { 0x34, }; > +static int jz4770_ssi0_dr_d_pins[] =3D { 0x54, }; > +static int jz4770_ssi0_dr_e_pins[] =3D { 0x6e, }; > +static int jz4770_ssi0_clk_a_pins[] =3D { 0x12, }; > +static int jz4770_ssi0_clk_b_pins[] =3D { 0x3c, }; > +static int jz4770_ssi0_clk_d_pins[] =3D { 0x58, }; > +static int jz4770_ssi0_clk_e_pins[] =3D { 0x6f, }; > +static int jz4770_ssi0_gpc_b_pins[] =3D { 0x3e, }; > +static int jz4770_ssi0_gpc_d_pins[] =3D { 0x56, }; > +static int jz4770_ssi0_gpc_e_pins[] =3D { 0x73, }; > +static int jz4770_ssi0_ce0_a_pins[] =3D { 0x13, }; > +static int jz4770_ssi0_ce0_b_pins[] =3D { 0x3d, }; > +static int jz4770_ssi0_ce0_d_pins[] =3D { 0x59, }; > +static int jz4770_ssi0_ce0_e_pins[] =3D { 0x70, }; > +static int jz4770_ssi0_ce1_b_pins[] =3D { 0x3f, }; > +static int jz4770_ssi0_ce1_d_pins[] =3D { 0x57, }; > +static int jz4770_ssi0_ce1_e_pins[] =3D { 0x72, }; > +static int jz4770_ssi1_dt_b_pins[] =3D { 0x35, }; > +static int jz4770_ssi1_dt_d_pins[] =3D { 0x55, }; > +static int jz4770_ssi1_dt_e_pins[] =3D { 0x71, }; > +static int jz4770_ssi1_dr_b_pins[] =3D { 0x34, }; > +static int jz4770_ssi1_dr_d_pins[] =3D { 0x54, }; > +static int jz4770_ssi1_dr_e_pins[] =3D { 0x6e, }; > +static int jz4770_ssi1_clk_b_pins[] =3D { 0x3c, }; > +static int jz4770_ssi1_clk_d_pins[] =3D { 0x58, }; > +static int jz4770_ssi1_clk_e_pins[] =3D { 0x6f, }; > +static int jz4770_ssi1_gpc_b_pins[] =3D { 0x3e, }; > +static int jz4770_ssi1_gpc_d_pins[] =3D { 0x56, }; > +static int jz4770_ssi1_gpc_e_pins[] =3D { 0x73, }; > +static int jz4770_ssi1_ce0_b_pins[] =3D { 0x3d, }; > +static int jz4770_ssi1_ce0_d_pins[] =3D { 0x59, }; > +static int jz4770_ssi1_ce0_e_pins[] =3D { 0x70, }; > +static int jz4770_ssi1_ce1_b_pins[] =3D { 0x3f, }; > +static int jz4770_ssi1_ce1_d_pins[] =3D { 0x57, }; > +static int jz4770_ssi1_ce1_e_pins[] =3D { 0x72, }; > static int jz4770_mmc0_1bit_a_pins[] =3D { 0x12, 0x13, 0x14, }; > static int jz4770_mmc0_4bit_a_pins[] =3D { 0x15, 0x16, 0x17, }; > static int jz4770_mmc0_1bit_e_pins[] =3D { 0x9c, 0x9d, 0x94, }; > @@ -703,6 +743,46 @@ static int jz4770_uart2_data_funcs[] =3D { 0, 0, }; > static int jz4770_uart2_hwflow_funcs[] =3D { 0, 0, }; > static int jz4770_uart3_data_funcs[] =3D { 0, 1, }; > static int jz4770_uart3_hwflow_funcs[] =3D { 0, 0, }; > +static int jz4770_ssi0_dt_a_funcs[] =3D { 2, }; > +static int jz4770_ssi0_dt_b_funcs[] =3D { 1, }; > +static int jz4770_ssi0_dt_d_funcs[] =3D { 1, }; > +static int jz4770_ssi0_dt_e_funcs[] =3D { 0, }; > +static int jz4770_ssi0_dr_a_funcs[] =3D { 1, }; > +static int jz4770_ssi0_dr_b_funcs[] =3D { 1, }; > +static int jz4770_ssi0_dr_d_funcs[] =3D { 1, }; > +static int jz4770_ssi0_dr_e_funcs[] =3D { 0, }; > +static int jz4770_ssi0_clk_a_funcs[] =3D { 2, }; > +static int jz4770_ssi0_clk_b_funcs[] =3D { 1, }; > +static int jz4770_ssi0_clk_d_funcs[] =3D { 1, }; > +static int jz4770_ssi0_clk_e_funcs[] =3D { 0, }; > +static int jz4770_ssi0_gpc_b_funcs[] =3D { 1, }; > +static int jz4770_ssi0_gpc_d_funcs[] =3D { 1, }; > +static int jz4770_ssi0_gpc_e_funcs[] =3D { 0, }; > +static int jz4770_ssi0_ce0_a_funcs[] =3D { 2, }; > +static int jz4770_ssi0_ce0_b_funcs[] =3D { 1, }; > +static int jz4770_ssi0_ce0_d_funcs[] =3D { 1, }; > +static int jz4770_ssi0_ce0_e_funcs[] =3D { 0, }; > +static int jz4770_ssi0_ce1_b_funcs[] =3D { 1, }; > +static int jz4770_ssi0_ce1_d_funcs[] =3D { 1, }; > +static int jz4770_ssi0_ce1_e_funcs[] =3D { 0, }; > +static int jz4770_ssi1_dt_b_funcs[] =3D { 2, }; > +static int jz4770_ssi1_dt_d_funcs[] =3D { 2, }; > +static int jz4770_ssi1_dt_e_funcs[] =3D { 1, }; > +static int jz4770_ssi1_dr_b_funcs[] =3D { 2, }; > +static int jz4770_ssi1_dr_d_funcs[] =3D { 2, }; > +static int jz4770_ssi1_dr_e_funcs[] =3D { 1, }; > +static int jz4770_ssi1_clk_b_funcs[] =3D { 2, }; > +static int jz4770_ssi1_clk_d_funcs[] =3D { 2, }; > +static int jz4770_ssi1_clk_e_funcs[] =3D { 1, }; > +static int jz4770_ssi1_gpc_b_funcs[] =3D { 2, }; > +static int jz4770_ssi1_gpc_d_funcs[] =3D { 2, }; > +static int jz4770_ssi1_gpc_e_funcs[] =3D { 1, }; > +static int jz4770_ssi1_ce0_b_funcs[] =3D { 2, }; > +static int jz4770_ssi1_ce0_d_funcs[] =3D { 2, }; > +static int jz4770_ssi1_ce0_e_funcs[] =3D { 1, }; > +static int jz4770_ssi1_ce1_b_funcs[] =3D { 2, }; > +static int jz4770_ssi1_ce1_d_funcs[] =3D { 2, }; > +static int jz4770_ssi1_ce1_e_funcs[] =3D { 1, }; > static int jz4770_mmc0_1bit_a_funcs[] =3D { 1, 1, 0, }; > static int jz4770_mmc0_4bit_a_funcs[] =3D { 1, 1, 1, }; > static int jz4770_mmc0_1bit_e_funcs[] =3D { 0, 0, 0, }; > @@ -763,6 +843,46 @@ static const struct group_desc jz4770_groups[] =3D=20 > { > INGENIC_PIN_GROUP("uart2-hwflow", jz4770_uart2_hwflow), > INGENIC_PIN_GROUP("uart3-data", jz4770_uart3_data), > INGENIC_PIN_GROUP("uart3-hwflow", jz4770_uart3_hwflow), > + INGENIC_PIN_GROUP("ssi0-dt-a", jz4770_ssi0_dt_a), > + INGENIC_PIN_GROUP("ssi0-dt-b", jz4770_ssi0_dt_b), > + INGENIC_PIN_GROUP("ssi0-dt-d", jz4770_ssi0_dt_d), > + INGENIC_PIN_GROUP("ssi0-dt-e", jz4770_ssi0_dt_e), > + INGENIC_PIN_GROUP("ssi0-dr-a", jz4770_ssi0_dr_a), > + INGENIC_PIN_GROUP("ssi0-dr-b", jz4770_ssi0_dr_b), > + INGENIC_PIN_GROUP("ssi0-dr-d", jz4770_ssi0_dr_d), > + INGENIC_PIN_GROUP("ssi0-dr-e", jz4770_ssi0_dr_e), The common acronyms associated with SPI are MISO / MOSI, I think it=20 would make sense to use them instead of DR / DT. What do you think? The rest looks OK. Cheers, -Paul > + INGENIC_PIN_GROUP("ssi0-clk-a", jz4770_ssi0_clk_a), > + INGENIC_PIN_GROUP("ssi0-clk-b", jz4770_ssi0_clk_b), > + INGENIC_PIN_GROUP("ssi0-clk-d", jz4770_ssi0_clk_d), > + INGENIC_PIN_GROUP("ssi0-clk-e", jz4770_ssi0_clk_e), > + INGENIC_PIN_GROUP("ssi0-gpc-b", jz4770_ssi0_gpc_b), > + INGENIC_PIN_GROUP("ssi0-gpc-d", jz4770_ssi0_gpc_d), > + INGENIC_PIN_GROUP("ssi0-gpc-e", jz4770_ssi0_gpc_e), > + INGENIC_PIN_GROUP("ssi0-ce0-a", jz4770_ssi0_ce0_a), > + INGENIC_PIN_GROUP("ssi0-ce0-b", jz4770_ssi0_ce0_b), > + INGENIC_PIN_GROUP("ssi0-ce0-d", jz4770_ssi0_ce0_d), > + INGENIC_PIN_GROUP("ssi0-ce0-e", jz4770_ssi0_ce0_e), > + INGENIC_PIN_GROUP("ssi0-ce1-b", jz4770_ssi0_ce1_b), > + INGENIC_PIN_GROUP("ssi0-ce1-d", jz4770_ssi0_ce1_d), > + INGENIC_PIN_GROUP("ssi0-ce1-e", jz4770_ssi0_ce1_e), > + INGENIC_PIN_GROUP("ssi1-dt-b", jz4770_ssi1_dt_b), > + INGENIC_PIN_GROUP("ssi1-dt-d", jz4770_ssi1_dt_d), > + INGENIC_PIN_GROUP("ssi1-dt-e", jz4770_ssi1_dt_e), > + INGENIC_PIN_GROUP("ssi1-dr-b", jz4770_ssi1_dr_b), > + INGENIC_PIN_GROUP("ssi1-dr-d", jz4770_ssi1_dr_d), > + INGENIC_PIN_GROUP("ssi1-dr-e", jz4770_ssi1_dr_e), > + INGENIC_PIN_GROUP("ssi1-clk-b", jz4770_ssi1_clk_b), > + INGENIC_PIN_GROUP("ssi1-clk-d", jz4770_ssi1_clk_d), > + INGENIC_PIN_GROUP("ssi1-clk-e", jz4770_ssi1_clk_e), > + INGENIC_PIN_GROUP("ssi1-gpc-b", jz4770_ssi1_gpc_b), > + INGENIC_PIN_GROUP("ssi1-gpc-d", jz4770_ssi1_gpc_d), > + INGENIC_PIN_GROUP("ssi1-gpc-e", jz4770_ssi1_gpc_e), > + INGENIC_PIN_GROUP("ssi1-ce0-b", jz4770_ssi1_ce0_b), > + INGENIC_PIN_GROUP("ssi1-ce0-d", jz4770_ssi1_ce0_d), > + INGENIC_PIN_GROUP("ssi1-ce0-e", jz4770_ssi1_ce0_e), > + INGENIC_PIN_GROUP("ssi1-ce1-b", jz4770_ssi1_ce1_b), > + INGENIC_PIN_GROUP("ssi1-ce1-d", jz4770_ssi1_ce1_d), > + INGENIC_PIN_GROUP("ssi1-ce1-e", jz4770_ssi1_ce1_e), > INGENIC_PIN_GROUP("mmc0-1bit-a", jz4770_mmc0_1bit_a), > INGENIC_PIN_GROUP("mmc0-4bit-a", jz4770_mmc0_4bit_a), > INGENIC_PIN_GROUP("mmc0-1bit-e", jz4770_mmc0_1bit_e), > @@ -815,6 +935,22 @@ static const char *jz4770_uart0_groups[] =3D {=20 > "uart0-data", "uart0-hwflow", }; > static const char *jz4770_uart1_groups[] =3D { "uart1-data",=20 > "uart1-hwflow", }; > static const char *jz4770_uart2_groups[] =3D { "uart2-data",=20 > "uart2-hwflow", }; > static const char *jz4770_uart3_groups[] =3D { "uart3-data",=20 > "uart3-hwflow", }; > +static const char *jz4770_ssi0_groups[] =3D { > + "ssi0-dt-a", "ssi0-dt-b", "ssi0-dt-d", "ssi0-dt-e", > + "ssi0-dr-a", "ssi0-dr-b", "ssi0-dr-d", "ssi0-dr-e", > + "ssi0-clk-a", "ssi0-clk-b", "ssi0-clk-d", "ssi0-clk-e", > + "ssi0-gpc-b", "ssi0-gpc-d", "ssi0-gpc-e", > + "ssi0-ce0-a", "ssi0-ce0-b", "ssi0-ce0-d", "ssi0-ce0-e", > + "ssi0-ce1-b", "ssi0-ce1-d", "ssi0-ce1-e", > +}; > +static const char *jz4770_ssi1_groups[] =3D { > + "ssi1-dt-b", "ssi1-dt-d", "ssi1-dt-e", > + "ssi1-dr-b", "ssi1-dr-d", "ssi1-dr-e", > + "ssi1-clk-b", "ssi1-clk-d", "ssi1-clk-e", > + "ssi1-gpc-b", "ssi1-gpc-d", "ssi1-gpc-e", > + "ssi1-ce0-b", "ssi1-ce0-d", "ssi1-ce0-e", > + "ssi1-ce1-b", "ssi1-ce1-d", "ssi1-ce1-e", > +}; > static const char *jz4770_mmc0_groups[] =3D { > "mmc0-1bit-a", "mmc0-4bit-a", > "mmc0-1bit-e", "mmc0-4bit-e", "mmc0-8bit-e", > @@ -858,6 +994,8 @@ static const struct function_desc=20 > jz4770_functions[] =3D { > { "uart1", jz4770_uart1_groups, ARRAY_SIZE(jz4770_uart1_groups), }, > { "uart2", jz4770_uart2_groups, ARRAY_SIZE(jz4770_uart2_groups), }, > { "uart3", jz4770_uart3_groups, ARRAY_SIZE(jz4770_uart3_groups), }, > + { "ssi0", jz4770_ssi0_groups, ARRAY_SIZE(jz4770_ssi0_groups), }, > + { "ssi1", jz4770_ssi1_groups, ARRAY_SIZE(jz4770_ssi1_groups), }, > { "mmc0", jz4770_mmc0_groups, ARRAY_SIZE(jz4770_mmc0_groups), }, > { "mmc1", jz4770_mmc1_groups, ARRAY_SIZE(jz4770_mmc1_groups), }, > { "mmc2", jz4770_mmc2_groups, ARRAY_SIZE(jz4770_mmc2_groups), }, > @@ -900,6 +1038,39 @@ static const struct ingenic_chip_info=20 > jz4770_chip_info =3D { > static int jz4780_uart2_data_pins[] =3D { 0x66, 0x67, }; > static int jz4780_uart2_hwflow_pins[] =3D { 0x65, 0x64, }; > static int jz4780_uart4_data_pins[] =3D { 0x54, 0x4a, }; > +static int jz4780_ssi0_dt_a_19_pins[] =3D { 0x13, }; > +static int jz4780_ssi0_dt_a_21_pins[] =3D { 0x15, }; > +static int jz4780_ssi0_dt_a_28_pins[] =3D { 0x1c, }; > +static int jz4780_ssi0_dt_b_pins[] =3D { 0x3d, }; > +static int jz4780_ssi0_dt_d_pins[] =3D { 0x59, }; > +static int jz4780_ssi0_dr_a_20_pins[] =3D { 0x14, }; > +static int jz4780_ssi0_dr_a_27_pins[] =3D { 0x1b, }; > +static int jz4780_ssi0_dr_b_pins[] =3D { 0x34, }; > +static int jz4780_ssi0_dr_d_pins[] =3D { 0x54, }; > +static int jz4780_ssi0_clk_a_pins[] =3D { 0x12, }; > +static int jz4780_ssi0_clk_b_5_pins[] =3D { 0x25, }; > +static int jz4780_ssi0_clk_b_28_pins[] =3D { 0x3c, }; > +static int jz4780_ssi0_clk_d_pins[] =3D { 0x58, }; > +static int jz4780_ssi0_gpc_b_pins[] =3D { 0x3e, }; > +static int jz4780_ssi0_gpc_d_pins[] =3D { 0x56, }; > +static int jz4780_ssi0_ce0_a_23_pins[] =3D { 0x17, }; > +static int jz4780_ssi0_ce0_a_25_pins[] =3D { 0x19, }; > +static int jz4780_ssi0_ce0_b_pins[] =3D { 0x3f, }; > +static int jz4780_ssi0_ce0_d_pins[] =3D { 0x57, }; > +static int jz4780_ssi0_ce1_b_pins[] =3D { 0x35, }; > +static int jz4780_ssi0_ce1_d_pins[] =3D { 0x55, }; > +static int jz4780_ssi1_dt_b_pins[] =3D { 0x3d, }; > +static int jz4780_ssi1_dt_d_pins[] =3D { 0x59, }; > +static int jz4780_ssi1_dr_b_pins[] =3D { 0x34, }; > +static int jz4780_ssi1_dr_d_pins[] =3D { 0x54, }; > +static int jz4780_ssi1_clk_b_pins[] =3D { 0x3c, }; > +static int jz4780_ssi1_clk_d_pins[] =3D { 0x58, }; > +static int jz4780_ssi1_gpc_b_pins[] =3D { 0x3e, }; > +static int jz4780_ssi1_gpc_d_pins[] =3D { 0x56, }; > +static int jz4780_ssi1_ce0_b_pins[] =3D { 0x3f, }; > +static int jz4780_ssi1_ce0_d_pins[] =3D { 0x57, }; > +static int jz4780_ssi1_ce1_b_pins[] =3D { 0x35, }; > +static int jz4780_ssi1_ce1_d_pins[] =3D { 0x55, }; > static int jz4780_mmc0_8bit_a_pins[] =3D { 0x04, 0x05, 0x06, 0x07,=20 > 0x18, }; > static int jz4780_i2c3_pins[] =3D { 0x6a, 0x6b, }; > static int jz4780_i2c4_e_pins[] =3D { 0x8c, 0x8d, }; > @@ -909,6 +1080,39 @@ static int jz4780_hdmi_ddc_pins[] =3D { 0xb9,=20 > 0xb8, }; > static int jz4780_uart2_data_funcs[] =3D { 1, 1, }; > static int jz4780_uart2_hwflow_funcs[] =3D { 1, 1, }; > static int jz4780_uart4_data_funcs[] =3D { 2, 2, }; > +static int jz4780_ssi0_dt_a_19_funcs[] =3D { 2, }; > +static int jz4780_ssi0_dt_a_21_funcs[] =3D { 2, }; > +static int jz4780_ssi0_dt_a_28_funcs[] =3D { 2, }; > +static int jz4780_ssi0_dt_b_funcs[] =3D { 1, }; > +static int jz4780_ssi0_dt_d_funcs[] =3D { 1, }; > +static int jz4780_ssi0_dr_a_20_funcs[] =3D { 2, }; > +static int jz4780_ssi0_dr_a_27_funcs[] =3D { 2, }; > +static int jz4780_ssi0_dr_b_funcs[] =3D { 1, }; > +static int jz4780_ssi0_dr_d_funcs[] =3D { 1, }; > +static int jz4780_ssi0_clk_a_funcs[] =3D { 2, }; > +static int jz4780_ssi0_clk_b_5_funcs[] =3D { 1, }; > +static int jz4780_ssi0_clk_b_28_funcs[] =3D { 1, }; > +static int jz4780_ssi0_clk_d_funcs[] =3D { 1, }; > +static int jz4780_ssi0_gpc_b_funcs[] =3D { 1, }; > +static int jz4780_ssi0_gpc_d_funcs[] =3D { 1, }; > +static int jz4780_ssi0_ce0_a_23_funcs[] =3D { 2, }; > +static int jz4780_ssi0_ce0_a_25_funcs[] =3D { 2, }; > +static int jz4780_ssi0_ce0_b_funcs[] =3D { 1, }; > +static int jz4780_ssi0_ce0_d_funcs[] =3D { 1, }; > +static int jz4780_ssi0_ce1_b_funcs[] =3D { 1, }; > +static int jz4780_ssi0_ce1_d_funcs[] =3D { 1, }; > +static int jz4780_ssi1_dt_b_funcs[] =3D { 2, }; > +static int jz4780_ssi1_dt_d_funcs[] =3D { 2, }; > +static int jz4780_ssi1_dr_b_funcs[] =3D { 2, }; > +static int jz4780_ssi1_dr_d_funcs[] =3D { 2, }; > +static int jz4780_ssi1_clk_b_funcs[] =3D { 2, }; > +static int jz4780_ssi1_clk_d_funcs[] =3D { 2, }; > +static int jz4780_ssi1_gpc_b_funcs[] =3D { 2, }; > +static int jz4780_ssi1_gpc_d_funcs[] =3D { 2, }; > +static int jz4780_ssi1_ce0_b_funcs[] =3D { 2, }; > +static int jz4780_ssi1_ce0_d_funcs[] =3D { 2, }; > +static int jz4780_ssi1_ce1_b_funcs[] =3D { 2, }; > +static int jz4780_ssi1_ce1_d_funcs[] =3D { 2, }; > static int jz4780_mmc0_8bit_a_funcs[] =3D { 1, 1, 1, 1, 1, }; > static int jz4780_i2c3_funcs[] =3D { 1, 1, }; > static int jz4780_i2c4_e_funcs[] =3D { 1, 1, }; > @@ -925,6 +1129,51 @@ static const struct group_desc jz4780_groups[]=20 > =3D { > INGENIC_PIN_GROUP("uart3-data", jz4770_uart3_data), > INGENIC_PIN_GROUP("uart3-hwflow", jz4770_uart3_hwflow), > INGENIC_PIN_GROUP("uart4-data", jz4780_uart4_data), > + INGENIC_PIN_GROUP("ssi0-dt-a-19", jz4780_ssi0_dt_a_19), > + INGENIC_PIN_GROUP("ssi0-dt-a-21", jz4780_ssi0_dt_a_21), > + INGENIC_PIN_GROUP("ssi0-dt-a-28", jz4780_ssi0_dt_a_28), > + INGENIC_PIN_GROUP("ssi0-dt-b", jz4780_ssi0_dt_b), > + INGENIC_PIN_GROUP("ssi0-dt-d", jz4780_ssi0_dt_d), > + INGENIC_PIN_GROUP("ssi0-dt-e", jz4770_ssi0_dt_e), > + INGENIC_PIN_GROUP("ssi0-dr-a-20", jz4780_ssi0_dr_a_20), > + INGENIC_PIN_GROUP("ssi0-dr-a-27", jz4780_ssi0_dr_a_27), > + INGENIC_PIN_GROUP("ssi0-dr-b", jz4780_ssi0_dr_b), > + INGENIC_PIN_GROUP("ssi0-dr-d", jz4780_ssi0_dr_d), > + INGENIC_PIN_GROUP("ssi0-dr-e", jz4770_ssi0_dr_e), > + INGENIC_PIN_GROUP("ssi0-clk-a", jz4780_ssi0_clk_a), > + INGENIC_PIN_GROUP("ssi0-clk-b-5", jz4780_ssi0_clk_b_5), > + INGENIC_PIN_GROUP("ssi0-clk-b-28", jz4780_ssi0_clk_b_28), > + INGENIC_PIN_GROUP("ssi0-clk-d", jz4780_ssi0_clk_d), > + INGENIC_PIN_GROUP("ssi0-clk-e", jz4770_ssi0_clk_e), > + INGENIC_PIN_GROUP("ssi0-gpc-b", jz4780_ssi0_gpc_b), > + INGENIC_PIN_GROUP("ssi0-gpc-d", jz4780_ssi0_gpc_d), > + INGENIC_PIN_GROUP("ssi0-gpc-e", jz4770_ssi0_gpc_e), > + INGENIC_PIN_GROUP("ssi0-ce0-a-23", jz4780_ssi0_ce0_a_23), > + INGENIC_PIN_GROUP("ssi0-ce0-a-25", jz4780_ssi0_ce0_a_25), > + INGENIC_PIN_GROUP("ssi0-ce0-b", jz4780_ssi0_ce0_b), > + INGENIC_PIN_GROUP("ssi0-ce0-d", jz4780_ssi0_ce0_d), > + INGENIC_PIN_GROUP("ssi0-ce0-e", jz4770_ssi0_ce0_e), > + INGENIC_PIN_GROUP("ssi0-ce1-b", jz4780_ssi0_ce1_b), > + INGENIC_PIN_GROUP("ssi0-ce1-d", jz4780_ssi0_ce1_d), > + INGENIC_PIN_GROUP("ssi0-ce1-e", jz4770_ssi0_ce1_e), > + INGENIC_PIN_GROUP("ssi1-dt-b", jz4780_ssi1_dt_b), > + INGENIC_PIN_GROUP("ssi1-dt-d", jz4780_ssi1_dt_d), > + INGENIC_PIN_GROUP("ssi1-dt-e", jz4770_ssi1_dt_e), > + INGENIC_PIN_GROUP("ssi1-dr-b", jz4780_ssi1_dr_b), > + INGENIC_PIN_GROUP("ssi1-dr-d", jz4780_ssi1_dr_d), > + INGENIC_PIN_GROUP("ssi1-dr-e", jz4770_ssi1_dr_e), > + INGENIC_PIN_GROUP("ssi1-clk-b", jz4780_ssi1_clk_b), > + INGENIC_PIN_GROUP("ssi1-clk-d", jz4780_ssi1_clk_d), > + INGENIC_PIN_GROUP("ssi1-clk-e", jz4770_ssi1_clk_e), > + INGENIC_PIN_GROUP("ssi1-gpc-b", jz4780_ssi1_gpc_b), > + INGENIC_PIN_GROUP("ssi1-gpc-d", jz4780_ssi1_gpc_d), > + INGENIC_PIN_GROUP("ssi1-gpc-e", jz4770_ssi1_gpc_e), > + INGENIC_PIN_GROUP("ssi1-ce0-b", jz4780_ssi1_ce0_b), > + INGENIC_PIN_GROUP("ssi1-ce0-d", jz4780_ssi1_ce0_d), > + INGENIC_PIN_GROUP("ssi1-ce0-e", jz4770_ssi1_ce0_e), > + INGENIC_PIN_GROUP("ssi1-ce1-b", jz4780_ssi1_ce1_b), > + INGENIC_PIN_GROUP("ssi1-ce1-d", jz4780_ssi1_ce1_d), > + INGENIC_PIN_GROUP("ssi1-ce1-e", jz4770_ssi1_ce1_e), > INGENIC_PIN_GROUP("mmc0-1bit-a", jz4770_mmc0_1bit_a), > INGENIC_PIN_GROUP("mmc0-4bit-a", jz4770_mmc0_4bit_a), > INGENIC_PIN_GROUP("mmc0-8bit-a", jz4780_mmc0_8bit_a), > @@ -972,6 +1221,22 @@ static const struct group_desc jz4780_groups[]=20 > =3D { >=20 > static const char *jz4780_uart2_groups[] =3D { "uart2-data",=20 > "uart2-hwflow", }; > static const char *jz4780_uart4_groups[] =3D { "uart4-data", }; > +static const char *jz4780_ssi0_groups[] =3D { > + "ssi0-dt-a-19", "ssi0-dt-a-21", "ssi0-dt-a-28", "ssi0-dt-b",=20 > "ssi0-dt-d", "ssi0-dt-e", > + "ssi0-dr-a-20", "ssi0-dr-a-27", "ssi0-dr-b", "ssi0-dr-d",=20 > "ssi0-dr-e", > + "ssi0-clk-a", "ssi0-clk-b-5", "ssi0-clk-b-28", "ssi0-clk-d",=20 > "ssi0-clk-e", > + "ssi0-gpc-b", "ssi0-gpc-d", "ssi0-gpc-e", > + "ssi0-ce0-a-23", "ssi0-ce0-a-25", "ssi0-ce0-b", "ssi0-ce0-d",=20 > "ssi0-ce0-e", > + "ssi0-ce1-b", "ssi0-ce1-d", "ssi0-ce1-e", > +}; > +static const char *jz4780_ssi1_groups[] =3D { > + "ssi1-dt-b", "ssi1-dt-d", "ssi1-dt-e", > + "ssi1-dr-b", "ssi1-dr-d", "ssi1-dr-e", > + "ssi1-clk-b", "ssi1-clk-d", "ssi1-clk-e", > + "ssi1-gpc-b", "ssi1-gpc-d", "ssi1-gpc-e", > + "ssi1-ce0-b", "ssi1-ce0-d", "ssi1-ce0-e", > + "ssi1-ce1-b", "ssi1-ce1-d", "ssi1-ce1-e", > +}; > static const char *jz4780_mmc0_groups[] =3D { > "mmc0-1bit-a", "mmc0-4bit-a", "mmc0-8bit-a", > "mmc0-1bit-e", "mmc0-4bit-e", > @@ -997,6 +1262,8 @@ static const struct function_desc=20 > jz4780_functions[] =3D { > { "uart2", jz4780_uart2_groups, ARRAY_SIZE(jz4780_uart2_groups), }, > { "uart3", jz4770_uart3_groups, ARRAY_SIZE(jz4770_uart3_groups), }, > { "uart4", jz4780_uart4_groups, ARRAY_SIZE(jz4780_uart4_groups), }, > + { "ssi0", jz4780_ssi0_groups, ARRAY_SIZE(jz4780_ssi0_groups), }, > + { "ssi1", jz4780_ssi1_groups, ARRAY_SIZE(jz4780_ssi1_groups), }, > { "mmc0", jz4780_mmc0_groups, ARRAY_SIZE(jz4780_mmc0_groups), }, > { "mmc1", jz4780_mmc1_groups, ARRAY_SIZE(jz4780_mmc1_groups), }, > { "mmc2", jz4780_mmc2_groups, ARRAY_SIZE(jz4780_mmc2_groups), }, > -- > 2.11.0 >=20