From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BD0C38552C for ; Sun, 5 Jul 2026 15:14:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783264480; cv=none; b=BYVgxArqSYuX72cuWSm7gnyNUhfRniLJvGo+1UwRd6zZK7nEitKc0txQdcXvh+WxqRqJPPAjyVvk68BrfZkasf84yCS3nJbWiGD+9fikx/bMqGVTuJi6XjZR3IRXQ47IISfqoFKNeiwsbNalvOSnqpnpUg9VKDRG19OmDVymlns= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783264480; c=relaxed/simple; bh=sNOvo1j1BVK2SkKs2iy52ofW6GrhDki84ncViUoGyRI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=S7sRadyMk8Vqb4UDaBchETIF2TcfYhUXtP9Z5Cf3jrh3vpWjIHHv5HU8aePL4sjUN6b1eKD/z8LxY7LICB0bhJ5r8cikCx9CV9sk37gOJQ9KJShUtLgxkag0/WfDd7yO1/pBu/uI/WlnwSun1RWjGHPpmhIMSQ1ojsmWkLy9kcE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=pCTXEs2k; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="pCTXEs2k" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4938d5f86f3so12571675e9.1 for ; Sun, 05 Jul 2026 08:14:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1783264478; x=1783869278; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=v9j6+7Y60iUAiJX3tBBkrUAq02eEDb2OjNu4wGwISMQ=; b=pCTXEs2kQsQ3VyEodlak1FZO2ehHwrdJXKFkRdrzE0nT2A/RVjMI1VCyxlPsOr5oG0 +bpnkUuYnrEE9CDfKD3DeeY4t4xJ7YL5+oEZliyCXEuKQ3U5ay4JoFe6o3V28IK7zwmj +B0BAknsjwldhpGT5u0Kji7PlpYZn+PlIzEttepS+3eB2BKYgEtSvni7iqLFmBa0Q4KG 5zMOIGXoR0ptTi+JzEJBW0s2zC5vREvfXBKv5JLcbyInTYdBHeIDjVtmePbuc1vYEf68 yFjFJKaAxlWBeUA+ywlaCJB7LcebX8bqZ/HzlRWT8x5b3x0ng9NpBIKnu5n4fLA8M5h6 wtzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783264478; x=1783869278; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=v9j6+7Y60iUAiJX3tBBkrUAq02eEDb2OjNu4wGwISMQ=; b=XIqzw9LSpqQsXXyIlcGBEjVKch8MSEBFxh6+D7mhGb0LaTZwthlbe6NP4UvBtEi60g S9jdXrSx2VaQ8/LgloNF6dtuxi1AUxm7ZyRgRvpBcEJz/Ld3zPCzQsPIh13oz9FbltHd 8rYVDTgut2YAAtvJlwU7p+9CBl9/dYfUSdt/y0SVckyXvaikQj4npHHEa1MPEhAEc/Jz KQco+lV5s5QeR3sudB8TvT/dXYzqa2SzeKD0Z8pcEJU6YIZR3HJbLTtNV9/1RbLVbqYz FW2trdSUOtQBMQybGDg5tmLWUzG2ZZTHzFLmzV1J/pi81kG2oJC3tvptoS2/XVYOw1zq 1v1g== X-Forwarded-Encrypted: i=1; AHgh+Rr+fEE8nmQ3+EQRVFDjUjaDBgoHB7OkMYp/8TvfwigQe6P1wRyvKo5dLTLq8ezzC0aJKIYLDCcBfPPfTiY=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8GQS9L6Kymike7o2wxUbOHu41i9rnQvpeZjXlWk9oCVGGzy98 Jzu0m12dj5JSPhnEeT95oQWt3rrB3j4tTxb1XxeXZ08Xc6j4qeSu506bV5szV7Yl4G5lPh55JTW tkqVm X-Gm-Gg: AfdE7cnPgcdG34UmxZYitCvnvkINdN8uFWtHhAwM/aZ17uu+ZxDaTDtf/Hb+FecDYyw rBwgI5Zv4YGfldEBb9G6CgNwJ4ztuQF5TYiWYEOopPJfCrYeFbj7eCK5LJRRyLNZei9ZwL0Vyat wjnpXiXWErDwr/ZSkL6+E90NAP8RzhrLf6sLF/YvWtah7PE0F8KjTlX+cLogDNjxZIM9mgxPsxO L4/Tg5CXYjAks2uE/jYOeWNET3Z0cwjKjAAVbGysyZfuwHmAmHIqYe9oTSjDvLJyPzACU0qvytj XYwkLIPnCCPiWGdk0KV848C3HGFp5Y3NT/pXSgbNT4P3165TRa1O1wBzh63LP51cxw9E7dvD9BV QHlU044dSBNC70iVLyaYUT4bADM8JlYYPXXgpaxT0ipYJXNyd2mUcFgksgasf5zSqstnoIZmfRe 3kJSXYyr8fCFhM55c5OQ== X-Received: by 2002:a05:600c:c0d1:10b0:492:714d:8c4 with SMTP id 5b1f17b1804b1-493d149688amr49186055e9.11.1783264477641; Sun, 05 Jul 2026 08:14:37 -0700 (PDT) Received: from localhost ([2a02:8071:56d1:2de0:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-493ccb4cafesm197853905e9.0.2026.07.05.08.14.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Jul 2026 08:14:36 -0700 (PDT) From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= To: linux-pwm@vger.kernel.org Cc: Binbin Zhou , linux-kernel@vger.kernel.org Subject: [PATCH v1 2/5] pwm: Use named initializers for arrays of acpi_device_id Date: Sun, 5 Jul 2026 17:14:14 +0200 Message-ID: <1a03da9625e1e6bf2befa13c64525e2dfa2243e7.1783263835.git.ukleinek@kernel.org> X-Mailer: git-send-email 2.55.0.11.g153666a7d9bb In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Developer-Signature: v=1; a=openpgp-sha256; l=2684; i=u.kleine-koenig@baylibre.com; h=from:subject:message-id; bh=sNOvo1j1BVK2SkKs2iy52ofW6GrhDki84ncViUoGyRI=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBqSnTJSyRmkypgw36sK8aHoqb+zHDRV06KBkwP6 E8bP2r+FTuJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCakp0yQAKCRCPgPtYfRL+ TmZNB/9zEMQWLkWGfUDpjmO6cvTqolXHrSgV6jrib3HotepTLsJnPdFQKLhKAbqRZFl9RCNgcrZ QQuXFiV06J3Q16c5jdG4y+ZFCrqlM+P9vKoM7n1Lct6OpmMmDo4YwS3ZlJ+0WpRTTUEySgJoV/A 9T2TTUgLPllYQQf/zEMzBvgJQ8SJNYqPraqa+BU7jopKmveoPHVyunWQWlRmYqUwInTe6XzJZ1D OITAhwe03BAtJUIPS/F043JsX5x/+c6EVTIIEUDpIfwpIc/CAFVN1H809XdTQoM+OS8xQeu9SYS VwVdW7muGT01TzhtKzvbfj95rZbkibzWP9xCmK6Gnz2iLLAM X-Developer-Key: i=u.kleine-koenig@baylibre.com; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: 8bit While being less compact, using named initializers allows to more easily see which members of the structs are assigned which value without having to lookup the declaration of the struct. And it's also more robust against changes to the struct definition. The mentioned robustness is relevant for a planned change to struct acpi_device_id that replaces .driver_data by an anonymous union. This patch doesn't modify the compiled arrays, only their representation in source form benefits. Signed-off-by: Uwe Kleine-König (The Capable Hub) --- drivers/pwm/pwm-loongson.c | 2 +- drivers/pwm/pwm-lpss-platform.c | 8 ++++---- drivers/pwm/pwm-pca9685.c | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/pwm/pwm-loongson.c b/drivers/pwm/pwm-loongson.c index 31a57edecfd0..f2fb35b7af2b 100644 --- a/drivers/pwm/pwm-loongson.c +++ b/drivers/pwm/pwm-loongson.c @@ -269,7 +269,7 @@ static const struct of_device_id pwm_loongson_of_ids[] = { MODULE_DEVICE_TABLE(of, pwm_loongson_of_ids); static const struct acpi_device_id pwm_loongson_acpi_ids[] = { - { "LOON0006" }, + { .id = "LOON0006" }, { } }; MODULE_DEVICE_TABLE(acpi, pwm_loongson_acpi_ids); diff --git a/drivers/pwm/pwm-lpss-platform.c b/drivers/pwm/pwm-lpss-platform.c index 653ec9d0c8bf..0d4f8bf04e9f 100644 --- a/drivers/pwm/pwm-lpss-platform.c +++ b/drivers/pwm/pwm-lpss-platform.c @@ -59,10 +59,10 @@ static int pwm_lpss_probe_platform(struct platform_device *pdev) } static const struct acpi_device_id pwm_lpss_acpi_match[] = { - { "80860F09", (unsigned long)&pwm_lpss_byt_info }, - { "80862288", (unsigned long)&pwm_lpss_bsw_info }, - { "80862289", (unsigned long)&pwm_lpss_bsw_info }, - { "80865AC8", (unsigned long)&pwm_lpss_bxt_info }, + { .id = "80860F09", .driver_data = (unsigned long)&pwm_lpss_byt_info }, + { .id = "80862288", .driver_data = (unsigned long)&pwm_lpss_bsw_info }, + { .id = "80862289", .driver_data = (unsigned long)&pwm_lpss_bsw_info }, + { .id = "80865AC8", .driver_data = (unsigned long)&pwm_lpss_bxt_info }, { }, }; MODULE_DEVICE_TABLE(acpi, pwm_lpss_acpi_match); diff --git a/drivers/pwm/pwm-pca9685.c b/drivers/pwm/pwm-pca9685.c index 617a74de68c7..0982ba4f566c 100644 --- a/drivers/pwm/pwm-pca9685.c +++ b/drivers/pwm/pwm-pca9685.c @@ -544,7 +544,7 @@ static const struct i2c_device_id pca9685_id[] = { MODULE_DEVICE_TABLE(i2c, pca9685_id); static const struct acpi_device_id pca9685_acpi_ids[] = { - { "INT3492" }, + { .id = "INT3492" }, { /* sentinel */ }, }; MODULE_DEVICE_TABLE(acpi, pca9685_acpi_ids); -- 2.55.0.11.g153666a7d9bb