From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14394C433F5 for ; Tue, 7 Sep 2021 10:41:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F049F610F8 for ; Tue, 7 Sep 2021 10:41:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243633AbhIGKmv (ORCPT ); Tue, 7 Sep 2021 06:42:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231329AbhIGKmu (ORCPT ); Tue, 7 Sep 2021 06:42:50 -0400 Received: from yawp.biot.com (yawp.biot.com [IPv6:2a01:4f8:10a:8e::fce2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B5ACC061575 for ; Tue, 7 Sep 2021 03:41:44 -0700 (PDT) Received: from debian-spamd by yawp.biot.com with sa-checked (Exim 4.93) (envelope-from ) id 1mNYXu-00CHF7-94 for linux-kernel@vger.kernel.org; Tue, 07 Sep 2021 12:41:42 +0200 Received: from [85.234.217.28] (helo=[10.0.1.5]) by yawp.biot.com with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1mNYXu-00CHEw-3j; Tue, 07 Sep 2021 12:41:42 +0200 Subject: Re: [PATCH v2 5/5] ARM: multi_v7_defconfig: Add support for Airoha EN7523 SoC To: Dmitry Osipenko Cc: devicetree@vger.kernel.org, John Crispin , Russell King , Alexandre Torgue , Krzysztof Kozlowski , Arnd Bergmann , Olivier Moysan , Marek Szyprowski , Manivannan Sadhasivam , Grygorii Strashko , Florian Fainelli , Fabrice Gasnier , Lionel Debieve , Alexandre Belloni , Stefan Wahren , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20210907102722.47543-1-bert@biot.com> <20210907102722.47543-6-bert@biot.com> <93abbefa-1ee6-7913-a41e-3e587e9a747a@gmail.com> From: Bert Vermeulen Message-ID: <1a04688d-46fc-8885-feba-d2ffa532f2d9@biot.com> Date: Tue, 7 Sep 2021 12:41:41 +0200 MIME-Version: 1.0 In-Reply-To: <93abbefa-1ee6-7913-a41e-3e587e9a747a@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/7/21 12:39 PM, Dmitry Osipenko wrote: > 07.09.2021 13:27, Bert Vermeulen пишет: >> From: John Crispin >> >> This enables basic bootup support for the Airoha EN7523 SoC. >> >> Signed-off-by: John Crispin >> Signed-off-by: Bert Vermeulen >> --- >> arch/arm/configs/multi_v7_defconfig | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig >> index d9abaae118dd..a9370a95dc38 100644 >> --- a/arch/arm/configs/multi_v7_defconfig >> +++ b/arch/arm/configs/multi_v7_defconfig >> @@ -31,6 +31,7 @@ CONFIG_MACH_BERLIN_BG2=y >> CONFIG_MACH_BERLIN_BG2CD=y >> CONFIG_MACH_BERLIN_BG2Q=y >> CONFIG_ARCH_DIGICOLOR=y >> +CONFIG_ARCH_AIROHA=y >> CONFIG_ARCH_EXYNOS=y >> CONFIG_ARCH_HIGHBANK=y >> CONFIG_ARCH_HISI=y >> @@ -983,6 +984,7 @@ CONFIG_STAGING_BOARD=y >> CONFIG_MFD_CROS_EC_DEV=m >> CONFIG_CROS_EC_I2C=m >> CONFIG_CROS_EC_SPI=m >> +CONFIG_COMMON_CLK_EN7523=y > > If SoC doesn't work without clk support, then this option should be > auto-selected by the arch option. > > It also doesn't look like upstream kernel has COMMON_CLK_EN7523 at all. Oops, you're right -- the clock driver is coming as soon as the base system is in. I guess this option (under ARCH_AIROHA) should come in at that time as well? I'll respin after some more comments. -- Bert Vermeulen bert@biot.com